This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Optimize Gelu operator for caffe2 export #918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
geof90
force-pushed
the
export-D16849396
branch
from
6d6f1da to
80c9012
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 16, 2019
Summary: Pull Request resolved: facebookresearch#918 TIL ONNX->Caffe2 is very memory inefficient, it creates an intermediate blob for each intermediate output. So, the Gelu operator creates a lot of intermediate ops since it does a bunch of math. Fix is to use the caffe2 Gelu operator, so all that computation is captured in a single op. https://pxl.cl/HzGf Differential Revision: D16849396 fbshipit-source-id: 83010d89723f6da26403c4d87eacd42998c1a54d
Summary: Pull Request resolved: facebookresearch#918 TIL ONNX->Caffe2 is very memory inefficient, it creates an intermediate blob for each intermediate output. So, the Gelu operator creates a lot of intermediate ops since it does a bunch of math. Fix is to use the caffe2 Gelu operator, so all that computation is captured in a single op. https://pxl.cl/HzGf Differential Revision: D16849396 fbshipit-source-id: a17908daff58b2c005afbc72fcb8dc46c37d075d
geof90
force-pushed
the
export-D16849396
branch
from
80c9012 to
a1898c2
Compare
|
This pull request has been merged in e32c2a5. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
TIL ONNX->Caffe2 is very memory inefficient, it creates an intermediate blob for each intermediate output. So, the Gelu operator creates a lot of intermediate ops since it does a bunch of math.
Fix is to use the caffe2 Gelu operator, so all that computation is captured in a single op.
https://pxl.cl/HzGf
Differential Revision: D16849396