This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Move MockConfigLoader to OSS #1324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
fb-exported
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D21084986 |
Summary: Pull Request resolved: facebookresearch#1324 1. harding coding "/tmp/model.pt" in config caused race condition when multiple tests are running concurrently 2. we patched the output path with "/tmp{RANDOM_HASH}/model.pt" by MockConfigLoader 3. I want to reuse the same patch logic in OSS integration tests Differential Revision: D21084986 fbshipit-source-id: 400f6d43a134e189bb2adb1ae4a13a592df1ba7b
hudeven
force-pushed
the
export-D21084986
branch
from
37972e0 to
38f65f9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D21084986 |
|
This pull request has been merged in b098f8f. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D21084986