This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
add a new PyText get_num_examples_from_batch function in model #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D21032297 |
psuzhanhy
added a commit
to psuzhanhy/pytext
that referenced
this pull request
Apr 15, 2020
…ookresearch#1319) Summary: Pull Request resolved: facebookresearch#1319 Usually in PyText dataloader, each row (sentence) is read as an example, i.e. create List[sentences], and the number of examples in the batch is simply len(List[data]). This is not correct for language model: in LM, each word is considered as an example. Reviewed By: kmalik22 Differential Revision: D21032297 fbshipit-source-id: f04d98b1f1a1ef1a5e50c57c825633f484e1c725
psuzhanhy
force-pushed
the
export-D21032297
branch
from
e491b61 to
a49f488
Compare
|
This pull request was exported from Phabricator. Differential Revision: D21032297 |
…ookresearch#1319) Summary: Pull Request resolved: facebookresearch#1319 Provide a get_num_examples_from_batch() function to model. It is not enforce to be overriden, nor used often except for federated learning training setting. But it is used, pytext developers need to override them for their model. We override it for LMLSTM, DocModel, and QueryDocPairwiseRankingModel in this diff. Reviewed By: kmalik22 Differential Revision: D21032297 fbshipit-source-id: 2086dcb81101ffbd36debf37b38debee509cf8fc
psuzhanhy
force-pushed
the
export-D21032297
branch
from
a49f488 to
779a6cf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D21032297 |
|
This pull request has been merged in 522e079. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Usually in PyText dataloader, each row (sentence) is read as an example, i.e. create List[sentences], and the number of examples in the batch is simply len(List[data]).
This is not correct for language model: in LM, each word is considered as an example.
Reviewed By: kmalik22
Differential Revision: D21032297