Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Fix backward compatibility issue of pad_missing in LabelListTensorizer #1277

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pytext/data/tensorizers.py
Original file line number Diff line number Diff line change
Expand Up @@ -816,20 +816,20 @@ class LabelListTensorizer(LabelTensorizer):

class Config(LabelTensorizer.Config):
# pad missing label in the list, including None and empty
pad_missing: bool = True
pad_missing: bool = False

@classmethod
def from_config(cls, config: Config):
return cls(
config.pad_missing,
config.column,
config.allow_unknown,
config.pad_in_vocab,
config.label_vocab,
config.is_input,
pad_missing=config.pad_missing,
)

def __init__(self, pad_missing: bool = True, *args, **kwargs):
def __init__(self, *args, pad_missing: bool = False, **kwargs):
super().__init__(*args, **kwargs)
self.pad_missing = pad_missing

Expand Down
2 changes: 1 addition & 1 deletion pytext/data/test/tensorizers_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def test_label_list_tensors_pad_missing(self):
)
tensorizers = {
"label": LabelListTensorizer(
label_column="label", pad_in_vocab=False, allow_unknown=False
pad_missing=True, label_column="label", pad_in_vocab=False, allow_unknown=False
)
}
initialize_tensorizers(tensorizers, ds.test)
Expand Down
2 changes: 1 addition & 1 deletion pytext/data/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ def add_all(self, values) -> None:
self.add_all(value)
else:
# Don't add None or empty
if values:
if values not in [None, ""]:
self.add(values)

def add(self, value) -> None:
Expand Down