This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Add projection layer to HuggingFace encoder #1273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 9, 2020 18:18
Differential Revision: D20347426 fbshipit-source-id: 6a45fbdcf8385c00e7ffdead63cf5e1c01d019ad
Summary: TransformerSentenceEncoder supports a projecting pooled output (https://github.com/facebookresearch/pytext/blob/master/pytext/models/representations/transformer_sentence_encoder.py#L61). Adding that support for HF BERT. Shouldn't change anything functionally for any existing model Differential Revision: D20355562 fbshipit-source-id: 970041b955c31114bb3837c2ca518814454ae684
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D20355562 |
|
This pull request has been merged in 0e4c635. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: TransformerSentenceEncoder supports a projecting pooled output (https://github.com/facebookresearch/pytext/blob/master/pytext/models/representations/transformer_sentence_encoder.py#L61). Adding that support for HF BERT. Shouldn't change anything functionally for any existing model
Differential Revision: D20355562