This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Make PyText compatible with Any type #1242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D19699214 |
Summary: Pull Request resolved: facebookresearch#1242 As discussed in https://fb.workplace.com/groups/300451907202972/permalink/566773450570815/, it seems like there is no support for the following: - `Any` or `Dict[str, Any]`: PyText serailize.py complains - `Dict[str, Union[str, float]]`: bad support of Union in Dict at flow level Anyway, this is blocking and I don't see stark downside of adding interim support for `Any` in `serialize.py`. This typing issue is blocking the large stack. Reviewed By: kmalik22 Differential Revision: D19699214 fbshipit-source-id: e80287240bdcfe2a4c24957b9cfe1049ed312659
jessemin
force-pushed
the
export-D19699214
branch
from
4aa8ffd to
fd8a2d6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D19699214 |
|
This pull request has been merged in 14d942e. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As discussed in https://fb.workplace.com/groups/300451907202972/permalink/566773450570815/, it seems like there is no support for the following:
AnyorDict[str, Any]: PyText serailize.py complainsDict[str, Union[str, float]]: bad support of Union in Dict at flow levelAnyway, this is blocking and I don't see stark downside of adding interim support for
Anyinserialize.py. This typing issue is blocking the large stack.Reviewed By: kmalik22
Differential Revision: D19699214