This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Mock Tokenizer torchscriptify for training and unit test #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D18760291 |
chenyangyu1988
added a commit
to chenyangyu1988/pytext
that referenced
this pull request
Dec 13, 2019
…earch#1191) Summary: Pull Request resolved: facebookresearch#1191 Mock Tokenizer torchscriptify for training and unit test Differential Revision: D18760291 fbshipit-source-id: f8babc1769df7de609dbd6f969778a1175ee0c90
chenyangyu1988
force-pushed
the
export-D18760291
branch
from
bb85464 to
22669b5
Compare
chenyangyu1988
added a commit
to chenyangyu1988/pytext
that referenced
this pull request
Dec 13, 2019
…earch#1191) Summary: Pull Request resolved: facebookresearch#1191 Mock Tokenizer torchscriptify for training and unit test Differential Revision: D18760291 fbshipit-source-id: f1457bbf7bc4c0238f5d5b152cfe94408532e71a
chenyangyu1988
force-pushed
the
export-D18760291
branch
from
22669b5 to
91870a4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18760291 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D18760291 |
chenyangyu1988
added a commit
to chenyangyu1988/pytext
that referenced
this pull request
Dec 13, 2019
…earch#1191) Summary: Pull Request resolved: facebookresearch#1191 Mock Tokenizer torchscriptify for training and unit test Differential Revision: D18760291 fbshipit-source-id: 3d51d2cb7d7a634498d82a46059172c329ddf117
chenyangyu1988
force-pushed
the
export-D18760291
branch
from
91870a4 to
11a0dcf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18760291 |
chenyangyu1988
added a commit
to chenyangyu1988/pytext
that referenced
this pull request
Dec 13, 2019
Summary: Pull Request resolved: facebookresearch#1191 TorchScriptify Tokenizer after training because we don't use torchscripted tokenizer during training time, and if we need to torchscriptify tokenizer before training, it might block user on experiment. Differential Revision: D18760291 fbshipit-source-id: c00b5cdca827bac4231f90710025518fbdde3b6b
chenyangyu1988
force-pushed
the
export-D18760291
branch
from
11a0dcf to
85b005b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18760291 |
chenyangyu1988
added a commit
to chenyangyu1988/pytext
that referenced
this pull request
Dec 13, 2019
Summary: Pull Request resolved: facebookresearch#1191 TorchScriptify Tokenizer after training because we don't use torchscripted tokenizer during training time, and if we need to torchscriptify tokenizer before training, it might block user on experiment. Differential Revision: D18760291 fbshipit-source-id: 0d6d31135ed09c584f7168c03ec7d1ab1724b3f0
chenyangyu1988
force-pushed
the
export-D18760291
branch
from
85b005b to
e72198b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18760291 |
chenyangyu1988
added a commit
to chenyangyu1988/pytext
that referenced
this pull request
Dec 15, 2019
Summary: Pull Request resolved: facebookresearch#1191 TorchScriptify Tokenizer after training because we don't use torchscripted tokenizer during training time, and if we need to torchscriptify tokenizer before training, it might block user on experiment. Differential Revision: D18760291 fbshipit-source-id: 97748adcfc361247d29aab939032be93eb9c7812
chenyangyu1988
force-pushed
the
export-D18760291
branch
from
e72198b to
a226b14
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18760291 |
Summary: Pull Request resolved: facebookresearch#1191 TorchScriptify Tokenizer after training because we don't use torchscripted tokenizer during training time, and if we need to torchscriptify tokenizer before training, it might block user on experiment. Differential Revision: D18760291 fbshipit-source-id: fc625a2e325955062bf4f0d2cda3c2a063937e3e
chenyangyu1988
force-pushed
the
export-D18760291
branch
from
a226b14 to
70ab443
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18760291 |
|
This pull request has been merged in fd5edc7. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Mock Tokenizer torchscriptify for training and unit test
Differential Revision: D18760291