This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Add support for Torchscript export of IntentSlotOutputLayer and CRF #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D18565235 |
abhinavarora
added a commit
to abhinavarora/pytext
that referenced
this pull request
Nov 18, 2019
…acebookresearch#1146) Summary: Pull Request resolved: facebookresearch#1146 This diff does the following: 1. Modifies `IntentSlotOutputLayer`, `WordTaggingOutputLayer` and `CRFOutputLayer` for torchscript export. 1. Makes CRF implementation torchscriptable 1. Fixes `predict` method of `NewTask` to make sure it passes model context as well to `get_pred` 1. Fixes return type of the `forward` method of the decoder to return tuples of tensors instead of lists of tensors. Differential Revision: D18565235 fbshipit-source-id: 732366baee95525e993ba1061c8d34bae66a7ed9
abhinavarora
force-pushed
the
export-D18565235
branch
from
82e7163 to
346b6c2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18565235 |
abhinavarora
added a commit
to abhinavarora/pytext
that referenced
this pull request
Nov 18, 2019
…acebookresearch#1146) Summary: Pull Request resolved: facebookresearch#1146 This diff does the following: 1. Modifies `IntentSlotOutputLayer`, `WordTaggingOutputLayer` and `CRFOutputLayer` for torchscript export. 1. Makes CRF implementation torchscriptable 1. Fixes `predict` method of `NewTask` to make sure it passes model context as well to `get_pred` 1. Fixes return type of the `forward` method of the decoder to return tuples of tensors instead of lists of tensors. Reviewed By: liaimi Differential Revision: D18565235 fbshipit-source-id: 34828cc4faf70fd52619fbb1b624e75ef71a3d0d
abhinavarora
force-pushed
the
export-D18565235
branch
from
346b6c2 to
f568054
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18565235 |
…acebookresearch#1146) Summary: Pull Request resolved: facebookresearch#1146 This diff does the following: 1. Modifies `IntentSlotOutputLayer`, `WordTaggingOutputLayer` and `CRFOutputLayer` for torchscript export. 1. Makes CRF implementation torchscriptable 1. Fixes `predict` method of `NewTask` to make sure it passes model context as well to `get_pred` 1. Fixes return type of the `forward` method of the decoder to return tuples of tensors instead of lists of tensors. Reviewed By: liaimi Differential Revision: D18565235 fbshipit-source-id: bff6193e7328a85ca300fba21bbebe1407bdd41b
abhinavarora
force-pushed
the
export-D18565235
branch
from
f568054 to
5516f8e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18565235 |
|
This pull request has been merged in 6dd8fcc. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff does the following:
Modifies
IntentSlotOutputLayer,WordTaggingOutputLayerandCRFOutputLayerfor torchscript export.Makes CRF implementation torchscriptable
Fixes
predictmethod ofNewTaskto make sure it passes model context as well toget_predFixes return type of the
forwardmethod of the decoder to return tuples of tensors instead of lists of tensors.Differential Revision: D18565235