This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Complete training loop gracefully even if no timing is reported #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: PyText always requires/assums that at least one "timing" exists at the end of the training and tries to print it as an ascii table. However, if one simply does not have any `timing.time("foo")` call during the training, the entire training loop crashes in the end, which is I don't think desirable behavior and not all people might not be that interested in timing info at the early phase iteration/research.
Differential Revision: D18461987
fbshipit-source-id: ed3e2918ced9f12d172c489cf9ef3b0237729aca
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D18461987 |
|
This pull request has been merged in 0ecf863. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: PyText always requires/assums that at least one "timing" exists at the end of the training and tries to print it as an ascii table. However, if one simply does not have any
timing.time("foo")call during the training, the entire training loop crashes in the end, which is I don't think desirable behavior and not all people might not be that interested in timing info at the early phase iteration/research.Differential Revision: D18461987