Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Feature} Added devignetting demo #125

Closed

Conversation

nathanjzhao
Copy link
Contributor

Addresses #99 and provides example of how to apply inverse vignette image to image in original .ipynb notebook.

@chpeng-fb
Copy link

Hi Nathan,

Thank you for creating the pull request. We are currently working on the pull request process.

In the mean time, vignetting mask is currently a general mask that is not calibrated per camera. So providing the capability as a tutorial could be misleading without understanding the risks.

Whats you thoughts on this? Does the devignetting work for your process without a problem?

Thanks
Cheng

@nathanjzhao
Copy link
Contributor Author

nathanjzhao commented Aug 25, 2024

Hi Cheng,

The devignetting works fully for my glasses without a problem, and the mask I utilized was based on the vignetting mask provided in #99, which I think was the mask emulating all front-facing cameras on Aria glasses. There could be further additions to the tutorial for accounting for various camera vignetting, but otherwise, I think the current code works unless the front-facing camera on Aria glasses changes.

Thanks,
Nathan

@AntonioMacaronio
Copy link

Is there a way to turn vignetting off when recording? I just spent a large amount of time filming data and I have come to believe I have fallen victim to the vignetting masks in my data, which has severely impacted my 3d reconstructions with gaussian splatting / neural radiance fields

@nathanjzhao
Copy link
Contributor Author

Unfortunately, vignetting is naturally a result of the fisheye lens. This is why I wanted to create a demo for devignetting images/video frames. Feel free to look at my PR for a template for how to devignette the videos!

@nathanjzhao
Copy link
Contributor Author

Hey, just wondering about the status of this PR -- Let me know if any edits are needed.

@facebook-github-bot
Copy link
Contributor

@chpeng-fb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@chpeng-fb merged this pull request in ded9b03.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants