Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of pseudoinverse in computation of preconditioners #11

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

gallego-posada
Copy link

The derivations presented in the Adagrad paper provide a principled justification for the use of _pseudo_inverses in the computation of the preconditioner matrices whenever these are not full-rank.
This PR allows for the use of pseudoinverses in Shampoo and (diagonal) Adagrad-like methods (including Adagrad, Adam, RMSProp).

This PR also enables the computation of a preconditioner matrix at the very first iteration (start_preconditioning_step=0), even in conjunction with a precondition_frequency != 1. Previous behaviour (#10 ) led to no updates taking place for the first precondition_frequency steps since the preconditioner and inverse preconditioner tensors were initialized with zeros.

@gallego-posada gallego-posada requested a review from hjmshi June 27, 2023 16:18
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2023
@facebook-github-bot
Copy link
Contributor

Hi @gallego-posada!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants