Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geometry.md #10

Closed
wants to merge 1 commit into from
Closed

Conversation

stuart-fb
Copy link
Contributor

Correct axis for camera flip rotation.

Pull Request Template

Summary
I think the docs mis-identify which axis is rotated around to convert between standard and flipped camera.

  • Briefly describe the changes made in this pull request:
    • [Insert summary of changes]

Changes

  • Describe the changes made in this pull request:
    • [Insert detailed description of changes]
    • Include relevant information about:
      • New features added
      • Bugs fixed
      • Performance improvements
      • Code refactoring

Motivation

  • Explain the motivation behind making these changes:
    • [Insert motivation behind changes]

Testing

  • Describe the testing performed to verify the changes:
    • [Insert testing details]
    • Include information about:
      • Test cases added or modified
      • Results of testing

Checklist

  • Confirm that the following have been completed:
    • Code compiles and runs successfully on all supported platforms
    • All tests pass
    • Documentation is updated (if applicable)
    • Changes follow the project's coding standards

Additional Comments

  • Any additional comments or information that may be helpful:
    • [Insert additional comments]

Correct axis for camera flip rotation.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 9, 2024
@facebook-github-bot
Copy link

@enpe has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@enpe
Copy link
Contributor

enpe commented Jul 9, 2024

Good find! Thanks for reporting it!

@facebook-github-bot
Copy link

@enpe merged this pull request in 56e00bb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants