Open
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
cdtwigg
added a commit
that referenced
this pull request
Sep 16, 2025
Summary: This naming was a bit confusing because there are many to_gltf functions, so let's specify that we're converting it to a Dict. Reviewed By: jeongseok-meta Differential Revision: D82411874
cdtwigg
force-pushed
the
export-D82411874
branch
from
ba476fb to
4e9ac38
Compare
Contributor
cdtwigg
added a commit
that referenced
this pull request
Sep 16, 2025
Summary: This naming was a bit confusing because there are many to_gltf functions, so let's specify that we're converting it to a Dict. Reviewed By: jeongseok-meta Differential Revision: D82411874
cdtwigg
force-pushed
the
export-D82411874
branch
from
4e9ac38 to
873f222
Compare
Contributor
cdtwigg
added a commit
that referenced
this pull request
Sep 17, 2025
Summary: This naming was a bit confusing because there are many to_gltf functions, so let's specify that we're converting it to a Dict. Reviewed By: jeongseok-meta Differential Revision: D82411874
cdtwigg
force-pushed
the
export-D82411874
branch
from
873f222 to
4395dc8
Compare
Contributor
cdtwigg
added a commit
that referenced
this pull request
Sep 18, 2025
Summary: This naming was a bit confusing because there are many to_gltf functions, so let's specify that we're converting it to a Dict. Reviewed By: jeongseok-meta Differential Revision: D82411874
cdtwigg
force-pushed
the
export-D82411874
branch
from
4395dc8 to
8c8ce8d
Compare
Contributor
Summary: "_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state. Reviewed By: jeongseok-meta Differential Revision: D82411872
Summary: This naming was a bit confusing because there are many to_gltf functions, so let's specify that we're converting it to a Dict. Reviewed By: jeongseok-meta Differential Revision: D82411874
cdtwigg
force-pushed
the
export-D82411874
branch
from
8c8ce8d to
95af0a2
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This naming was a bit confusing because there are many to_gltf functions, so let's specify that we're converting it to a Dict.
Reviewed By: jeongseok-meta
Differential Revision: D82411874