Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize with submitit Slurmexecutor python arg addition #2830

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −1
Open

Synchronize with submitit Slurmexecutor python arg addition #2830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8979672
add python option to slurm config
berombau Jan 5, 2024
739beb4
add python option to slurm executor
berombau Jan 5, 2024
8018b39
Merge branch 'facebookresearch:main' into main
berombau Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions plugins/hydra_submitit_launcher/hydra_plugins/hydra_submitit_launcher/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ class SlurmQueueConf(BaseQueueConf):
# check the following for more info on slurm_max_num_timeout
# https://github.com/facebookincubator/submitit/blob/main/docs/checkpointing.md
max_num_timeout: int = 0
# Python executable to use instead of the default sys.executable
python: Optional[str] = None
# Useful to add parameters which are not currently available in the plugin.
# Eg: {"mail-user": "[email protected]", "mail-type": "BEGIN"}
additional_parameters: Dict[str, Any] = field(default_factory=dict)
Expand Down
2 changes: 1 addition & 1 deletion plugins/hydra_submitit_launcher/hydra_plugins/hydra_submitit_launcher/submitit_launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def launch(
params = self.params
# build executor
init_params = {"folder": self.params["submitit_folder"]}
specific_init_keys = {"max_num_timeout"}
specific_init_keys = {"max_num_timeout", "python"}

init_params.update(
**{
Expand Down