Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optuna Sweeper Plugin]: Add user attributes to Optuna trial #2718

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Optuna Sweeper Plugin]: Add user attributes to Optuna trial #2718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions plugins/hydra_optuna_sweeper/hydra_plugins/hydra_optuna_sweeper/_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,23 +352,33 @@ def sweep(self, arguments: List[str]) -> None:
self.job_idx += len(returns)
failures = []
for trial, ret in zip(trials, returns):
values: Optional[List[float]] = None
return_value = ret.return_value
if isinstance(return_value, dict):
if "result" not in return_value:
raise KeyError("'result' key must be present in the return_value dictionary.")
result = return_value.pop("result")
user_attrs = return_value
for attr, attr_value in user_attrs.items():
trial.set_user_attr(attr, attr_value)
else:
result = return_value
state: optuna.trial.TrialState = optuna.trial.TrialState.COMPLETE
values: Optional[List[float]] = None
try:
if len(directions) == 1:
try:
values = [float(ret.return_value)]
values = [float(result)]
except (ValueError, TypeError):
raise ValueError(
f"Return value must be float-castable. Got '{ret.return_value}'."
f"Return value must be float-castable. Got '{result}'."
).with_traceback(sys.exc_info()[2])
else:
try:
values = [float(v) for v in ret.return_value]
values = [float(v) for v in result]
except (ValueError, TypeError):
raise ValueError(
"Return value must be a list or tuple of float-castable values."
f" Got '{ret.return_value}'."
f" Got '{result}'."
).with_traceback(sys.exc_info()[2])
if len(values) != len(directions):
raise ValueError(
Expand Down