Allow specifying a non-relative module name in config_path #2565
Conversation
facebook-github-bot
added
the
CLA Signed
|
Nice, thanks. |
|
The CI failures look like they are because the Netlify config is using an old Ubuntu 16.04 image, which is no longer supported. I'll ping some other folks about trying to get that config fixed. |
|
Can you ping the open source team (OSS support IIRC) about it? |
When constructing the config search path, allow callers to directly pass in a non-relative module name starting with `pkg://`. This allows callers to bypass the relative name lookup, and always get consistent behavior regardless of the current environment variables at runtime. This addresses issue facebookresearch#2564.
simpkins
force-pushed
the
abs_config_path
branch
from
c3a64a8 to
02ba236
Compare
|
The OSS team says they have fixed the website preview. I've rebased this pull request just to re-trigger the CI checks. |
|
The CI test failures look like pre-existing problems occurring on main. I sent out #2576 to auto-apply some of the black formatting fixes that are currently causing the tests to fail. |
…esearch#2565) When constructing the config search path, allow callers to directly pass in a non-relative module name starting with `pkg://`. This allows callers to bypass the relative name lookup, and always get consistent behavior regardless of the current environment variables at runtime. This addresses issue facebookresearch#2564. Co-authored-by: Adam Simpkins <[email protected]> Co-authored-by: Jasha <[email protected]>
When constructing the config search path, allow callers to directly pass in a non-relative module name starting with `pkg://`. This allows callers to bypass the relative name lookup, and always get consistent behavior regardless of the current environment variables at runtime. This addresses issue #2564. Co-authored-by: Adam Simpkins <[email protected]> Co-authored-by: Jasha <[email protected]>
Motivation
When constructing the config search path, allow callers to directly pass in a non-relative module name starting with
pkg://. This allows callers to bypass the relative name lookup, and always get consistent behavior regardless of the current environment variables at runtime.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Added a new entry in test_config_search_path.py
Related Issues and PRs
#2564