Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.11 support for plugins #2489

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

Jasha10
Copy link
Collaborator

@Jasha10 Jasha10 commented Dec 6, 2022

Follow up PR to #2418.

Add python3.11 support for plugins (except ray launcher and ax sweeper).

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2022
@Jasha10 Jasha10 marked this pull request as ready for review December 6, 2022 04:42
@Jasha10 Jasha10 merged commit c48ef19 into facebookresearch:main Dec 6, 2022
@Jasha10 Jasha10 deleted the plugins-python3.11 branch December 6, 2022 09:45
@skshetry
Copy link
Contributor

skshetry commented Dec 7, 2022

Hi @Jasha10, sorry to push for this, but when can we expect a new release? 🙂

@Jasha10
Copy link
Collaborator Author

Jasha10 commented Dec 7, 2022

Coming very soon! One or two days.

@Monrer11
Copy link

Monrer11 commented Feb 2, 2023

#@****__

@Monrer11 Monrer11 mentioned this pull request Feb 2, 2023
@Pedrexus
Copy link

Pedrexus commented Oct 19, 2023

any updates on supporting 3.11 for ray launcher and ax sweeper as well? Do you need any help with that? I use ray launcher, but had to update all dataclasses manually to make it work with 3.11

@odelalleau
Copy link
Collaborator

Do you need any help with that?

Most likely yes, if someone could put up a PR there's a higher chance this may happen.

@Pedrexus
Copy link

Is there any reference on how to run the tests for plugins? I can run the base hydra tests fine, but the plugins tests fail as they don't find the plugin for some reason.

@odelalleau
Copy link
Collaborator

Is there any reference on how to run the tests for plugins?

@Jasha10 would you be able to help with that by any chance?

@Jasha10
Copy link
Collaborator Author

Jasha10 commented Oct 20, 2023

Sure.

@Pedrexus I run the plugins (for python3.10) with the following command:

$ nox -s test_plugins-3.10

Does that work for you?

References:

@Pedrexus
Copy link

Pedrexus commented Oct 22, 2023

@Jasha10 thank you for the instructions, I was able to run the tests now.

However, the AWS tests are being skipped with the message AWS credentials not configured correctly. Skipping AWS tests. It seems the tests spin up an EC2 instance, but I think this would potentially incur costs.

I am unsure how to proceed in this case. Please advise if possible.

@Jasha10
Copy link
Collaborator Author

Jasha10 commented Oct 22, 2023

Some of the ray launcher tests are integration tests. They use ray to launch jobs on an AWS compute node.

In the past, facebook sponsored the cost of compute for running those tests, paying the AWS bills. Currently, those tests are broken and would require participation of someone inside of Facebook to set up new AWS credentials.

My advice would be to ignore the failing AWS tests and focus on the other ray launcher tests.

@Pedrexus
Copy link

Pedrexus commented Oct 28, 2023

I have opened the respective PRs for the Ax and Ray plugins.

The Ray Launcher plugin had few changes. The AWS Ray Launcher class has a deprecation warning added to it, since the tests are being skipped.

On the other hand, the Ax plugin tests were raising multiple warnings from internal Ax dependencies, and the only solution I found was to ignore the warnings for now. Please advise if there are problems with this approach.

Some changes in the Ax experiment API also required some breaking changes to the plugin.

On a side note, I have yet to test the updates on my own projects to ensure they are working as expected. I might update this message once I do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants