Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add srun_args parameter to submitit launcher #2432

Merged
merged 5 commits into from
Nov 1, 2022

Conversation

Queuecumber
Copy link
Contributor

Motivation

I needed to pass some extra parameters to srun, submitit can do this but the argument wasn't exposed by the hydra launcher

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Verified on a live slurm cluster

Related Issues and PRs

#2429

Signed-off-by: Max Ehrlich <[email protected]>
@facebook-github-bot
Copy link
Contributor

Hi @Queuecumber!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 22, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Jasha10 Jasha10 linked an issue Oct 24, 2022 that may be closed by this pull request
Copy link
Collaborator

@Jasha10 Jasha10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Queuecumber
Copy link
Contributor Author

Do you need me to do anything for this?

@Jasha10
Copy link
Collaborator

Jasha10 commented Nov 1, 2022

No. Thanks very much @Queuecumber!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Expose srun_args from the Submitit Launcher
3 participants