--Expose Attributes save functionality to python; cleanup/improve attribute registration. #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jturner65
force-pushed
the
Attr_PythonSaveConfigs
branch
2 times, most recently
from
b3a199f
to
ab12077
Compare
jturner65
changed the title
jturner65
force-pushed
the
Attr_PythonSaveConfigs
branch
2 times, most recently
from
51b951c
to
a31b0b8
Compare
jturner65
force-pushed
the
Attr_PythonSaveConfigs
branch
2 times, most recently
from
f807ac8
to
845c415
Compare
Before, required functionality was expected to be implemented in manager specializations; now this functionality is handled internally so any future specializations
Also set actual filename for loaded managedFileBasedObjects.
jturner65
force-pushed
the
Attr_PythonSaveConfigs
branch
from
845c415
to
692ac23
Compare
aclegg3
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR exposes the attributes save-to-disk functionality via python;
It expands the possible saving capabilities so that both directories and filenames can be independently specified.
It also addresses some longstanding inefficiencies and potential issues with attribute registration
How Has This Been Tested
All C++ and python tests pass locally
Types of changes
Checklist