--Articulated Object Attributes/Managers support #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jturner65
force-pushed
the
AO_AttrMgr_Main
branch
6 times, most recently
from
0785836
to
501f3d7
Compare
11 tasks
As with all JSON configs, the asset filepath is expected to be relative to the config's location on disk.
jturner65
force-pushed
the
AO_AttrMgr_Main
branch
from
501f3d7
to
af22cfd
Compare
--This specifies how to render the AO - using its skin, primitives, both or neither.
0mdc
reviewed
Aug 10, 2023
--We want to fail on load of attributes configs if certain criteria are not met.
Retain boolean "fixed base" query for now, but this will be removed in favor of only having the enum-backed value.
Remove confusion with functions that add actual instances of objects.
jturner65
changed the title
|
There's a couple linking errors in a few of the tests that I have to chase down, but functionally this is complete. Yay! |
jturner65
force-pushed
the
AO_AttrMgr_Main
branch
from
bcf811b
to
b5de5dc
Compare
Also python bindings
aclegg3
reviewed
Aug 16, 2023
jturner65
force-pushed
the
AO_AttrMgr_Main
branch
from
925bb95
to
c4609d0
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adds support for articulated object configurations as Attributes, and their management via an AttributeManager, in the same way that Object Attributes, Stage Attributes, etc, are managed.
We allowed for articulated object json files already, to describe habitat-specific fields as well as certain overrides, but they were not integrated into the Metadata system and so were of limited usefulness.
This is currently a WIP.This PR is now ready to go!The handling of configs, either loaded directly if specified with .json extension, or built on the fly if specified filename is the source URDF file, currently works, and these configs are being used explicitly during AO instantiation to reference the URDF file and build the articulated objects.
How Has This Been Tested
All existing c++ and python tests pass.
More tests will be added to test the AO Attributes and Managers' functionality directly.
Types of changes
Checklist