Skip to content

Fix Miniconda installation on CI. #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2022
Merged

Fix Miniconda installation on CI. #1977

merged 1 commit into from
Dec 27, 2022

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Dec 27, 2022 •
edited
Loading

Motivation and Context

The latest Miniconda installer (22.11.1) fails to work with sh.
This changes the invocation of miniconda.sh to bash.

How Has This Been Tested

Tested through CI.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 27, 2022
@0mdc 0mdc force-pushed the fix-ci-miniconda branch 2 times, most recently from b6c9f33 to 7cb7cbc Compare December 27, 2022 04:21
@0mdc 0mdc changed the title WIP CI Fix. Fix Miniconda installation on CI. Dec 27, 2022
@0mdc 0mdc requested review from Skylion007 and aclegg3 December 27, 2022 05:06
@Skylion007 Skylion007 merged commit 956d63e into main Dec 27, 2022
@0mdc 0mdc mentioned this pull request Dec 27, 2022
Merged
7 tasks
@0mdc 0mdc deleted the fix-ci-miniconda branch February 20, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @Skylion007 @facebook-github-bot