Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mypy] - ignore erroneous type warning in new imageio version. #1817

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Jul 18, 2022

Motivation and Context

New imageio version may have conflicting API. mypy asserts that format should be Format type, but should actually be string as written.

How Has This Been Tested

CI SSH and local

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from Skylion007 July 18, 2022 20:47
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 18, 2022
@aclegg3 aclegg3 merged commit 7afc3d3 into main Jul 19, 2022
@aclegg3 aclegg3 deleted the imageio-v2 branch July 19, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants