Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HITL - Rename RemoteGuiInput to RemoteClientState. #1852

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Mar 11, 2024

Motivation and Context

This renames RemoteGuiInput to RemoteClientState.
As we extend networking features to support multiplayer and large-scale web apps, the responsibility of this class changing. It used to only track remote input - it now tracks all information coming from a client.

How Has This Been Tested

Tested locally with a Unity client.

Types of changes

  • [Refactoring] Large changes to the code that improve its functionality or performance

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@0mdc 0mdc requested review from jturner65 and aclegg3 March 11, 2024 16:32
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 11, 2024
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add docstrings with typing on all classes and functions if possible.

@0mdc 0mdc force-pushed the 0mdc/rename_remote_client_state branch from 7a216bc to 6b89ab8 Compare March 11, 2024 23:53
@0mdc 0mdc merged commit 380febf into main Mar 12, 2024
3 of 4 checks passed
@0mdc 0mdc deleted the 0mdc/rename_remote_client_state branch March 12, 2024 00:24
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
…1852)

* Rename RemoteGuiInput to RemoteClientState.

* Add docstrings to remote_client_state.
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
…1852)

* Rename RemoteGuiInput to RemoteClientState.

* Add docstrings to remote_client_state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants