Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typing to gui_navigation_helper. #1849

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Add typing to gui_navigation_helper. #1849

merged 2 commits into from
Mar 11, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Mar 11, 2024

Motivation and Context

This changeset adds typing to HITL gui_navigation_helper.

How Has This Been Tested

Tested locally with a remote Unity client.

Types of changes

  • [Refactoring] Large changes to the code that improve its functionality or performance

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@0mdc 0mdc requested review from jturner65 and aclegg3 March 11, 2024 16:24
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 11, 2024
aclegg3
aclegg3 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for adding typing. Please add docstrings to each function and class also.

@0mdc
Copy link
Contributor Author

0mdc commented Mar 11, 2024

Please add docstrings to each function and class also.

I added some simple docstrings. I'll do another pass here as this will be adapted for multiplayer.

@0mdc 0mdc merged commit e224577 into main Mar 11, 2024
3 of 4 checks passed
@0mdc 0mdc deleted the 0mdc/gui_navigation_helper_typing branch March 11, 2024 23:49
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc
Add typing to gui_navigation_helper. (facebookresearch#1849)
dd7013b 
* Add typing to gui_navigation_helper.

* Add docstrings.
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
@0mdc
Add typing to gui_navigation_helper. (facebookresearch#1849)
e7e26a2 
* Add typing to gui_navigation_helper.

* Add docstrings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @aclegg3 @facebook-github-bot