Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region containment query utils #1820

Merged
merged 12 commits into from
Feb 23, 2024
Merged

Region containment query utils #1820

merged 12 commits into from
Feb 23, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Feb 22, 2024

Motivation and Context

Based on #1770.

This PR introduces utils for querying region containment of objects via point containment checks on bounding box global keypoints.

Supporting utils enable bounding box and keypoint extraction for ArticulatedObjects and ArticulatedLinks.

How Has This Been Tested

Added pytest using hab3_benchmark HSSD scenes.
Added region annotations to one benchmark scene and updated CI to gather those assets.

TODO: follow-up should add some unit tests for bounding box and keypoint utils tested indirectly here through the query API.

Types of changes

  • [Development] A pull request that add new features to the habitat-lab task and environment codebase. Development Pull Requests must be small (less that 500 lines of code change), have unit testing, very extensive documentation and examples. These are typically new tasks, environments, sensors, etc... The review process for these Pull Request is longer because these changes will be maintained by our core team of developers, so make sure your changes are easy to understand!

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 22, 2024
Copy link
Contributor

@jacobkrantz jacobkrantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

habitat_sim.physics.ManagedArticulatedObject,
],
region: habitat_sim.scene.SemanticRegion,
containment_threshold=0.25,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent use of keypoint thresholding across predicates; within uses keypoint_vote_threshold to the same effect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great point.
I agree that "within" and "object_in_region" are using similar but distinct mechanisms for mostly the same purpose. They could be unified.
For now, merging as-is and we'll decide if a follow-up refactor is desired.

@aclegg3 aclegg3 merged commit 0d2f333 into main Feb 23, 2024
3 of 4 checks passed
@aclegg3 aclegg3 deleted the prepositional-logic-for-eval-4 branch February 23, 2024 16:43
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants