-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Region containment query utils #1820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits
habitat_sim.physics.ManagedArticulatedObject, | ||
], | ||
region: habitat_sim.scene.SemanticRegion, | ||
containment_threshold=0.25, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent use of keypoint thresholding across predicates; within
uses keypoint_vote_threshold
to the same effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, great point.
I agree that "within" and "object_in_region" are using similar but distinct mechanisms for mostly the same purpose. They could be unified.
For now, merging as-is and we'll decide if a follow-up refactor is desired.
* add region query utils and tests
* add region query utils and tests
Motivation and Context
Based on #1770.
This PR introduces utils for querying region containment of objects via point containment checks on bounding box global keypoints.
Supporting utils enable bounding box and keypoint extraction for ArticulatedObjects and ArticulatedLinks.
How Has This Been Tested
Added pytest using hab3_benchmark HSSD scenes.
Added region annotations to one benchmark scene and updated CI to gather those assets.
TODO: follow-up should add some unit tests for bounding box and keypoint utils tested indirectly here through the query API.
Types of changes
Checklist