HITL: Limit amount of float decimals in JSON transmissions. #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
eundersander
approved these changes
Feb 9, 2024
Great question. I've been running exclusively from this code for a while now. Axis-aligned quaternions don't show precision issues, and animations are smooth (testing with skinned mesh animations). That aside, I believe that we don't have calculations that strictly depend on having normalized quaternions. As a rule of thumb, we should never trust serialized quaternions to be normalized. Initially, I was mostly concerned with Z-fighting as HSSD has lots of co-planar geometry (carpets, wall art, ...). This also works fine after decreasing prevision. |
0mdc
force-pushed
the
hitl-json-decimal-places
branch
from
d681d60
to
89f1c62
Compare
|
Changed to 4 decimal places. |
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
…research#1800) * Limit amount of float decimals in HITL JSON tranmissions. * Set max decimal places to 4.
HHYHRHY
pushed a commit
to SgtVincent/habitat-lab
that referenced
this pull request
Aug 31, 2024
…research#1800) * Limit amount of float decimals in HITL JSON tranmissions. * Set max decimal places to 4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This uses the
gfx_replay_managerAPI introduced here to limit the amount of floating point decimals used in HITL JSON serialization.How Has This Been Tested
Tested locally. Verified that this doesn't introduce z-fighting.
Types of changes
Checklist