Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-- Change ints to float in sensor spec position and orientation #1793

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

jturner65
Copy link
Contributor

Motivation and Context

In preparation for Eigen->Magnum migration being introduced in Habitat-Sim in this PR for sensor_spec position and orientation, this PR makes integer initialization constants for these fields into floats.

How Has This Been Tested

Changed files tested locally.

Types of changes

  • [Refactoring]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

In preparation for Eigen->Magnum migration.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 6, 2024
@jturner65 jturner65 changed the title --[WIP] Change ints to float in sensor spec position and orientation -- Change ints to float in sensor spec position and orientation Feb 6, 2024
@jturner65 jturner65 marked this pull request as ready for review February 6, 2024 16:17
@jturner65 jturner65 merged commit b97933e into main Feb 6, 2024
4 checks passed
@jturner65 jturner65 deleted the ints-to-floats-magnum-compat branch February 6, 2024 18:56
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants