Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use-multiprocessing and verbose flags to Unity dataset processing. #1789

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Feb 5, 2024

Motivation and Context

This adds use-multiprocessing and verbose command line arguments to the Habitat->Unity dataset processing pipeline. The multiprocessing was mostly implemented but not used.

Processing speed on my machine (32 cores, 64 threads):
unity_dataset_processing.py [...] --scenes 105515448_173104512

Single process Multi-process
48.23s 6.81s

How Has This Been Tested

Tested that the output is valid in the Unity client.

Types of changes

  • [Development]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 5, 2024
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0mdc 0mdc merged commit d4df9cc into main Feb 10, 2024
4 checks passed
@0mdc 0mdc deleted the unity-dataset-processing-multiproc branch February 10, 2024 19:31
henrysamer pushed a commit that referenced this pull request Feb 21, 2024
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants