Adapt to Magnum Python bindings update #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Also removed a comment that wasn't true -- the code doesn't perform any modifications of the original instance, it just replaces the instance a few times.
mosra
force-pushed
the
adapt-update-magnum30
branch
from
9ca2b71
to
1fe3305
Compare
jturner65
approved these changes
Jan 29, 2024
0mdc
approved these changes
Jan 29, 2024
5 tasks
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
This syntax should work with both the original API and the new one. Also removed a comment that wasn't true -- the code doesn't perform any modifications of the original instance, it just replaces the instance a few times.
HHYHRHY
pushed a commit
to SgtVincent/habitat-lab
that referenced
this pull request
Aug 31, 2024
This syntax should work with both the original API and the new one. Also removed a comment that wasn't true -- the code doesn't perform any modifications of the original instance, it just replaces the instance a few times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Counterpart to facebookresearch/habitat-sim#2309. Should however work even without that PR being merged, thus can be treated independently.
Also removed a comment that wasn't true -- the code doesn't perform any modifications of the original instance, it just replaces the instance a few times.
How Has This Been Tested
I expect the CI in facebookresearch/habitat-sim#2309 to stop failing after this change? I guess?