Fixed config habitat_hitl.episodes_filter='4' and episodes_filter episode order #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xed episodes_filter episode order not respected
facebook-github-bot
added
the
CLA Signed
eundersander
approved these changes
Jan 25, 2024
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
…xed episodes_filter episode order not respected (facebookresearch#1772)
HHYHRHY
pushed a commit
to SgtVincent/habitat-lab
that referenced
this pull request
Aug 31, 2024
…xed episodes_filter episode order not respected (facebookresearch#1772)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed error when using config habitat_hitl.episodes_filter='4' and Fixed episodes_filter episode order not respected
Types of changes
config habitat_hitl.episodes_filter='4' Casting int->str
episodes_filter episode not in order To keep the sequence, the update uses a list instead of a set to preserve order, appends/extends to list instead of adding to set, and returns the final list
Local Testing
To test this change:
Checked out branch fix/episodes_filter
Modified config.yaml to set habitat_hitl.episodes_filter='4'
Ran training job and confirmed no errors when parsing filter
Modified config.yaml to complex filter string: "1000:2000:100 3000 4000 0:10:3"
Inspected order of episode ids before and after change and confirmed order matches filter string
Ran full pipeline with updated filter logic and confirmed no issues