Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add habitat_hitl.disable_agents_and_stepping config param #1769

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

eundersander
Copy link
Contributor

@eundersander eundersander commented Jan 19, 2024

Motivation and Context

This is handy if you just want to load scenes but not run policies or otherwise simulate agents. Because this codepath bypasses all policy initialization and inference code, it's also potentially a way to test a HITL app on lower-power machines.

To use this feature, enable it through the Hydra config. You could edit the config yaml, or add a command-line argument, e.g.:
python examples/hitl/basic_viewer/basic_viewer.py habitat_hitl.disable_policies_and_stepping=True

How Has This Been Tested

Local testing on Macbook.

Types of changes

  • [HITL framework]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 19, 2024
@eundersander eundersander force-pushed the eundersander/hitl_disable_agents_and_stepping branch from a42ab20 to 6261b8c Compare January 19, 2024 00:06
Copy link
Contributor

@henrysamer henrysamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the functionality. Please, modify the "Motivation" section Readme command line:

From

python examples/hitl/basic_viewer/basic_viewer.py habitat_hitl.disable_agents_and_stepping=True

to:

python examples/hitl/basic_viewer/basic_viewer.py +habitat_hitl.disable_agents_and_stepping=True

@eundersander eundersander merged commit 2e6fb83 into main Jan 23, 2024
4 checks passed
@eundersander eundersander deleted the eundersander/hitl_disable_agents_and_stepping branch January 23, 2024 14:25
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants