-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for headless HITL apps, first pass #1768
Conversation
@@ -0,0 +1,13 @@ | |||
# @package _global_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"experiment" is an odd name for a folder that conceptually contains config overrides, but Hydra is really confusing and I was looking to match the naming convention they use in their docs and examples. The name here is unrelated to my use of "experimental" in the config, btw--in the future, we'll put all config overrides in this folder, even if they're not experimental features.
Tested the changes from this PR on my Mac (Intel i9, Intel UHD Graphics 630). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-Docstrings for DebugVideoWriter and StubTextDrawer recommended.
-can keep the name Appdriver for now
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* add DebugVideoWriter * fix for FrequencyLimiter * polish for AverageRateTracker * add headless mode with stub versions of DebugLineRender, GuiInput, and TextDrawer * update README * add docstrings for DebugVideoWriter and StubTextDrawer
* add DebugVideoWriter * fix for FrequencyLimiter * polish for AverageRateTracker * add headless mode with stub versions of DebugLineRender, GuiInput, and TextDrawer * update README * add docstrings for DebugVideoWriter and StubTextDrawer
Motivation and Context
"Headless" means no attached local display. A headless mode is useful for (1) unit-testing on headless CI machines, and (2) the client/server model, with Pick_throw_vr running as a server (
remote_gui_mode
) on e.g. a headless cloud machine.With this PR, the Unity client can connect to the headless server and e.g. view the animated scene. However, as a first pass, this doesn't actually 100% work with clients yet because of the way I've completely stubbed out GuiInput (which RemoteGuiInput needs).
How Has This Been Tested
Locally tested on Macbook. Tested on headless Ubuntu EC2 instance with Unity client connected.
Types of changes
Checklist