Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate SMPLX humanoid models + bug fix generate motions #1720

Merged
merged 11 commits into from
Jan 20, 2024

Conversation

xavierpuigf
Copy link
Contributor

Motivation and Context

This PR allows to generate new SMPL-X body models to be used in Habitat. It also adds hands to the avatar motion.

How Has This Been Tested

Ran script and pytest.

Types of changes

  • [Development] A pull request that add new features to the habitat-lab task and environment codebase. Development Pull Requests must be small (less that 500 lines of code change), have unit testing, very extensive documentation and examples. These are typically new tasks, environments, sensors, etc... The review process for these Pull Request is longer because these changes will be maintained by our core team of developers, so make sure your changes are easy to understand!

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 18, 2023
@xavierpuigf xavierpuigf changed the title [WIP] Generate SMPLX humanoid models + bug fix generate motions Generate SMPLX humanoid models + bug fix generate motions Jan 17, 2024
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, thanks for adding the script and details. 👍

####### Export GLTF code ######


def smplx_export_gltf(filepath):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add docstrings, typehints, etc... to all functions. :)

)


def main():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comment here about how to run this from CLI w/ blender and linking to the README would be helpful.

@xavierpuigf xavierpuigf merged commit da51b4c into main Jan 20, 2024
3 of 4 checks passed
@0mdc
Copy link
Contributor

0mdc commented Jan 22, 2024

Belated LGTM!

@0mdc 0mdc deleted the addon_humanoid branch January 22, 2024 16:48
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
…search#1720)

* working script

* add hand and fingers

* updated readme

* updates

* update script

* linting

* udpates addon humanoid

* typing

* typing

* typing
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
…search#1720)

* working script

* add hand and fingers

* updated readme

* updates

* update script

* linting

* udpates addon humanoid

* typing

* typing

* typing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants