Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

social nav readme #1699

Merged
merged 5 commits into from
Nov 29, 2023
Merged

social nav readme #1699

merged 5 commits into from
Nov 29, 2023

Conversation

jimmytyyang
Copy link
Contributor

Motivation and Context

This is needed to reproduce what we did for social nav in habitat3 paper.

How Has This Been Tested

The social nav training has been verified in habitat `main`

Types of changes

  • [Docs change] Addition or changes to the documentation

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 27, 2023
0mdc
0mdc approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@0mdc 0mdc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left some minor comments.

habitat-baselines/README.md Outdated Show resolved Hide resolved
habitat-baselines/README.md Outdated Show resolved Hide resolved
habitat-baselines/README.md Outdated Show resolved Hide resolved
habitat-baselines/README.md Outdated Show resolved Hide resolved
habitat-baselines/README.md Outdated Show resolved Hide resolved
habitat-baselines/README.md Outdated Show resolved Hide resolved
habitat-baselines/README.md Outdated Show resolved Hide resolved
xavierpuigf
xavierpuigf approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@xavierpuigf xavierpuigf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Jimmy! Looks good to me

@jimmytyyang jimmytyyang merged commit 480f393 into main Nov 29, 2023
4 checks passed
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@jimmytyyang
social nav readme (facebookresearch#1699)
233de38 
* add social nav readme

* update format

* add FPS

* add comments

* fix typo

---------

Co-authored-by: Jimmy Yang <[email protected]>
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
@jimmytyyang
social nav readme (facebookresearch#1699)
8b75a68 
* add social nav readme

* update format

* add FPS

* add comments

* fix typo

---------

Co-authored-by: Jimmy Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavierpuigf xavierpuigf xavierpuigf approved these changes

@0mdc 0mdc 0mdc approved these changes

@ASzot ASzot Awaiting requested review from ASzot

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jimmytyyang @xavierpuigf @0mdc @facebook-github-bot