Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spot social nav #1658

Merged
merged 24 commits into from
Nov 11, 2023
Merged

Spot social nav #1658

merged 24 commits into from
Nov 11, 2023

Conversation

jimmytyyang
Copy link
Contributor

@jimmytyyang jimmytyyang commented Oct 30, 2023

Motivation and Context

This PR improves the design of the social nav. It is designed specifically for learning a social nav policy for the Boston Dynamics Spot robot. The major changes compared to the base yaml are the following:

(1) obs_keys: we ensure these observations can be obtained from the real robot (Spot)
(2) social_nav_reward: social nav reward considers collisions based on a kinematic simulation
(3) actions: Spot controls the base linear and angualr velocity
(4) simulator: we simulate the environment via the kinematic mode to facilitate sim2real transfer

In addition, this PR provides a couple of improvement:
(1) Fix the bug calling _agent.init_distributed()
(2) Allow the social nav reward function takes the kinematic force termination info
(3) real world spot sensors

This PR is tight to the theme of Better Documentation/Better Engineering

How Has This Been Tested

Complete a full sweep of hyper-parameters (collision penalty), and the training reward improves in 4 days of learning. Screenshot 2023-11-05 at 10 02 00 AM

Types of changes

  • [Development] A pull request that add new features to the habitat-lab task and environment codebase. Development Pull Requests must be small (less that 500 lines of code change), have unit testing, very extensive documentation and examples. These are typically new tasks, environments, sensors, etc... The review process for these Pull Request is longer because these changes will be maintained by our core team of developers, so make sure your changes are easy to understand!

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 30, 2023
@jimmytyyang jimmytyyang marked this pull request as ready for review November 5, 2023 02:52
Copy link
Collaborator

@ASzot ASzot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comments.

@jimmytyyang jimmytyyang merged commit 461ed57 into main Nov 11, 2023
1 of 3 checks passed
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* tyde CI

* getting a corrcet init location of arm

* tidy CI

* sensor clean up so that the size is the same

* setup social nav reward and yaml

* bounding box update

* clean up human bbox detector

* tidy

* tidy

* add stereo pari camera

* make the size of HumanoidDetectorSensor consistent with the senser obs

* fix nan issue

* fix init_distributed issue

* tidy

* tidy CI and add comments

* add more comments

* tidy CI

* add InitialGpsCompassSensor sensor

* refine social nav reward

* add exploration reward

* increase the video size

* polsih the PR

* tidy

* reduce the third_rgb_sensor size

---------

Co-authored-by: Jimmy Yang <[email protected]>
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
* tyde CI

* getting a corrcet init location of arm

* tidy CI

* sensor clean up so that the size is the same

* setup social nav reward and yaml

* bounding box update

* clean up human bbox detector

* tidy

* tidy

* add stereo pari camera

* make the size of HumanoidDetectorSensor consistent with the senser obs

* fix nan issue

* fix init_distributed issue

* tidy

* tidy CI and add comments

* add more comments

* tidy CI

* add InitialGpsCompassSensor sensor

* refine social nav reward

* add exploration reward

* increase the video size

* polsih the PR

* tidy

* reduce the third_rgb_sensor size

---------

Co-authored-by: Jimmy Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants