-
Notifications
You must be signed in to change notification settings - Fork 4.3k
int8 support for cuVS cagra
#4439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+235
−43
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
36aecf8
int8 support
jinsolp edcc9cf
merge commit
jinsolp 3fb1799
merge commit
jinsolp e8a784f
Merge branch 'main' into cuvs-cagra-int8-pub
jinsolp df8c72d
Merge branch 'main' into cuvs-cagra-int8-pub
jinsolp 1df161c
Merge branch 'main' into cuvs-cagra-int8-pub
mnorris11 61341a3
Merge branch 'main' into cuvs-cagra-int8-pub
jinsolp a4e1995
Merge branch 'main' into cuvs-cagra-int8-pub
mnorris11 2f577ae
apply appropriate encode/decode
jinsolp 9dbe9ad
Merge branch 'main' into cuvs-cagra-int8-pub
jinsolp b0ebffc
Merge branch 'main' into cuvs-cagra-int8-pub
jinsolp 85aeb37
Merge branch 'main' into cuvs-cagra-int8-pub
jinsolp a58872e
proper merge conflict solve
jinsolp 306a351
Merge branch 'main' into cuvs-cagra-int8-pub
mnorris11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my learning, what happens in the 16 and int8 case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for
copyTowhere we copy fromGpuIndexCagratoIndexHNSWCagra.If
base_level_only=false, we end up callinghnsw_add_vertices, which only support fp32 computations on CPU, so we need it to be true.When
base_level_only=true, we can use thestorage(which isIndexScalarQuantizer)'sadd()instead. : )