Closed
Conversation
Contributor
|
@ramilbakhshyiev has imported this pull request. If you are a Meta employee, you can view this in D77827581. |
Contributor
|
@ramilbakhshyiev merged this pull request in ee9d18a. |
dian-lun-lin
pushed a commit
to ahuber21/faiss
that referenced
this pull request
Jul 30, 2025
Summary: This restores the ability to compile with mingw introduced in facebookresearch#4145. I am not sure why msvc does allow this, but using the `_FMT` macro without any `vaargs` causes a trailing comma in the arguments list. which is not allowed in c++. This switches it over to the `_MSG` macro instead avoiding this issue. Pull Request resolved: facebookresearch#4420 Reviewed By: pankajsingh88 Differential Revision: D77827581 Pulled By: ramilbakhshyiev fbshipit-source-id: f63564546511e88084dbacc71458448d3c403de9
samanthawaters8882michaeldonovan
added a commit
to samanthawaters8882michaeldonovan/faiss
that referenced
this pull request
Oct 12, 2025
Summary: This restores the ability to compile with mingw introduced in facebookresearch/faiss#4145. I am not sure why msvc does allow this, but using the `_FMT` macro without any `vaargs` causes a trailing comma in the arguments list. which is not allowed in c++. This switches it over to the `_MSG` macro instead avoiding this issue. Pull Request resolved: facebookresearch/faiss#4420 Reviewed By: pankajsingh88 Differential Revision: D77827581 Pulled By: ramilbakhshyiev fbshipit-source-id: f63564546511e88084dbacc71458448d3c403de9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the ability to compile with mingw introduced in #4145. I am not sure why msvc does allow this, but using the
_FMTmacro without anyvaargscauses a trailing comma in the arguments list. which is not allowed in c++. This switches it over to the_MSGmacro instead avoiding this issue.