moved IndexIVFPQ and IndexPQ to dynamic dispatch#4291
Closed
mdouze wants to merge 4 commits intofacebookresearch:mainfrom
Closed
moved IndexIVFPQ and IndexPQ to dynamic dispatch#4291mdouze wants to merge 4 commits intofacebookresearch:mainfrom
mdouze wants to merge 4 commits intofacebookresearch:mainfrom
Conversation
Differential Revision: D72937710
Differential Revision: D72937708
Differential Revision: D72937711
Summary: moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular, this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72937709 |
Contributor
Author
|
This export is not functional. It is mainly for external visibility, on how dynamic dispatching will work. |
Contributor
Author
|
The dynamic dispatching requires:
|
| #ifdef __x86_64__ | ||
| { | ||
| unsigned int eax, ebx, ecx, edx; | ||
| asm volatile("cpuid" |
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Sounds good! How portable is the cpuid.h header?
Contributor
Author
There was a problem hiding this comment.
So you would recommend to make all the distance functions pointers ?
That's also a possibility but wondering about the performance impact...
mdouze
added a commit
to mdouze/faiss
that referenced
this pull request
Apr 24, 2025
Summary: Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
mdouze
added a commit
to mdouze/faiss
that referenced
this pull request
May 5, 2025
Summary: Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
mdouze
added a commit
to mdouze/faiss
that referenced
this pull request
May 6, 2025
Summary: Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
algoriddle
pushed a commit
to algoriddle/faiss
that referenced
this pull request
May 7, 2025
Summary: Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
mdouze
added a commit
to mdouze/faiss
that referenced
this pull request
Jun 4, 2025
Summary: Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Pull Request resolved: facebookresearch#4555 Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Pull Request resolved: facebookresearch#4555 Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Pull Request resolved: facebookresearch#4555 Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Pull Request resolved: facebookresearch#4555 Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 26, 2025
Summary: Pull Request resolved: facebookresearch#4555 Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 27, 2025
Summary: Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 27, 2025
Summary: Pull Request resolved: facebookresearch#4555 Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Reviewed By: mnorris11 Differential Revision: D72937709
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 28, 2025
Summary: Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Aug 28, 2025
Summary: Pull Request resolved: facebookresearch#4555 Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Reviewed By: mnorris11 Differential Revision: D72937709
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Sep 9, 2025
Summary: Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Jan 21, 2026
Summary: Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Jan 23, 2026
Summary: Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Differential Revision: D72937709
subhadeepkaran
pushed a commit
to subhadeepkaran/faiss
that referenced
this pull request
Jan 23, 2026
Summary: Pull Request resolved: facebookresearch#4555 Pull Request resolved: facebookresearch#4291 moved IndexIVFPQ and IndexPQ to dynamic dispatch. Since the code was already quite modular (thanks Alex!), this boils down to make independent cpp files for the different SIMD versions. Reviewed By: mnorris11 Differential Revision: D72937709
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
moved IndexIVFPQ and IndexPQ to dynamic dispatch.
Since the code was already quite modular, this boils down to make independent cpp files for the different SIMD versions.
Differential Revision: D72937709