Skip to content

Fix bug with metric_arg in IndexHNSW #4239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rohildshah wants to merge 4 commits into from
Closed

Fix bug with metric_arg in IndexHNSW #4239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a1dd4e
add hnsw+metricLp test and metric_arg fix
rohildshah Mar 14, 2025
f28224a
fix formatting
rohildshah Mar 14, 2025
00dcd2d
Update IndexHNSW metric_arg initialization location
rohildshah Mar 18, 2025
bb422c0
Merge branch 'main' into hnsw_metricLp
rohildshah Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion faiss/IndexHNSW.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,9 @@ IndexHNSW::IndexHNSW(int d, int M, MetricType metric)
: Index(d, metric), hnsw(M) {}

IndexHNSW::IndexHNSW(Index* storage, int M)
: Index(storage->d, storage->metric_type), hnsw(M), storage(storage) {}
: Index(storage->d, storage->metric_type), hnsw(M), storage(storage) {
metric_arg = storage->metric_arg;
}

IndexHNSW::~IndexHNSW() {
if (own_fields) {
Expand Down
21 changes: 21 additions & 0 deletions tests/test_hnsw.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,27 @@ TEST(HNSW, Test_popmin_infinite_distances) {
}
}

TEST(HNSW, Test_IndexHNSW_METRIC_Lp) {
// Create an HNSW index with METRIC_Lp and metric_arg = 3
faiss::IndexFlat storage_index(1, faiss::METRIC_Lp);
storage_index.metric_arg = 3;
faiss::IndexHNSW index(&storage_index, 32);

// Add a single data point
float data[1] = {0.0};
index.add(1, data);

// Prepare a query
float query[1] = {2.0};
float distance;
faiss::idx_t label;

index.search(1, query, 1, &distance, &label);

EXPECT_NEAR(distance, 8.0, 1e-5); // Distance should be 8.0 (2^3)
EXPECT_EQ(label, 0); // Label should be 0
}

class HNSWTest : public testing::Test {
protected:
HNSWTest() {
Expand Down
Loading