Add more unit testing for IndexHNSW [2/n]

faiss/IndexHNSW.cpp

@@ -351,6 +351,17 @@ void IndexHNSW::reconstruct(idx_t key, float* recons) const {
     storage->reconstruct(key, recons);
 }
 
+/**************************************************************
+ * This section of functions were used during the development of HNSW support.
+ * They may be useful in the future but are dormant for now, and thus are not
+ * unit tested at the moment.
+ * shrink_level_0_neighbors
+ * search_level_0
+ * init_level_0_from_knngraph
+ * init_level_0_from_entry_points
+ * reorder_links
+ * link_singletons
+ **************************************************************/
 void IndexHNSW::shrink_level_0_neighbors(int new_size) {
 #pragma omp parallel
     {

tests/test_graph_based.py

@@ -73,6 +73,20 @@ def test_hnsw_unbounded_queue(self):
 
         self.io_and_retest(index, Dhnsw, Ihnsw)
 
+    def test_hnsw_no_init_level0(self):
+        d = self.xq.shape[1]
+
+        index = faiss.IndexHNSWFlat(d, 16)
+        index.init_level0 = False
+        index.add(self.xb)
+        Dhnsw, Ihnsw = index.search(self.xq, 1)
+
+        # This is expected to be smaller because we are not initializing
+        # vectors into level 0.
+        self.assertGreaterEqual((self.Iref == Ihnsw).sum(), 25)
+
+        self.io_and_retest(index, Dhnsw, Ihnsw)
+
     def io_and_retest(self, index, Dhnsw, Ihnsw):
         index2 = faiss.deserialize_index(faiss.serialize_index(index))
         Dhnsw2, Ihnsw2 = index2.search(self.xq, 1)
@@ -101,6 +115,24 @@ def test_hnsw_2level(self):
 
         self.io_and_retest(index, Dhnsw, Ihnsw)
 
+    def test_hnsw_2level_mixed_search(self):
+        d = self.xq.shape[1]
+
+        quant = faiss.IndexFlatL2(d)
+
+        storage = faiss.IndexIVFPQ(quant, d, 32, 8, 8)
+        storage.make_direct_map()
+        index = faiss.IndexHNSW2Level(quant, 32, 8, 8)
+        index.storage = storage
+        index.train(self.xb)
+        index.add(self.xb)
+        Dhnsw, Ihnsw = index.search(self.xq, 1)
+
+        # It is expected that the mixed search will perform worse.
+        self.assertGreaterEqual((self.Iref == Ihnsw).sum(), 200)
+
+        self.io_and_retest(index, Dhnsw, Ihnsw)
+
     def test_add_0_vecs(self):
         index = faiss.IndexHNSWFlat(10, 16)
         zero_vecs = np.zeros((0, 10), dtype='float32')
@@ -175,16 +207,31 @@ def test_abs_inner_product(self):
         xb = self.xb - self.xb.mean(axis=0)  # need to be centered to give interesting directions
         xq = self.xq - self.xq.mean(axis=0)
         Dref, Iref = faiss.knn(xq, xb, 10, faiss.METRIC_ABS_INNER_PRODUCT)
-        
+
         index = faiss.IndexHNSWFlat(d, 32, faiss.METRIC_ABS_INNER_PRODUCT)
         index.add(xb)
         Dnew, Inew = index.search(xq, 10)
 
         inter = faiss.eval_intersection(Iref, Inew)
         # 4769 vs. 500*10
         self.assertGreater(inter, Iref.size * 0.9)
-
-
+
+    def test_hnsw_reset(self):
+        d = self.xb.shape[1]
+        index_flat = faiss.IndexFlat(d)
+        index_flat.add(self.xb)
+        self.assertEqual(index_flat.ntotal, self.xb.shape[0])
+        index_hnsw = faiss.IndexHNSW(index_flat)
+        index_hnsw.add(self.xb)
+        # * 2 because we add to storage twice. This is just for testing
+        # that storage gets cleared correctly.
+        self.assertEqual(index_hnsw.ntotal, self.xb.shape[0] * 2)
+
+        index_hnsw.reset()
+
+        self.assertEqual(index_flat.ntotal, 0)
+        self.assertEqual(index_hnsw.ntotal, 0)
+
 class Issue3684(unittest.TestCase):
 
     def test_issue3684(self):