add test for external modules#3699
Closed
mdouze wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60379753 |
mdouze
added a commit
to mdouze/faiss
that referenced
this pull request
Jul 29, 2024
Summary: External modules should work fine as plug-ins to Faiss in the following cases: * additional objects that can be passed in as callbacks to Faiss * functions that use `faiss.swig_ptr` to pass in arrays. The `swig_ptr` functionality does not always work well (also depending on the platform). Therefore this diff adds a small external swig file to test that everything works smoothly on that end. Differential Revision: D60379753
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60379753 |
mdouze
force-pushed
the
export-D60379753
branch
from
06e9c92 to
a22f5bd
Compare
mdouze
added a commit
to mdouze/faiss
that referenced
this pull request
Aug 30, 2024
Summary: Pull Request resolved: facebookresearch#3699 External modules should work fine as plug-ins to Faiss in the following cases: * additional objects that can be passed in as callbacks to Faiss * functions that use `faiss.swig_ptr` to pass in arrays. The `swig_ptr` functionality does not always work well (also depending on the platform). Therefore this diff adds a small external swig file to test that everything works smoothly on that end. Differential Revision: D60379753
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60379753 |
Closed
mdouze
force-pushed
the
export-D60379753
branch
from
a22f5bd to
f1c75ae
Compare
mdouze
added a commit
to mdouze/faiss
that referenced
this pull request
Oct 1, 2024
Summary: External modules should work fine as plug-ins to Faiss in the following cases: * additional objects that can be passed in as callbacks to Faiss * functions that use `faiss.swig_ptr` to pass in arrays. The `swig_ptr` functionality does not always work well (also depending on the platform). Therefore this diff adds a small external swig file to test that everything works smoothly on that end. Differential Revision: D60379753
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60379753 |
mdouze
added a commit
to mdouze/faiss
that referenced
this pull request
Oct 1, 2024
Summary: Pull Request resolved: facebookresearch#3699 External modules should work fine as plug-ins to Faiss in the following cases: * additional objects that can be passed in as callbacks to Faiss * functions that use `faiss.swig_ptr` to pass in arrays. The `swig_ptr` functionality does not always work well (also depending on the platform). Therefore this diff adds a small external swig file to test that everything works smoothly on that end. Differential Revision: D60379753
mdouze
force-pushed
the
export-D60379753
branch
from
f1c75ae to
1395995
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60379753 |
Summary: Pull Request resolved: facebookresearch#3699 External modules should work fine as plug-ins to Faiss in the following cases: * additional objects that can be passed in as callbacks to Faiss * functions that use `faiss.swig_ptr` to pass in arrays. The `swig_ptr` functionality does not always work well (also depending on the platform). Therefore this diff adds a small external swig file to test that everything works smoothly on that end. Differential Revision: D60379753
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60379753 |
mdouze
force-pushed
the
export-D60379753
branch
from
1395995 to
be54c30
Compare
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Oct 7, 2024
Summary: We need to be able to build external modules into FAISS, but don't have an example yet. This diff shows what CMakeLists.txt changes need to happen to incorporate an external module. Reference: facebookresearch#3699 Differential Revision: D63991471
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Oct 7, 2024
…acebookresearch#3922) Summary: We need to be able to build external modules into FAISS, but don't have an example yet. This diff shows what CMakeLists.txt changes need to happen to incorporate an external module. Reference: facebookresearch#3699 Differential Revision: D63991471
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Oct 7, 2024
…acebookresearch#3922) Summary: We need to be able to build external modules into FAISS, but don't have an example yet. This diff shows what CMakeLists.txt changes need to happen to incorporate an external module. Reference: facebookresearch#3699 Differential Revision: D63991471
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Oct 8, 2024
…acebookresearch#3922) Summary: We need to be able to build external modules into FAISS, but don't have an example yet. This diff shows what CMakeLists.txt changes need to happen to incorporate an external module. Reference: facebookresearch#3699 Differential Revision: D63991471
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Oct 8, 2024
…acebookresearch#3922) Summary: We need to be able to build external modules into FAISS, but don't have an example yet. This diff shows what CMakeLists.txt changes need to happen to incorporate an external module. Reference: facebookresearch#3699 Differential Revision: D63991471
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Oct 8, 2024
…acebookresearch#3922) Summary: We need to be able to build external modules into FAISS, but don't have an example yet. This diff shows what CMakeLists.txt changes need to happen to incorporate an external module. Reference: facebookresearch#3699 Differential Revision: D63991471
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Oct 10, 2024
…acebookresearch#3922) Summary: We need to be able to build external modules into FAISS, but don't have an example yet. This diff shows what CMakeLists.txt changes need to happen to incorporate an external module. Reference: facebookresearch#3699 Differential Revision: D63991471
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
Oct 10, 2024
…acebookresearch#3922) Summary: We need to be able to build external modules into FAISS, but don't have an example yet. This diff shows what CMakeLists.txt changes need to happen to incorporate an external module. Reference: facebookresearch#3699 Differential Revision: D63991471
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 11, 2024
…3922) Summary: Pull Request resolved: #3922 We need to be able to build external modules into FAISS, but don't have an example yet. This diff shows what CMakeLists.txt changes need to happen to incorporate an external module. Reference: #3699 Reviewed By: mdouze Differential Revision: D63991471 fbshipit-source-id: 0c1cd25eabbffb01d2a7170d6725a0c4a13c5bf0
samanthawaters8882michaeldonovan
added a commit
to samanthawaters8882michaeldonovan/faiss
that referenced
this pull request
Oct 12, 2025
…#3922) Summary: Pull Request resolved: facebookresearch/faiss#3922 We need to be able to build external modules into FAISS, but don't have an example yet. This diff shows what CMakeLists.txt changes need to happen to incorporate an external module. Reference: facebookresearch/faiss#3699 Reviewed By: mdouze Differential Revision: D63991471 fbshipit-source-id: 0c1cd25eabbffb01d2a7170d6725a0c4a13c5bf0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
External modules should work fine as plug-ins to Faiss in the following cases:
additional objects that can be passed in as callbacks to Faiss
functions that use
faiss.swig_ptrto pass in arrays.The
swig_ptrfunctionality does not always work well (also depending on the platform). Therefore this diff adds a small external swig file to test that everything works smoothly on that end.Differential Revision: D60379753