Skip to content

Non-Blocking AVX512 Build on self-hosted github runner #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mengdilin wants to merge 3 commits into from
Closed

Non-Blocking AVX512 Build on self-hosted github runner #3602

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04f0912
Build AVX512 on custom github runner
Jul 1, 2024
4a017cb
gate avx-512 behind the plain vanilla build
Jul 1, 2024
08e012a
add continue-on-error for all steps
Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,17 @@ jobs:
opt_level: avx2
linux-x86_64-AVX512-cmake:
name: Linux x86_64 AVX512 (cmake)
if: false # TODO: enable when GitHub Actions adds AVX-512 hosts
continue-on-error: true # non-blocking mode for now
needs: linux-x86_64-cmake
runs-on: ubuntu-latest
runs-on: faiss-aws-m7i.xlarge
steps:
- name: Checkout
continue-on-error: true # non-blocking mode for now
Copy link
Contributor

@ramilbakhshyiev ramilbakhshyiev Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this line here?

Copy link
Contributor Author

@mengdilin mengdilin Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I observed a difference in UI behaviors for continue-on-error when set on a job vs on a step: setting it on a job means the action is successful but people will still see the red check mark on the github PR page. I wanted the red check mark to go away to avoid confusion and that means we also need continue-on-error set on the step level. There has been a discussion about this behavior in: https://github.com/orgs/community/discussions/15452

Copy link
Contributor

@ramilbakhshyiev ramilbakhshyiev Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. So it's different when it's set at job level and the step level. Do we need to set it on the build_cmake as well then?

Copy link
Contributor Author

@mengdilin mengdilin Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice catch!

uses: actions/checkout@v4
- uses: ./.github/actions/build_cmake
with:
opt_level: avx512
continue-on-error: true # non-blocking mode for now
linux-x86_64-GPU-cmake:
name: Linux x86_64 GPU (cmake)
needs: linux-x86_64-cmake
Expand Down