Skip to content

Fix missing overload variable in Rocksdb ivf demo #3326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Warmchay wants to merge 5 commits into from
Closed

Fix missing overload variable in Rocksdb ivf demo #3326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da3d9c8
Fix missing overload variable in Rocksdb ivf demo
Warmchay Mar 28, 2024
875c96d
Formatting the code style
Warmchay Mar 28, 2024
b08ffad
Merge branch 'facebookresearch:main' into rocksdb-ivf-iterator-overload
Warmchay Mar 29, 2024
00cfe7d
Fix typo contex to context
Warmchay Mar 29, 2024
ce1e61f
Formatting the code style
Warmchay Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion demos/rocksdb_ivf/RocksDBInvertedLists.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ void RocksDBInvertedLists::resize(size_t /*list_no*/, size_t /*new_size*/) {
}

InvertedListsIterator* RocksDBInvertedLists::get_iterator(
size_t list_no) const {
size_t list_no,
void* inverted_list_context) const {
return new RocksDBInvertedListsIterator(db_.get(), list_no, code_size);
}

Expand Down
4 changes: 3 additions & 1 deletion demos/rocksdb_ivf/RocksDBInvertedLists.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ struct RocksDBInvertedLists : faiss::InvertedLists {

void resize(size_t list_no, size_t new_size) override;

faiss::InvertedListsIterator* get_iterator(size_t list_no) const override;
faiss::InvertedListsIterator* get_iterator(
size_t list_no,
void* inverted_list_context) const override;

private:
std::unique_ptr<rocksdb::DB> db_;
Expand Down