Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2882 added a for loop, which has unsigned index, qualified with
#pragma omp parallel for
, but it seems that MSVC doesn't support unsigned index with#pragma omp parallel for
(I think this would not be conformed to OpenMP specification, but...)I (finally) change the loop with signed index. This changes introduce the precondition
n <= std::numeric_limits<std::make_signed_t<std::size_t>>::max()
, but usually this istrue
I think, so I just put this limitation as a comment instead of anyFAISS_ASSERT
or something like that.