[dx] add .gitignore to exclude compil artifacts and local files#2
Merged
[dx] add .gitignore to exclude compil artifacts and local files#2
Conversation
Contributor
|
Looks useful, thanks! |
This was referenced May 9, 2018
1 task
wxyucs
pushed a commit
to wxyucs/faiss
that referenced
this pull request
Sep 9, 2020
# This is the 1st commit message: save # This is the commit message facebookresearch#2: rm docs
Closed
algoriddle
added a commit
to algoriddle/faiss
that referenced
this pull request
May 9, 2023
mqnfred
pushed a commit
to mqnfred/faiss
that referenced
this pull request
Oct 23, 2023
Adding remove_ids method to Index trait
kuarora
added a commit
to kuarora/faiss
that referenced
this pull request
Mar 28, 2024
…Lists Summary: **Context** 1. [Issue 2621](facebookresearch#2621) discuss inconsistency between OnDiskInvertedList and InvertedList. OnDiskInvertedList is supposed to handle disk based multiple Index Shards. Thus, we should name it differently when merging invls from index shard. 2. [Issue 2876](facebookresearch#2876) provides usecase of shifting ids when merging invls from different shards. **In this diff**, 1. To address facebookresearch#1 above, I renamed the merge_from function to merge_from_multiple without touching merge_from base class. why so? To continue to allow merge invl from one index to ondiskinvl from other index. 2. To address facebookresearch#2 above, I have added support of shift_ids in merge_from_multiple to shift ids from different shards. This can be used when each shard has same set of ids but different data. This is not recommended if id is already unique across shards. Differential Revision: D55482518
kuarora
added a commit
to kuarora/faiss
that referenced
this pull request
Mar 28, 2024
…Lists (facebookresearch#3327) Summary: **Context** 1. [Issue 2621](facebookresearch#2621) discuss inconsistency between OnDiskInvertedList and InvertedList. OnDiskInvertedList is supposed to handle disk based multiple Index Shards. Thus, we should name it differently when merging invls from index shard. 2. [Issue 2876](facebookresearch#2876) provides usecase of shifting ids when merging invls from different shards. **In this diff**, 1. To address facebookresearch#1 above, I renamed the merge_from function to merge_from_multiple without touching merge_from base class. why so? To continue to allow merge invl from one index to ondiskinvl from other index. 2. To address facebookresearch#2 above, I have added support of shift_ids in merge_from_multiple to shift ids from different shards. This can be used when each shard has same set of ids but different data. This is not recommended if id is already unique across shards. Differential Revision: D55482518
kuarora
added a commit
to kuarora/faiss
that referenced
this pull request
Apr 3, 2024
…Lists (facebookresearch#3327) Summary: **Context** 1. [Issue 2621](facebookresearch#2621) discuss inconsistency between OnDiskInvertedList and InvertedList. OnDiskInvertedList is supposed to handle disk based multiple Index Shards. Thus, we should name it differently when merging invls from index shard. 2. [Issue 2876](facebookresearch#2876) provides usecase of shifting ids when merging invls from different shards. **In this diff**, 1. To address facebookresearch#1 above, I renamed the merge_from function to merge_from_multiple without touching merge_from base class. why so? To continue to allow merge invl from one index to ondiskinvl from other index. 2. To address facebookresearch#2 above, I have added support of shift_ids in merge_from_multiple to shift ids from different shards. This can be used when each shard has same set of ids but different data. This is not recommended if id is already unique across shards. Reviewed By: mdouze Differential Revision: D55482518
kuarora
added a commit
to kuarora/faiss
that referenced
this pull request
Apr 3, 2024
…Lists (facebookresearch#3327) Summary: **Context** 1. [Issue 2621](facebookresearch#2621) discuss inconsistency between OnDiskInvertedList and InvertedList. OnDiskInvertedList is supposed to handle disk based multiple Index Shards. Thus, we should name it differently when merging invls from index shard. 2. [Issue 2876](facebookresearch#2876) provides usecase of shifting ids when merging invls from different shards. **In this diff**, 1. To address facebookresearch#1 above, I renamed the merge_from function to merge_from_multiple without touching merge_from base class. why so? To continue to allow merge invl from one index to ondiskinvl from other index. 2. To address facebookresearch#2 above, I have added support of shift_ids in merge_from_multiple to shift ids from different shards. This can be used when each shard has same set of ids but different data. This is not recommended if id is already unique across shards. Reviewed By: mdouze Differential Revision: D55482518
kuarora
added a commit
to kuarora/faiss
that referenced
this pull request
Apr 3, 2024
…Lists (facebookresearch#3327) Summary: **Context** 1. [Issue 2621](facebookresearch#2621) discuss inconsistency between OnDiskInvertedList and InvertedList. OnDiskInvertedList is supposed to handle disk based multiple Index Shards. Thus, we should name it differently when merging invls from index shard. 2. [Issue 2876](facebookresearch#2876) provides usecase of shifting ids when merging invls from different shards. **In this diff**, 1. To address facebookresearch#1 above, I renamed the merge_from function to merge_from_multiple without touching merge_from base class. why so? To continue to allow merge invl from one index to ondiskinvl from other index. 2. To address facebookresearch#2 above, I have added support of shift_ids in merge_from_multiple to shift ids from different shards. This can be used when each shard has same set of ids but different data. This is not recommended if id is already unique across shards. Reviewed By: mdouze Differential Revision: D55482518
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
…Lists (#3327) Summary: Pull Request resolved: #3327 **Context** 1. [Issue 2621](#2621) discuss inconsistency between OnDiskInvertedList and InvertedList. OnDiskInvertedList is supposed to handle disk based multiple Index Shards. Thus, we should name it differently when merging invls from index shard. 2. [Issue 2876](#2876) provides usecase of shifting ids when merging invls from different shards. **In this diff**, 1. To address #1 above, I renamed the merge_from function to merge_from_multiple without touching merge_from base class. why so? To continue to allow merge invl from one index to ondiskinvl from other index. 2. To address #2 above, I have added support of shift_ids in merge_from_multiple to shift ids from different shards. This can be used when each shard has same set of ids but different data. This is not recommended if id is already unique across shards. Reviewed By: mdouze Differential Revision: D55482518 fbshipit-source-id: 95470c7449160488d2b45b024d134cbc037a2083
ItsPitt
added a commit
to ItsPitt/faiss
that referenced
this pull request
Aug 9, 2024
Fix load/store.
metonymic-smokey
pushed a commit
to metonymic-smokey/faiss
that referenced
this pull request
Jul 30, 2025
* index io operations on char* buffer * bug fix: fill the index content to an unsigned char buf * changes with respect to read API for index io * Move read/write APIs from/to buffer to separate file --------- Co-authored-by: Thejas-bhat <thejas.orkombu@couchbase.com>
metonymic-smokey
pushed a commit
to metonymic-smokey/faiss
that referenced
this pull request
Jul 30, 2025
…iss@bleve` (facebookresearch#52) Merge results: ``` |\ * ca874b6 Abhinav Dangeti | Fix type mismatches within unit test: TEST(TestHamming, test_hamming_knn) * e255b9b Abhinav Dangeti | Adapt signature change of `get_InvertedListScanner` in faiss/IndexIVFPQ.cpp * 90fe29b Abhinav Dangeti | Remove redundant cmake install over target `faiss_c` * 0882dd3 Abhi Dangeti | Merge branch 'bleve' into main_1.11.0 |\ | * 0be294a Deepkaran Salooja | Implement compute_distance_to_codes_for_list and compute_distance_table for IndexIVFPQ (facebookresearch#50) | * 352484e Rahul Rampure | MB-65473: Batch converter for vector to cluster IDs (facebookresearch#49) | * 14a4a60 Rahul Rampure | MB-65473: Refactor and Optimize Pre-Filtered Vector Search (facebookresearch#48) | * b4cc942 Abhi Dangeti | MB-65243: Merge 'facebookresearch/faiss@v1.10.0' into 'blevesearch/faiss@bleve' (facebookresearch#46) | |\ | | * 8d33b5c Abhinav Dangeti | MB-65243: Merge 'facebookresearch/faiss@v1.10.0' into 'blevesearch/faiss@bleve' | |/| | * | 8eecdb6 Rahul Rampure | MB-63643: Fix missing num_threads clauses (facebookresearch#44) | * | 224acef Deepkaran Salooja | MB-61093 Fix memory leak for SQDistanceComputer (facebookresearch#43) | * | 3001b51 Deepkaran Salooja | MB-61093 Add method to compute distance from codes for IVF index (facebookresearch#41) | * | b747c55 Aditi Ahuja | MB-62230 - Updated closest_centroids API to include params (facebookresearch#38) | * | 26d9b35 Aditi Ahuja | MB-62230 - Extended c_api to search only specified clusters with params. (facebookresearch#35) | * | f077bf9 Abhi Dangeti | Build libfaiss with AVX2 support when requested, rather than libfaiss (facebookresearch#37) | * | 5ab1ce0 Abhi Dangeti | MB-62577: Merge 'facebookresearch/faiss@v1.8.0' into blevesearch/faiss@bleve | |\ \ | | * | 3306e58 Abhinav Dangeti | MB-62577: Merge 'facebookresearch/faiss@v1.8.0' into blevesearch/faiss@bleve | |/| | | * | | d9db66a Rahul Rampure | MB-62221: API to free a buffer allocated in C runtime (facebookresearch#30) | * | | a2f4183 Rahul Rampure | MB-62221: Fix buffer overflow (facebookresearch#29) | * | | 7977457 Rahul Rampure | MB-61930: Add a num_threads clause to every openMP pragma. (facebookresearch#25) | * | | a30eaa2 Rahul Rampure | MB-61930: Optimize Thread Management in High Throughput Scenarios (facebookresearch#24) | * | | 2ce3883 Thejas-bhat | MB-59575: Revert memcpy optimizations for flat indexes (facebookresearch#23) | * | | 7c3c7d1 Thejas-bhat | MB-59575: Refactor member variables alignment of IndexFlatCodes (facebookresearch#22) | * | | 17c3992 Thejas-bhat | MB-59575: Reducing copy overhead of already memory mapped content (facebookresearch#17) | * | | 38f6b60 Chris Hillery | Fix build on Windows (facebookresearch#21) | * | | 4143984 SaptarshiSen-CB | MB-61609: Fix zero sa_code_size (facebookresearch#19) | * | | 7b119f4 Rahul Rampure | MB-60739: Fix integer overflow (facebookresearch#15) | * | | 6851683 Rahul Rampure | MB-60657: Fix integer overflow (facebookresearch#14) | * | | 8672bf3 Thejas-bhat | Size API to get the index's size (facebookresearch#13) | * | | b34ccf6 Aditi Ahuja | MB-60202 - IDMap2 Selector (facebookresearch#12) | * | | a623ec6 Thejas-bhat | Introducing a new reader to read index using a pointer (facebookresearch#8) | * | | 4dd26f8 Chris Hillery | Add INSTALL() directive for faiss_c (facebookresearch#7) | * | | 14fd16a Chris Hillery | Suppress (thousands of) warnings when building with GCC (facebookresearch#6) | * | | 44febf0 Abhi Dangeti | Address incorrect import within c_api/IndexIVF_c_ex.cpp (facebookresearch#5) | * | | 1b295e4 Abhi Dangeti | Add build instructions for IndexIVF_c_ex.cpp and Index_c_ex.cpp (facebookresearch#4) | * | | 334021a Abhi Dangeti | additional index APIs (facebookresearch#3) | * | | f0bbc06 Abhi Dangeti | Introducing index IO operations over char buffer (facebookresearch#2) * | | | ea1cdf0 Michael Norris | Increment next release, v1.11.0 (facebookresearch#4308) * | | | 70c4537 simshi | fix: algorithm of spreading vectors over shards (facebookresearch#4299) * | | | d4fa401 Michael Norris | Add RaBitQ to the swigfaiss so we can access its properties correctly in python (facebookresearch#4304) * | | | c75f166 Satyendra Mishra | Add date and time to the codec file path so that the file doesn't get overridden with each run (facebookresearch#4303) * | | | a3cd63f Aditya Vidyadhar Kamath | Skip mmap test case in AIX. (facebookresearch#4275) * | | | e36897f Michael Norris | Fix overflow of int32 in IndexNSG (facebookresearch#4297) * | | | 117aafd Michael Simpson | Fix Type Error in Conditional Logic (facebookresearch#4294) * | | | 928333c Jim Meyering | faiss/gpu/GpuAutoTune.cpp: fix llvm-19-exposed -Wunused-but-set-variable warnings * | | | bb04bf6 Bhavik Sheth | Add missing header in faiss/CMakeLists.txt (facebookresearch#4285) * | | | d9cfd00 Satyendra Mishra | Implement is_spherical and normalize_L2 booleans as part of the training APIs (facebookresearch#4279) * | | | 915f719 Michael Norris | Fix nightly by pinning conda-build to prevent regression in 25.3.2 (facebookresearch#4287) * | | | de5e85e generatedunixname89002005287564 | Fix CQS signal. Id] 88153895 -- readability-redundant-string-init in fbcode/faiss (facebookresearch#4283) * | | | 7eac034 Satyendra Mishra | Add normalize_l2 boolean to distributed training API * | | | 0dfb599 Jaap Aarts | Handle insufficient driver gracefully (facebookresearch#4271) * | | | d4e236b Alexandr Guzhva | relax input params for IndexIVFRaBitQ::get_InvertedListScanner() (facebookresearch#4270) * | | | df9e2c4 Alexandr Guzhva | Fix a placeholder for 'unimplemented' in mapped_io.cpp (facebookresearch#4268) * | | | 0d3aff9 wwq | fix bug: IVFPQ of raft/cuvs does not require redundant check (facebookresearch#4241) * | | | a4401c1 Kaival Parikh | Allow using custom index readers and writers (facebookresearch#4180) * | | | 636d95e Tarang Jain | Upgrade to libcuvs=25.04 (facebookresearch#4164) * | | | 7f523f0 Junjie Qi | ignore regex (facebookresearch#4264) * | | | ccc2b33 Alexandr Guzhva | fix a serialization problem in RaBitQ (facebookresearch#4261) * | | | 13255a8 Kaival Parikh | Publish the C API to Conda (facebookresearch#4186) * | | | 3a49130 Alexandr Guzhva | RaBitQ implementation (facebookresearch#4235) * | | | c2fc549 Satyendra Mishra | Pass row filters to Hive Reader to filter rows (facebookresearch#4256) * | | | 6116d36 Mayank Bhatia | Grammar fix in FlatIndexHNSW (facebookresearch#4253) * | | | 1debb7d Matthijs Douze | re-land mmap diff (facebookresearch#4250) * | | | 0f2035c Richard Barnes | Fix CUDA kernel index data type in faiss/gpu/impl/DistanceUtils.cuh +10 (facebookresearch#4246) * | | | 1dcbb4a Alexandr Guzhva | fix `IVFPQFastScan::RangeSearch()` on the `ARM` architecture (facebookresearch#4247) * | | | 8bce244 Mengdi Lin | fix integer overflow issue when calculating imbalance_factor (facebookresearch#4245) * | | | 5adab67 Rohil Shah | Fix bug with metric_arg in IndexHNSW (facebookresearch#4239) * | | | f2f7a66 Mengdi Lin | Back out "test merge with internal repo" (facebookresearch#4244) * | | | caa5f24 Junjie Qi | test merge with internal repo (facebookresearch#4242) * | | | 9e808d4 Richard Barnes | Remove unused exception parameter from faiss/impl/ResultHandler.h (facebookresearch#4243) * | | | fec7ce9 Gustav von Zitzewitz | SearchParameters support for IndexBinaryFlat (facebookresearch#4055) * | | | df6a8f6 George Wang | Address compile errors and warnings (facebookresearch#4238) * | | | 15491a1 Saumya Agarwal | Revert D69972250: Memory-mapping and Zero-copy deserializers * | | | fbc7db2 Saumya Agarwal | Revert D69984379: mem mapping and zero-copy python fixes * | | | 631b0fd Matthijs Douze | mem mapping and zero-copy python fixes (facebookresearch#4212) * | | | 55a3c2a Alexandr Guzhva | Memory-mapping and Zero-copy deserializers (facebookresearch#4199) * | | | 653be59 Richard Barnes | Use `nullptr` in faiss/gpu/StandardGpuResources.cpp (facebookresearch#4232) * | | | 3d96ad5 Lucian Grijincu | faiss: fix non-templated hammings function (facebookresearch#4195) * | | | 4cd2f6e Junjie Qi | Support non-partition col and map in the embedding reader (facebookresearch#4229) * | | | a22ec32 Junjie Qi | Support cosine distance for training vectors (facebookresearch#4227) * | | | c109174 Richard Barnes | Fix LLVM-19 compilation issue in faiss/AutoTune.cpp (facebookresearch#4220) * | | | 615c17e Shuyao Qi | Add missing #include in code_distance-sve.h (facebookresearch#4219) * | | | eab52af Tom Jackson | Fix cloning and reverse index factory for NSG indices (facebookresearch#4151) * | | | 1a295cd George Wang | Remove python_abi to fix nightly (facebookresearch#4217) * | | | 4cea80b Shuyao Qi | Make static method in header inline (facebookresearch#4214) * | | | 835b3ea Michael Norris | Fix IVF quantizer centroid sharding so IDs are generated (facebookresearch#4197) * | | | 65222b3 Michael Norris | Pin lief to fix nightly (facebookresearch#4211) * | | | 7cb4556 lkuffo | Fix Sapphire Rapids never loading in Python bindings (facebookresearch#4209) * | | | 20c7ca3 Michael Norris | Upgrade openblas to 0.3.29 for ARM architectures (facebookresearch#4203) * | | | 55d022f George Wang | Attempt to nightly fix (facebookresearch#4204) * | | | 00ce0e2 Navneet Verma | Add the support for IndexIDMap with Cagra index (facebookresearch#4188) * | | | 1fe8b8b Nicolas De Carli | Remove unused variable (facebookresearch#4205) * | | | 6b65289 Divye Gala | Pass `store_dataset` argument along to cuVS CAGRA (facebookresearch#4173) * | | | d72d0ca Michael Norris | Fix nightly by installing earlier version of lief (facebookresearch#4198) * | | | 657c563 Bhavik Sheth | Add bounds checking to hnsw nb_neighbors (facebookresearch#4185) * | | | f0e3832 George Wang | Check for not completed * | | | aff6bfc Michael Norris | Add sharding convenience function for IVF indexes (facebookresearch#4150) * | | | 1d8f393 Kaival Parikh | Handle plain SearchParameters in HNSW searches (facebookresearch#4167) * | | | c6adc01 Michael Norris | Update INSTALL.md to remove some raft references, add missing dependency (facebookresearch#4176) * | | | 95955d8 Kota Yamaguchi | Fix install error when building avx512_spr variant (facebookresearch#4170) * | | | d720155 Amir Sadoughi | Update README.md (facebookresearch#4169) * | | | 9896beb simshi | fix: gpu tests link failure with static lib (facebookresearch#4137) * | | | 6c04699 Mulugeta Mammo | Fix the order of parameters in bench_scalar_quantizer_distance. (facebookresearch#4159) * | | | 3ec2fbd Tarang Jain | Update CAGRA docs (facebookresearch#4152) * | | | 6718dae Kaival Parikh | Expose IDSelectorBitmap in the C_API (facebookresearch#4158) * | | | 9bc4b67 Jesper Stemann Andersen | Added support for building for MinGW, in addition to MSVC (facebookresearch#4145) | |_|/ |/| | ```
scsiguy
added a commit
to scsiguy/faiss
that referenced
this pull request
Feb 19, 2026
Summary: Address input validation gaps in the load path: #: 1 FPE (divide-by-zero) Location: ProductQuantizer::set_derived_values() Root Cause: M=0 causes d % M to divide by zero Fix: Validate M > 0 in read_ProductQuantizer and set_derived_values() ──────────────────────────────────────── #: 2 OOB vector access Location: AdditiveQuantizer::set_derived_values() Root Cause: nbits.size() != M causes access to nbits[i] beyond bounds Fix: Validate nbits.size() == M in read_AdditiveQuantizer ──────────────────────────────────────── #: 3 OOB vector access Location: ResidualQuantizer old format Root Cause: Same as facebookresearch#2 but via read_ResidualQuantizer_old path Fix: Validate nbits.size() == M in read_ResidualQuantizer_old ──────────────────────────────────────── #: 4 Integer overflow Location: ProductQuantizer::set_derived_values() Root Cause: d * ksub overflows when nbits is large Fix: Use mul_no_overflow() for centroids.resize(), moved nbits > 24 check before code_size computation ──────────────────────────────────────── #: 5 FPE (divide-by-zero) + stack overflow Location: IndexLattice constructor Root Cause: nsq=0 causes d/nsq divide-by-zero; garbage nsq causes stack overflow in ZnSphereCodec Fix: Validate nsq > 0, d > 0, d % nsq == 0, r2 >= 0 before construction Files Modified Reviewed By: mdouze Differential Revision: D93486058
scsiguy
added a commit
to scsiguy/faiss
that referenced
this pull request
Feb 19, 2026
Summary: Address input validation gaps in the load path: #: 1 FPE (divide-by-zero) Location: ProductQuantizer::set_derived_values() Root Cause: M=0 causes d % M to divide by zero Fix: Validate M > 0 in read_ProductQuantizer and set_derived_values() ──────────────────────────────────────── #: 2 OOB vector access Location: AdditiveQuantizer::set_derived_values() Root Cause: nbits.size() != M causes access to nbits[i] beyond bounds Fix: Validate nbits.size() == M in read_AdditiveQuantizer ──────────────────────────────────────── #: 3 OOB vector access Location: ResidualQuantizer old format Root Cause: Same as facebookresearch#2 but via read_ResidualQuantizer_old path Fix: Validate nbits.size() == M in read_ResidualQuantizer_old ──────────────────────────────────────── #: 4 Integer overflow Location: ProductQuantizer::set_derived_values() Root Cause: d * ksub overflows when nbits is large Fix: Use mul_no_overflow() for centroids.resize(), moved nbits > 24 check before code_size computation ──────────────────────────────────────── #: 5 FPE (divide-by-zero) + stack overflow Location: IndexLattice constructor Root Cause: nsq=0 causes d/nsq divide-by-zero; garbage nsq causes stack overflow in ZnSphereCodec Fix: Validate nsq > 0, d > 0, d % nsq == 0, r2 >= 0 before construction Files Modified Reviewed By: mdouze Differential Revision: D93486058
meta-codesync bot
pushed a commit
that referenced
this pull request
Feb 20, 2026
Summary: Pull Request resolved: #4817 Address input validation gaps in the load path: #: 1 FPE (divide-by-zero) Location: ProductQuantizer::set_derived_values() Root Cause: M=0 causes d % M to divide by zero Fix: Validate M > 0 in read_ProductQuantizer and set_derived_values() ──────────────────────────────────────── #: 2 OOB vector access Location: AdditiveQuantizer::set_derived_values() Root Cause: nbits.size() != M causes access to nbits[i] beyond bounds Fix: Validate nbits.size() == M in read_AdditiveQuantizer ──────────────────────────────────────── #: 3 OOB vector access Location: ResidualQuantizer old format Root Cause: Same as #2 but via read_ResidualQuantizer_old path Fix: Validate nbits.size() == M in read_ResidualQuantizer_old ──────────────────────────────────────── #: 4 Integer overflow Location: ProductQuantizer::set_derived_values() Root Cause: d * ksub overflows when nbits is large Fix: Use mul_no_overflow() for centroids.resize(), moved nbits > 24 check before code_size computation ──────────────────────────────────────── #: 5 FPE (divide-by-zero) + stack overflow Location: IndexLattice constructor Root Cause: nsq=0 causes d/nsq divide-by-zero; garbage nsq causes stack overflow in ZnSphereCodec Fix: Validate nsq > 0, d > 0, d % nsq == 0, r2 >= 0 before construction Files Modified Reviewed By: mdouze Differential Revision: D93486058 fbshipit-source-id: e5406b844fdfd61c49ba61d8eb9f34bde7395447
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.