Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor parquet dataloader #867

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Refactor parquet dataloader #867

wants to merge 3 commits into from

Conversation

zyaoj
Copy link
Contributor

@zyaoj zyaoj commented Dec 3, 2024 •
edited
Loading

What does this PR do? Please describe:
The first attempt to extract and migrate generic parquet dataloader from MERES to fairseq2.

Does your PR introduce any breaking changes? If yes, please list them:
N/A

Check list:

  • Was the content of this PR discussed and approved via a GitHub issue? (no need for typos or documentation improvements)
  • Did you read the contributor guideline?
  • Did you make sure that your PR does only one thing instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (no need for typos, documentation, or minor internal changes)

@zyaoj zyaoj self-assigned this Dec 3, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemru artemru Awaiting requested review from artemru artemru will be requested when the pull request is marked ready for review artemru is a code owner

@cbalioglu cbalioglu Awaiting requested review from cbalioglu cbalioglu will be requested when the pull request is marked ready for review cbalioglu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@zyaoj zyaoj

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zyaoj @facebook-github-bot