Fix integration test #338
Closed
Fix integration test #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54960088 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Mar 15, 2024
Summary: X-link: facebookresearch/aepsych#338 Previously the integration test was failing due to not allowing unlimited trials on the last step. This is because the final step was copied from the exisiting botorch step (which contains transition criterion). If transition criterion exist on the step/node, we default to using those for determining the state of the node. This fixes the test by manually unsetting the transition criterion arg for the aepsych strategy.py. We also re-enable the test Reviewed By: crasanders Differential Revision: D54960088
Summary: X-link: facebook/Ax#2282 Previously the integration test was failing due to not allowing unlimited trials on the last step. This is because the final step was copied from the exisiting botorch step (which contains transition criterion). If transition criterion exist on the step/node, we default to using those for determining the state of the node. This fixes the test by manually unsetting the transition criterion arg for the aepsych strategy.py. We also re-enable the test Reviewed By: crasanders Differential Revision: D54960088
crasanders
force-pushed
the
export-D54960088
branch
from
5297c3e to
416374f
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Mar 18, 2024
Summary: X-link: facebookresearch/aepsych#338 Previously the integration test was failing due to not allowing unlimited trials on the last step. This is because the final step was copied from the exisiting botorch step (which contains transition criterion). If transition criterion exist on the step/node, we default to using those for determining the state of the node. This fixes the test by manually unsetting the transition criterion arg for the aepsych strategy.py. We also re-enable the test Reviewed By: crasanders Differential Revision: D54960088
|
This pull request was exported from Phabricator. Differential Revision: D54960088 |
|
This pull request has been merged in d46b729. |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Mar 18, 2024
Summary: Pull Request resolved: #2282 X-link: facebookresearch/aepsych#338 Previously the integration test was failing due to not allowing unlimited trials on the last step. This is because the final step was copied from the exisiting botorch step (which contains transition criterion). If transition criterion exist on the step/node, we default to using those for determining the state of the node. This fixes the test by manually unsetting the transition criterion arg for the aepsych strategy.py. We also re-enable the test Reviewed By: crasanders Differential Revision: D54960088 fbshipit-source-id: e9c61f5ddefe45f5a9824c6dbd9068989a03bf72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously the integration test was failing due to not allowing unlimited trials on the last step. This is because the final step was copied from the exisiting botorch step (which contains transition criterion). If transition criterion exist on the step/node, we default to using those for determining the state of the node.
This fixes the test by manually unsetting the transition criterion arg for the aepsych strategy.py.
We also re-enable the test
Differential Revision: D54960088