This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
Task2 submit #248
Merged
Task2 submit #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eatedEntity, isSecondaryHeld state
…, added and styled preview view
facebook-github-bot
added
the
CLA Signed
JackUrb
reviewed
Jul 6, 2021
There was a problem hiding this comment.
This is looking really good overall! My biggest note is on starting to have documentation on your components. For ones that you don't think are great candidates for reuse, just a sentence on what the overall intent of the component, as well as another on important arguments, or gotchas you're likely to forget after a few months (if there are any) is enough. For elements that you think are reusable elsewhere, or have intentionally included abstraction, you may want a bit more than two sentences, at least enough to capture the function of the abstracting layer, and any considerations of the arguments that are important.
I've found the exercise is also helpful for actually improving on the design in the early stages of abstraction as well. When designing abstract components (specifically when abstracting from a concrete implementation) I'll often write my documentation as design goals and then they also serve as the comment I can refer to later trying to understand what the component is for.
I've also included a suggestion on a tooltip wrapper, which is relevant in a few files. But overall, excited to get this in and up!
| @@ -116,32 +149,293 @@ function MainApp() { | |||
| }, | |||
| interaction: "You place the key in the lock and turn. After a satifying click the lock becomes unlocked." | |||
| } | |||
| const submissionHandler = ()=>{ | |||
There was a problem hiding this comment.
Overall I think this is a strong handler - there's a lot of things that need to be transformed, and the conversion here is easy to follow, especially with comments.
There was a problem hiding this comment.
I will do a bit more with the commenting to explain the packaging process and maybe how the errors work as well but my hope is if anything in the way we are packaging the data should change it will be easy to add, change, or remove steps in the submission handler. I can also build some helper functions to make that process a bit easier to manage.
Comment on lines
+382
to
+417
| broadcastMessage={broadcastMessage} | ||
| setBroadcastMessage={setBroadcastMessage} | ||
| isCreatingEntity={isCreatingEntity} | ||
| setIsCreatingEntity={setIsCreatingEntity} | ||
| createdEntity={createdEntity} | ||
| setCreatedEntity={setCreatedEntity} | ||
| isRemovingObjects={isRemovingObjects} | ||
| setIsRemovingObjects={setIsRemovingObjects} | ||
| removedObjects={removedObjects} | ||
| setRemovedObjects={setRemovedObjects} | ||
| isChangingDescription={isChangingDescription} | ||
| setIsChangingDescription={setIsChangingDescription} | ||
| primaryDescription={primaryDescription} | ||
| setPrimaryDescription={setPrimaryDescription} | ||
| secondaryDescription={secondaryDescription} | ||
| setSecondaryDescription={setSecondaryDescription} | ||
| primaryModifiedAttributes={primaryModifiedAttributes} | ||
| setPrimaryModifiedAttributes={setPrimaryModifiedAttributes} | ||
| secondaryModifiedAttributes={secondaryModifiedAttributes} | ||
| setSecondaryModifiedAttributes={setSecondaryModifiedAttributes} | ||
| isSecondaryHeld={isSecondaryHeld} | ||
| setIsSecondaryHeld={setIsSecondaryHeld} | ||
| isReversible={isReversible} | ||
| setIsReversible={setIsReversible} | ||
| isLocationConstrained={isLocationConstrained} | ||
| setIsLocationConstrained={setIsLocationConstrained} | ||
| constraintLocation={constraintLocation} | ||
| setConstraintLocation={setConstraintLocation} | ||
| primaryConstrainingAttributes={primaryConstrainingAttributes} | ||
| setPrimaryConstrainingAttributes={setPrimaryConstrainingAttributes} | ||
| secondaryConstrainingAttributes={secondaryConstrainingAttributes} | ||
| setSecondaryConstrainingAttributes={setSecondaryConstrainingAttributes} | ||
| isInfinite={isInfinite} | ||
| setIsInifinite={setIsInifinite} | ||
| timesRemaining={timesRemaining} | ||
| setTimesRemaining={setTimesRemaining} |
There was a problem hiding this comment.
At some point, we may want to explore other state management in future tasks. This is the most appropriate way to do this here for now though, based on the structure we've pushed so far. I wouldn't hold the task back further to improve this here.
There was a problem hiding this comment.
Yeh, I have been thinking a bit about whether we should go the route of using context and reducer hooks or redux, we can discuss at a later date, for now we can drill props and honestly as far as tasks go drilling props probably isn't a bad approach if they are small enough but with the game app and for more complex tasks like this one I think it's a good idea to consider our options.
| @@ -3,23 +3,42 @@ import React, {useState, useEffect, useRef} from "react"; | |||
| import TaskButton from "../TaskButton" | |||
| import { MdCancel } from "react-icons/md"; | |||
|
|
|||
There was a problem hiding this comment.
We're beginning to get to a point where these classes are doing very discrete things that are hard to follow. For these sub-elements which are unlikely to be reused in different contexts, even just a single sentence could be enough.
There was a problem hiding this comment.
Yeh, today I've been going through each component from top to bottom doing adding some much needing documentation. I rather go overboard then undershoot and we can trim the fat if need be but I definitely thinking a brief explanation of the props in some of the components with the more specific use cases will definitely be useful.
| objectColor, | ||
| attributes, | ||
| isConstraint, | ||
| setter, |
There was a problem hiding this comment.
Unclear what setter is here. Without documentation, this kind of thing is hard to follow, and I'm sure would be hard to return to after a few months cold.
There was a problem hiding this comment.
I messaged you earlier that yesterday when I was debugging an issue with the payload contribution this component was making I had to basically reteach myself it so it was the first one I added some good comments to today because it's props and the naming becoming increasingly unclear was making it hard to read for even ME after only a few weeks.
| const selectHandler = (selection)=>{ | ||
| setSelectedOption(selection) | ||
| console.log("DROPDOWN SELECTION:", selection.value, selection.value !== "Select Location") |
There was a problem hiding this comment.
Unrelated note - it can be useful to employ a debug logger (either off the shelf, or by specifying a debug_log function in one of your packages) where you can turn off these logs in production by simply changing a constant in the file that defines the log.
There was a problem hiding this comment.
Good tip, thank you
| @@ -0,0 +1,19 @@ | |||
| import React, {useEffect, useState} from "react"; | |||
|
|
|||
| import {Tooltip} from 'react-tippy'; | |||
There was a problem hiding this comment.
Is this import just no longer used?
There was a problem hiding this comment.
Yes no longer used, today part of my effort was also removing imports that maybe I had planned to use when I began construction of were part of the initial template I had copied over form another component but today I definitely started trimming that.
| containerStyle="booleanquestion-text" | ||
| /> | ||
| { | ||
| hasToolTip |
There was a problem hiding this comment.
Similar feedback to before on tooltip management - as this logic is actually duplicated outside of just one file, it could be reasonable to create a OptionalTooltipWrapper component or similar that handles this specific logic of rendering children as is if no tooltip provided, else wrap with a tooltip.
|
|
||
| const BooleanQuestion = ({question, trueAnswer, falseAnswer, keywords, children})=>{ | ||
| const BooleanQuestion = ({ |
There was a problem hiding this comment.
Overall this is likely a good candidate class for more complete documentation, as it seems to have been designed for potential reuse in other tasks.
| @@ -1,44 +1,115 @@ | |||
| //REACT | |||
There was a problem hiding this comment.
Wanted to note it's super cool seeing the generic components coming together in this file (and the events one)
…p styling, and added mephisto handleSubmit to submit function
…dated screenshots
JackUrb
approved these changes
Jul 30, 2021
JackUrb
added a commit
that referenced
this pull request
Sep 1, 2021
* fixed spacing issue from help message * fixed sizing issue on tutorial screen * fixing borders and sizing issues * added styles for mobile landscape view * fixed fixed positioning in mobile view * cleared unused styles * fixed progress bar text * fixed text and nameplate styling and landing app tutorial page * added space at footer for landing app pages * added views * updating structure * added example card component * added copy arrays, styling example cards, and building good example list * styled example list components * styling preview view * adjusted content and overflow to be right of it's label, fixed intro copy, fixed coloring in details section * fixed details interaction copy * fixed alignment of example card content * building button * fixed placement of definitions and added spacing * pre-merge * added error and success toats * added screenshot to tutorial, added toast to submit * duplicated previous task * formatting constraint events task * fixed conf * restructuring app * building multiple choice * added answer form * built reusable question components, added copy, building and styling forms * added fieldQuestion component * added fieldrow component * added attributesetter component * added constraints component and questions * styled question components, headers, and layout * added multiple select question component * built attribute setter, attribute row, and added dummy data * styled attribute setter * connected dummy Data, restyled events and constraint containers, colored object names * added copy updates from initial thoughts, added location description question * added taskdatacards and datacard component * styling cards and field row border * added formatquestion component * minor style fixes on field row, added formatquestion component to task card * added format question component to boolean question component * fixed formatquestion component * added drop down component and submit checklist components * fixed positioning and fixing numbering for questions * added delete functionality to attribute setter * added and styled submission component * Adding new example copy, passing name and descriptions (#245) * pre pull * pre pull * Fixing clobbered run_task.py (#246) * Adding new example copy, passing name and descriptions * Fixing run_task.py * Fixing script config * successfully updated run_task * added and styled description to object selector, form tips, and preview image * fixed payload update * updated example card component with primary and secondary desc and styled text * updated example card component with primary and secondary desc and styled text * Task2 submit (#248) * adding state for payload * added error state * centralizing copy * added isReversible, removeItems, isRemovingItems isCreatingEntity, createdEntity, isSecondaryHeld state * building updatedRemoveObjects * added create entity event to submission handler * added events and constraints handling and packaging for payload submission * wired constraint and event state to constraint and event components * connected new copy object to events * wiring task 2 * wiring event forms * fixed field row styles * added tooltip component, building preview and tutorial copy object * added task 2 tutorial copy, added and styled tutorial entry component, added and styled preview view * updated copy for preview and updated layout * added screenshots for Preview * finishing final submission and preview changes * fixed create entity connection to submission * connected constraints and fixed submission state * building error handling and checklist component logic * building error handling and checklist component logic * added error key to task copy file * added error toasts, error key, and completion checkboxes component * fixed checkbox, restyled headers, added plus icon to add attribute button * fixed error handling for broadcast messsage and item description changes * fixed attribute setter connection to submission payload * added documentation to components, removed console logs, fixed tooltip styling, and added mephisto handleSubmit to submit function * Fixed spacing, removed improperly placed checkboxes, updated copy, updated screenshots * merge * Finalizing Narrations pilot (#257) * Moving files * Importing new examine script * Updated review scripts * Final changes for pilot * dropped configs * style changes based on user feedback * Missing css class * Fixing run, fixing copy * Updating Attributes task final pilot * Is safe is light task (#256) * Troubleshooting image loading issue * added task4, added multiple choice, added run tas and yaml files, build task state * added task4, added multiple choice, added run tas and yaml files, build task state * added Sucess and Error Banners * added copy to task copy, restructuring QuestionBlock component * added format question, updated taskcopy, added header to QuestionBlock * added tooltip component * added checkbox component * restyled question block orietation, removed unused styles * added error handling and submissionhandler * properly styled error banner * fixed submission issues * added bootstrap styles, updated comments on Question Block and multiplechoice components, added more copy for preview * several minor styling fixes, checkbox positioning, alert color, etc * Task2 locationupdate (#254) * Troubleshooting image loading issue * added, connected, and styled onSelectQuestion component for handling location change event * added, connected, and styled onSelectQuestion component for handling location change event * added error handling for new location * removed console.logs from question on select and converted inline styles to classes * Updating folder location Co-authored-by: Jack Urbanek <[email protected]> * Merging task 3 into crowdsourcing ui (#260) * Troubleshooting image loading issue * initial setup complete * building Actor Block * adding actor block draw functionality * adding actor block draw functionality * added styles, building window size state * added getDimensions utility function, added dimension state to scale component, connectect state to konva stage * added scale range optionblock footer, styled scale question component and subcomponents, connected dummy data from app.js to task component * added color gradient for scale, fixing some border styling, and sizing issues * fixed styling and fixed drag boundaries * adding more informative variables and comments, fixed boundaries, tooling with flag sizing * added GetFlagDimensions util function, breaking down scale component into scalefield scalerange scale flag selection gallery components * fixed scaleRange component to map through array of ranges replacing previous hardcoded values * changed ScaleRange component name to ScaleFooter * change pixels to percentages in scalerange section width * added documentation to ScaleQuestion component * Fixed left boundary, broke flags and selection gallery into components * fixing flag placement * Added input header, added documentation, fixed leftSoftBoundary, fixed left flagpole shift, added rating value to selection state * building task copy and dummy data * added task copy * wiring task copy into question components * added tagrow and tagquestion * styled attributes tag question * added datatype switch for testing * added conditional rendering to number form in tag question * added state to tokenizer * added ref to tokenizer, added header to copy, added header prop to tag question * Task3 scale component (#249) * building Actor Block * adding actor block draw functionality * adding actor block draw functionality * added styles, building window size state * added getDimensions utility function, added dimension state to scale component, connectect state to konva stage * added scale range optionblock footer, styled scale question component and subcomponents, connected dummy data from app.js to task component * added color gradient for scale, fixing some border styling, and sizing issues * fixed styling and fixed drag boundaries * adding more informative variables and comments, fixed boundaries, tooling with flag sizing * added GetFlagDimensions util function, breaking down scale component into scalefield scalerange scale flag selection gallery components * fixed scaleRange component to map through array of ranges replacing previous hardcoded values * changed ScaleRange component name to ScaleFooter * change pixels to percentages in scalerange section width * added documentation to ScaleQuestion component * Fixed left boundary, broke flags and selection gallery into components * fixing flag placement * Added input header, added documentation, fixed leftSoftBoundary, fixed left flagpole shift, added rating value to selection state * pre payload branch * added scaled attribute basevalues * added updateHandler * fixed attributeupdatehandler * fixed boolean payload change handler * fixed custom scale rating and input * fixed numberic attribute handler * added numeric attributes array * added multiple select question and Usefulness scale * added default questions for each type to task copy * added attribute questions component and added more documentation to Task component * fixing tag question component added tooltip component * updated defaultAttribute questions styles and update functions * fixed multiple choice component * added selection consideration to multiplechoice component * added more informative error banner * tested submit successfully * fixed scale component header alignment * premerge changes, added to tutorial copy * pre merge * removed labels from custom attribute scale, added better variables describing fixed number values in scale field, fixed indentation in multiplechoice component, changed placeholder message in tagrow * Task3 preview (#253) * added attributeChecklist screenshots * added tutorial screenshots * added final screenshot for attributeRadio * added images to TaskCopy.js * added copy and screenshots for scales and type specific tutorials * populated preview with tutorial entry components using taskcopy * added new screenshots to attributeradio2, attributeradio3 assets, styled preview * added check for 4 custom boolean attributes * changed header text color to dark blue Co-authored-by: Justin Pinero <[email protected]> Co-authored-by: JustinPinero <[email protected]> * Moving task3 * Moving safe-light task Co-authored-by: Justin Pinero <[email protected]> Co-authored-by: JustinPinero <[email protected]>
JackUrb
added a commit
that referenced
this pull request
Dec 9, 2022
* add missing missions * added star shine animation * added star shine animation * events are totally broken * Fixes and enhancements to use_events * styled soul spawn entry * Another round of backend fixes * Also fix debug logging? * Skip dialogue safety check on DEBUG * Usage limit to scrolls * added check for quest completion to reducer * added Mission success entry and total exp to progress bar * fixed border on soul spawn event entry * adding copy to tutorial page * added images to experience points topic * adding images to experience points system topic * removed glowing effect from character description on soul spawn event * added imagee to experience points system * added images to character basics * Proper serialization and deserialization of UseEvent * dozing fix * added image styles for tutorial page * added sizing styles to experience points system topic images * added image styles to character basics * Death message * Death has better messaging * added and styled action images * resized tutorial header subheader and text classes * styled tutorial text * removed tutorial header * added back link to tutorial pagee * added Character header to soulspawn event * styled stars and added shrinking animation and slide animation to message styles * added character map util function for default character emojis * fixed images being transparent with background * removed inline styling and added soulspawn-subheader class * comment out previous code for emoji mapping for later use * fixed type in exprience points system * fixed character subheader placement * update help commands * added modal component and instruction modal state * Fixing doubled context on unsafe message * Parsing events with capitalization * Fixing grammar in leave and arrive events * added header to instruction modal content * added copy to modal and back functionality to tutorial page back button * styled instruction modal and added tutorial screenshots * added closes functionality to modal * added new back button to terms and about pages * set modal to not render unless player xp<=10 * fixed typo in minitutorial * Update index.js * added help entry * updated styles * added send button and styles to chat input component * generative start features * moar * requirements change * aadded play button to bottom of tutorial page * added status entry * humanz (#228) * added and styled inventory message entry * added button revisions * Update Actions.js * fixed mobile styling for entry * restyled inventory message and made it responsive * refactored status message * restyled help entry with requested revisions * Added and styled Quest component and added it to entry component * merged other entries and removed console logs * merged all branches * restyled home page * fixed sizing bug * refactored landing app * restyled aboutpage * restyled tutorialpage * restyled terms page * restyled login page * restyled error page and logout page * styling gameapp * restyling chatlog for mobile * added isMobile state and restyled modal * added drawer feature * added resize state and event listener * added glowing button component removed typos in gameapp/styles.css building MobileFrame component * added mobile frame header * added toggleswitch, header, and buttons to mobile frame * connected mobile frame to gameapp * styled toggle and header * fixed responsive sizing in mobile frame * fixed speech bubble tails responsiveness * fixed chat icon positioning in mobile view * fixing chatlog styles * fixed chat alignment issues in mobile ui * added tooltip and lable to sidebar toggle switch * fixed spacing issue from help message (#238) * fixed spacing issue from help message * fixed sizing issue on tutorial screen * Mobile restyling Fixes (#239) * fixed spacing issue from help message * fixed sizing issue on tutorial screen * fixing borders and sizing issues * added styles for mobile landscape view * fixed fixed positioning in mobile view * cleared unused styles * fixed progress bar text * fixed text and nameplate styling and landing app tutorial page * added space at footer for landing app pages * fixed fonts on level dispaly and progress bar, changed logout button text color * fixed sizing of messages, sizing of text, send button styling * parse actions with wierd quotes (#244) * Updating parser for multithreading (#251) * added say and do buttons added documentation * removed unused code and added more documentation to chatdisplay component * adding mobile style fixes to progress bar and level display * wired tell feature * fixed repsonsive styling of player info icons on mobile * adding redux * added redux and redux toolkit * added typescript to game app * Server data browsing scripts and fixes (#255) * Requirements fix (#258) * Human to player (#259) * Merging _human and is_player * Removing old function * No longer true case about cap on characters * Crowdsourcing UI (#261) * fixed spacing issue from help message * fixed sizing issue on tutorial screen * fixing borders and sizing issues * added styles for mobile landscape view * fixed fixed positioning in mobile view * cleared unused styles * fixed progress bar text * fixed text and nameplate styling and landing app tutorial page * added space at footer for landing app pages * added views * updating structure * added example card component * added copy arrays, styling example cards, and building good example list * styled example list components * styling preview view * adjusted content and overflow to be right of it's label, fixed intro copy, fixed coloring in details section * fixed details interaction copy * fixed alignment of example card content * building button * fixed placement of definitions and added spacing * pre-merge * added error and success toats * added screenshot to tutorial, added toast to submit * duplicated previous task * formatting constraint events task * fixed conf * restructuring app * building multiple choice * added answer form * built reusable question components, added copy, building and styling forms * added fieldQuestion component * added fieldrow component * added attributesetter component * added constraints component and questions * styled question components, headers, and layout * added multiple select question component * built attribute setter, attribute row, and added dummy data * styled attribute setter * connected dummy Data, restyled events and constraint containers, colored object names * added copy updates from initial thoughts, added location description question * added taskdatacards and datacard component * styling cards and field row border * added formatquestion component * minor style fixes on field row, added formatquestion component to task card * added format question component to boolean question component * fixed formatquestion component * added drop down component and submit checklist components * fixed positioning and fixing numbering for questions * added delete functionality to attribute setter * added and styled submission component * Adding new example copy, passing name and descriptions (#245) * pre pull * pre pull * Fixing clobbered run_task.py (#246) * Adding new example copy, passing name and descriptions * Fixing run_task.py * Fixing script config * successfully updated run_task * added and styled description to object selector, form tips, and preview image * fixed payload update * updated example card component with primary and secondary desc and styled text * updated example card component with primary and secondary desc and styled text * Task2 submit (#248) * adding state for payload * added error state * centralizing copy * added isReversible, removeItems, isRemovingItems isCreatingEntity, createdEntity, isSecondaryHeld state * building updatedRemoveObjects * added create entity event to submission handler * added events and constraints handling and packaging for payload submission * wired constraint and event state to constraint and event components * connected new copy object to events * wiring task 2 * wiring event forms * fixed field row styles * added tooltip component, building preview and tutorial copy object * added task 2 tutorial copy, added and styled tutorial entry component, added and styled preview view * updated copy for preview and updated layout * added screenshots for Preview * finishing final submission and preview changes * fixed create entity connection to submission * connected constraints and fixed submission state * building error handling and checklist component logic * building error handling and checklist component logic * added error key to task copy file * added error toasts, error key, and completion checkboxes component * fixed checkbox, restyled headers, added plus icon to add attribute button * fixed error handling for broadcast messsage and item description changes * fixed attribute setter connection to submission payload * added documentation to components, removed console logs, fixed tooltip styling, and added mephisto handleSubmit to submit function * Fixed spacing, removed improperly placed checkboxes, updated copy, updated screenshots * merge * Finalizing Narrations pilot (#257) * Moving files * Importing new examine script * Updated review scripts * Final changes for pilot * dropped configs * style changes based on user feedback * Missing css class * Fixing run, fixing copy * Updating Attributes task final pilot * Is safe is light task (#256) * Troubleshooting image loading issue * added task4, added multiple choice, added run tas and yaml files, build task state * added task4, added multiple choice, added run tas and yaml files, build task state * added Sucess and Error Banners * added copy to task copy, restructuring QuestionBlock component * added format question, updated taskcopy, added header to QuestionBlock * added tooltip component * added checkbox component * restyled question block orietation, removed unused styles * added error handling and submissionhandler * properly styled error banner * fixed submission issues * added bootstrap styles, updated comments on Question Block and multiplechoice components, added more copy for preview * several minor styling fixes, checkbox positioning, alert color, etc * Task2 locationupdate (#254) * Troubleshooting image loading issue * added, connected, and styled onSelectQuestion component for handling location change event * added, connected, and styled onSelectQuestion component for handling location change event * added error handling for new location * removed console.logs from question on select and converted inline styles to classes * Updating folder location Co-authored-by: Jack Urbanek <[email protected]> * Merging task 3 into crowdsourcing ui (#260) * Troubleshooting image loading issue * initial setup complete * building Actor Block * adding actor block draw functionality * adding actor block draw functionality * added styles, building window size state * added getDimensions utility function, added dimension state to scale component, connectect state to konva stage * added scale range optionblock footer, styled scale question component and subcomponents, connected dummy data from app.js to task component * added color gradient for scale, fixing some border styling, and sizing issues * fixed styling and fixed drag boundaries * adding more informative variables and comments, fixed boundaries, tooling with flag sizing * added GetFlagDimensions util function, breaking down scale component into scalefield scalerange scale flag selection gallery components * fixed scaleRange component to map through array of ranges replacing previous hardcoded values * changed ScaleRange component name to ScaleFooter * change pixels to percentages in scalerange section width * added documentation to ScaleQuestion component * Fixed left boundary, broke flags and selection gallery into components * fixing flag placement * Added input header, added documentation, fixed leftSoftBoundary, fixed left flagpole shift, added rating value to selection state * building task copy and dummy data * added task copy * wiring task copy into question components * added tagrow and tagquestion * styled attributes tag question * added datatype switch for testing * added conditional rendering to number form in tag question * added state to tokenizer * added ref to tokenizer, added header to copy, added header prop to tag question * Task3 scale component (#249) * building Actor Block * adding actor block draw functionality * adding actor block draw functionality * added styles, building window size state * added getDimensions utility function, added dimension state to scale component, connectect state to konva stage * added scale range optionblock footer, styled scale question component and subcomponents, connected dummy data from app.js to task component * added color gradient for scale, fixing some border styling, and sizing issues * fixed styling and fixed drag boundaries * adding more informative variables and comments, fixed boundaries, tooling with flag sizing * added GetFlagDimensions util function, breaking down scale component into scalefield scalerange scale flag selection gallery components * fixed scaleRange component to map through array of ranges replacing previous hardcoded values * changed ScaleRange component name to ScaleFooter * change pixels to percentages in scalerange section width * added documentation to ScaleQuestion component * Fixed left boundary, broke flags and selection gallery into components * fixing flag placement * Added input header, added documentation, fixed leftSoftBoundary, fixed left flagpole shift, added rating value to selection state * pre payload branch * added scaled attribute basevalues * added updateHandler * fixed attributeupdatehandler * fixed boolean payload change handler * fixed custom scale rating and input * fixed numberic attribute handler * added numeric attributes array * added multiple select question and Usefulness scale * added default questions for each type to task copy * added attribute questions component and added more documentation to Task component * fixing tag question component added tooltip component * updated defaultAttribute questions styles and update functions * fixed multiple choice component * added selection consideration to multiplechoice component * added more informative error banner * tested submit successfully * fixed scale component header alignment * premerge changes, added to tutorial copy * pre merge * removed labels from custom attribute scale, added better variables describing fixed number values in scale field, fixed indentation in multiplechoice component, changed placeholder message in tagrow * Task3 preview (#253) * added attributeChecklist screenshots * added tutorial screenshots * added final screenshot for attributeRadio * added images to TaskCopy.js * added copy and screenshots for scales and type specific tutorials * populated preview with tutorial entry components using taskcopy * added new screenshots to attributeradio2, attributeradio3 assets, styled preview * added check for 4 custom boolean attributes * changed header text color to dark blue Co-authored-by: Justin Pinero <[email protected]> Co-authored-by: JustinPinero <[email protected]> * Moving task3 * Moving safe-light task Co-authored-by: Justin Pinero <[email protected]> Co-authored-by: JustinPinero <[email protected]> * Fixing npc assignment bug (#263) * added redux foundation, added personal info slices, added xp, giftxp, persona, location, reducers * added increaseXp and decrementGiftXp to reducer actions * added foundation for redux websocket integration * added documentation to slices, wired xp and giftxp redux state into experienceinfo component * removed passed props from experience info components * added sessioninfo section to features, added session xp slice, added session spent gift exp slice * removed xp props from sidebar * fixed emoji picker redux action, added view slice * Added documentation to GamePage for new state and useEffects, removed local state in game page, sidebar, mobile header * added chatInput Slice * restructured messages and types, restyling messages * fixed overlapping system messages * restructured message types and styles, fixed help message overlap bug, restyling help message copy, removed legacy styles for all message types aside from setting, player message, and agent message * restyled help message for both mobile and desktop * Multi-agent chat first pass (#264) * Multi-agent chat first pass * First round changes, clarity * Review script * Forced timeout loop * removed console logs, unused code, added substantial documentation, restyled award stars for both mobile and PC, connected sessionspentgiftxp to AgentMessage component * added styling for safari browser, added styling for mobile, fixed mainpage scrolling on refresh bug, fixed text sizing, added scrolling to each message time, added mobile specific styling to setting message * building tutorial popover * added info button * added tutorial popover component, added gamecopy file with tutorial copy, connected popover to sidebar header and body, connected redux state to tutorial * added tooltips to both chat display and sidebar * added help mode, added on click tool tips to playerinfo, Character info, mission info, location info, soulspawn message, setting message, agent message, quest message * added tooltips and animations to quest message, status message, agent message, player messsage * added tooltips and animations for inventory, send button, chat input, and chat mode, fixed agent message help mode bug * added infobutton component, added render condition to infobutton in sidebar component, added infobutton to mobile header * fixed toggle to clear tooltips during switch when in help mode * added and styled final tool tips, fixed cycle tooltips on chat bar, fixed and restyled scrolling and sizing on chat display and sidebar * Added lightqa readme that shows how to run seq2seq2seq interactively in light. (#268) Co-authored-by: Leonard Adolphs <[email protected]> * Creating a light world object from an instance of the old graph (#269) * updated the World to initiate it from the old dataset graph * docstring * Updated lightqa readme with new checkpoints. (#270) Co-authored-by: Leonard Adolphs <[email protected]> * Clarifying the equipped objects (#271) * clarifying the equipped objects * fixed the equipping tests * Documentation time (#273) * Some initial READMEs * More readmes * Even more docs * Events docs * World docs * Creating `light` master script for ParlAI tooling (#274) * Boilerplate for LIGHT-parlai content * Re-ordering * adding common sense + world builder code * Merging in teachers and code for RL-Quests paper. (#275) * Baseline code for standardizing data loading * atomic teachers working * Cleanup atomic * quest goals teacher * Predictive machines to projects * Wild chat task and code and sweeps * Updating sweep paths to new locations * Cleaning up quests build * Finished all _operational_ quests code * Remaiing related sweeps * Dropping sweeps * Uploading relevant models, adding download paths * Rl quests merge (#276) * Baseline code for standardizing data loading * atomic teachers working * Cleanup atomic * quest goals teacher * Predictive machines to projects * Wild chat task and code and sweeps * Updating sweep paths to new locations * Cleaning up quests build * Finished all _operational_ quests code * Remaiing related sweeps * Core quests rl project code * Sweeps related to RL code * Adding missing models * Dropping sweeps * Removing _almost_ all checkpoint links * Uploading relevant models, adding download paths * Core quests rl project code * Sweeps related to RL code * Adding missing models * Removing _almost_ all checkpoint links * Removing sweeps * removing sweeps... again * Build scripts now point to real file * Intro code for new project (#279) * Creating example builder script for story agents project * Writing play map example script * initial setup for both object interaction tasks * small cleanup task reviewing * default attr. from light db, make editable * small bug fix & format changes * slightly cleaner in-place update * Task lightgame (#281) * added gameplay task view * added gameplay task view * fixed message transmission in both gameapp reducer and task redux-slice * removed boilerplate * placed topmessage function at top of reducer * messy separation into tasks, needs cleanup * Pre-authorized worker login (#282) * First worker login test * Updating preauth to send context to target node, using salted hash * polishing new tasks, making to-fill more distinct * remove location box from attribute task * updating constraint task with backstory q * rename narration field, remove deleted obj * removed deleted options, action phrase * Gameapp instruction modal removal (#285) * disconnected instruction modal from GamePage * removed instructional modal * Tutorial world, full implementation (#266) * Adding flags to determine new players * Adding tutorial components, first pass * Transition from tutorial to main world seamlessly * Creating tutorial script * add models that maintain identity * override model * New secure cookies * New secure cookies, correctly * Bugfix for tests * More tutorial content Co-authored-by: Kurt Shuster <[email protected]> * Single model, reusing ActionParser (#286) * World hotfix * Small deploy-related fixes (#287) * LIGHT Tutorial fixes (#289) * Worldbuilder update (#272) * added redux * added player world slice * building modals, added modal slice to redux state * Connected modal redux state to world row icons * added create world button, styled homepage buttons and layout * building editworldpage, added stat block, added nav buttons for editworldpage, added selected world to redux state * styling modals, connected modal content to selected world redux state * added world edit routes * connected EditWorldFrame buttons to navigation * added breadcrumbs component * added buttongroups component * fixed side navigation * added sidebar component * added sidebar feature slice, built sidebar * fixed edit world sections, added general table, added dummydata * added filter to search bar * building rooms page, added bread crumb, added 2 generate fields * added slider component * added slider and button toggle to room form * added map to map page, added properly structured dummy-data to act as backend * added rooms, objectsm, and characters redux slices * Added new map components, tile, grid, utils, building tile, connected page to redux store * worldbuilder map rework, fetching and sorting room data in map page lifecycle * added border calculator * added and tested grid data generator and room checker utility functions * rebuilt grid and map components without using grid-layout library * fixing dimensions on tiles * styling paths * added sidebar, connected sidebar to selectedroom slice, connected tile click handler to sidebar and select room slice * connected advanced edit to basiceditmodal * added numberbuttoninput to tool bar * added and connected floor selector * added neighbor props to tile component, set conditional rendering for tile paths * refactoring typeahead tokenizer * fixed tokenizer * various map fixes, added character route, added cog click route, connected redux state to edit details character and object sections * fixed centering of map * added extra columns and rows at beginning and end of both axis of map * fixed starting position with new grid data * Fixing tile color update function * fixing color change state * Fixed local storage update, refactored add, delete, update reducer actions, tested map update and save, removed console logs * fixed color selection, added direct updates to draft on tile click when in color mode * added id generation to character, room, and object creation * fixed simple additions for basic edit for both characters and items * built advanced edit pages, fixed slider and generate forms, fixing path update bug on map component * fixed map loading error * began styling tiles, fixing path update bug: * fixed breadcrumbs, fixed local storage, added add room feature, added delete room feature, added create and delete buttons to quick edit, fixed tokenizer clearing selected tokens on room change * fixed edit room switch on creation, fixed edit room rerender on deletion, added map-slice, fixed position change on updates * fixed add character clearing list bug * fixed delete functions and associated state changes for both room and objects or characters, fixed sorting for tokenizer options, fixed tokenizer node creation * updated grid data generator helper function to include above and below floors * added footer and stair components to tile * fixed wiring for advanced room editor * connected advanced edit forms to state * added inlinetext insert component to character and object pages * fixed breadcrumbs * set object prefix defaults and plural defaults * added character prefix state and defaults * added and tested nested delete util function to edit objects page * added content remover helper function Co-authored-by: Jack Urbanek <[email protected]> * New database stubs for updated data model * Enums, Dataclasses * addressing some comments * updating narration and first 2 grounding tasks * updates for whole pipline * cleanup, deleted a file * Rebuild on main, committed (#299) * requirements * Fix tests on `main` (#301) * Bump parlai * soften pytest * Test soul messing up testing * Another mis-test * Accidentally dropped file * Stop confusing the tests * another one snuck by * Implementing New Users Tables (#292) * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * New Episode logging (#293) * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Addressing comments, clarifying code * New environment db (#295) * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * Using `EpisodeDB` in main game path (#297) * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Using `UserDB` as main game identity storage (#298) * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Creating and using the `ModelPool` (#300) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Enums for model types * Fixing bad merge * Creating LIGHT's ModelServer (#302) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Creating LIGHT's ModelServer * Undo server change * tornado simplicity * Handling for inline candidate models * But regular models should also work without this * Enums for model types * `asyncio` all over LIGHT (#304) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Creating LIGHT's ModelServer * Undo server change * tornado simplicity * Handling for inline candidate models * But regular models should also work without this * Async... all of the things... * Async the server too * clearing up async server tests * Correct async mock * internalize init_world * clean up tornado usage * small GameInstance bug * small GameInstance bug * Some deploy fixes * Moving safety model to async part * Some safety fixes * test fixes * Enums for model types * Checking for non-list to convert first * AWS Option for LIGHT data model storage (#305) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Creating LIGHT's ModelServer * Undo server change * tornado simplicity * Handling for inline candidate models * But regular models should also work without this * Async... all of the things... * Async the server too * clearing up async server tests * Correct async mock * internalize init_world * clean up tornado usage * small GameInstance bug * small GameInstance bug * Some deploy fixes * now using aws as a storage backend * Moving safety model to async part * Some safety fixes * test fixes * silly elif fix * dropped change on merge * Stable Server commit before coming refactors (#306) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Creating LIGHT's ModelServer * Undo server change * tornado simplicity * Handling for inline candidate models * But regular models should also work without this * Async... all of the things... * Async the server too * clearing up async server tests * Correct async mock * internalize init_world * clean up tornado usage * small GameInstance bug * small GameInstance bug * Some deploy fixes * now using aws as a storage backend * Moving safety model to async part * Some safety fixes * test fixes * silly elif fix * Taking bug-fixes from stable server * Model server changes too * Skip another web test, works in prod, refactor incoming * Enums for model types * Checking for non-list to convert first * Slightly more clarity * Privacy commitment improvements (#307) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Creating LIGHT's ModelServer * Undo server change * tornado simplicity * Handling for inline candidate models * But regular models should also work without this * Async... all of the things... * Async the server too * clearing up async server tests * Correct async mock * internalize init_world * clean up tornado usage * small GameInstance bug * small GameInstance bug * Some deploy fixes * now using aws as a storage backend * Moving safety model to async part * Some safety fixes * test fixes * silly elif fix * Taking bug-fixes from stable server * Model server changes too * Skip another web test, works in prod, refactor incoming * Ensure we're not using FB user data * Methods for scrubbing the datasets * Deleting player data and related graph info * Fixing bugs, adding tests * Environment exporting * Export episode DB too * 60 != 90 * Addressing comments * Small fixes for episode db keys * world dissociation * Small episode test cleanup * Adding headers * Some rollbacks, some copyright fixes * More header fixes * Clean up irrelevant paths Co-authored-by: Jason Weston <[email protected]> Co-authored-by: Justin Pinero <[email protected]> Co-authored-by: JustinPinero <[email protected]> Co-authored-by: Leonard <[email protected]> Co-authored-by: Leonard Adolphs <[email protected]> Co-authored-by: Mojtaba <[email protected]> Co-authored-by: Alex Gurung <[email protected]> Co-authored-by: Alex Gurung <[email protected]> Co-authored-by: Kurt Shuster <[email protected]>
JackUrb
added a commit
that referenced
this pull request
Dec 9, 2022
* fixed spacing issue from help message (#238) * fixed spacing issue from help message * fixed sizing issue on tutorial screen * Mobile restyling Fixes (#239) * fixed spacing issue from help message * fixed sizing issue on tutorial screen * fixing borders and sizing issues * added styles for mobile landscape view * fixed fixed positioning in mobile view * cleared unused styles * fixed progress bar text * fixed text and nameplate styling and landing app tutorial page * added space at footer for landing app pages * fixed fonts on level dispaly and progress bar, changed logout button text color * fixed sizing of messages, sizing of text, send button styling * parse actions with wierd quotes (#244) * Updating parser for multithreading (#251) * added say and do buttons added documentation * removed unused code and added more documentation to chatdisplay component * adding mobile style fixes to progress bar and level display * wired tell feature * fixed repsonsive styling of player info icons on mobile * adding redux * added redux and redux toolkit * added typescript to game app * Server data browsing scripts and fixes (#255) * Requirements fix (#258) * Human to player (#259) * Merging _human and is_player * Removing old function * No longer true case about cap on characters * Crowdsourcing UI (#261) * fixed spacing issue from help message * fixed sizing issue on tutorial screen * fixing borders and sizing issues * added styles for mobile landscape view * fixed fixed positioning in mobile view * cleared unused styles * fixed progress bar text * fixed text and nameplate styling and landing app tutorial page * added space at footer for landing app pages * added views * updating structure * added example card component * added copy arrays, styling example cards, and building good example list * styled example list components * styling preview view * adjusted content and overflow to be right of it's label, fixed intro copy, fixed coloring in details section * fixed details interaction copy * fixed alignment of example card content * building button * fixed placement of definitions and added spacing * pre-merge * added error and success toats * added screenshot to tutorial, added toast to submit * duplicated previous task * formatting constraint events task * fixed conf * restructuring app * building multiple choice * added answer form * built reusable question components, added copy, building and styling forms * added fieldQuestion component * added fieldrow component * added attributesetter component * added constraints component and questions * styled question components, headers, and layout * added multiple select question component * built attribute setter, attribute row, and added dummy data * styled attribute setter * connected dummy Data, restyled events and constraint containers, colored object names * added copy updates from initial thoughts, added location description question * added taskdatacards and datacard component * styling cards and field row border * added formatquestion component * minor style fixes on field row, added formatquestion component to task card * added format question component to boolean question component * fixed formatquestion component * added drop down component and submit checklist components * fixed positioning and fixing numbering for questions * added delete functionality to attribute setter * added and styled submission component * Adding new example copy, passing name and descriptions (#245) * pre pull * pre pull * Fixing clobbered run_task.py (#246) * Adding new example copy, passing name and descriptions * Fixing run_task.py * Fixing script config * successfully updated run_task * added and styled description to object selector, form tips, and preview image * fixed payload update * updated example card component with primary and secondary desc and styled text * updated example card component with primary and secondary desc and styled text * Task2 submit (#248) * adding state for payload * added error state * centralizing copy * added isReversible, removeItems, isRemovingItems isCreatingEntity, createdEntity, isSecondaryHeld state * building updatedRemoveObjects * added create entity event to submission handler * added events and constraints handling and packaging for payload submission * wired constraint and event state to constraint and event components * connected new copy object to events * wiring task 2 * wiring event forms * fixed field row styles * added tooltip component, building preview and tutorial copy object * added task 2 tutorial copy, added and styled tutorial entry component, added and styled preview view * updated copy for preview and updated layout * added screenshots for Preview * finishing final submission and preview changes * fixed create entity connection to submission * connected constraints and fixed submission state * building error handling and checklist component logic * building error handling and checklist component logic * added error key to task copy file * added error toasts, error key, and completion checkboxes component * fixed checkbox, restyled headers, added plus icon to add attribute button * fixed error handling for broadcast messsage and item description changes * fixed attribute setter connection to submission payload * added documentation to components, removed console logs, fixed tooltip styling, and added mephisto handleSubmit to submit function * Fixed spacing, removed improperly placed checkboxes, updated copy, updated screenshots * merge * Finalizing Narrations pilot (#257) * Moving files * Importing new examine script * Updated review scripts * Final changes for pilot * dropped configs * style changes based on user feedback * Missing css class * Fixing run, fixing copy * Updating Attributes task final pilot * Is safe is light task (#256) * Troubleshooting image loading issue * added task4, added multiple choice, added run tas and yaml files, build task state * added task4, added multiple choice, added run tas and yaml files, build task state * added Sucess and Error Banners * added copy to task copy, restructuring QuestionBlock component * added format question, updated taskcopy, added header to QuestionBlock * added tooltip component * added checkbox component * restyled question block orietation, removed unused styles * added error handling and submissionhandler * properly styled error banner * fixed submission issues * added bootstrap styles, updated comments on Question Block and multiplechoice components, added more copy for preview * several minor styling fixes, checkbox positioning, alert color, etc * Task2 locationupdate (#254) * Troubleshooting image loading issue * added, connected, and styled onSelectQuestion component for handling location change event * added, connected, and styled onSelectQuestion component for handling location change event * added error handling for new location * removed console.logs from question on select and converted inline styles to classes * Updating folder location Co-authored-by: Jack Urbanek <[email protected]> * Merging task 3 into crowdsourcing ui (#260) * Troubleshooting image loading issue * initial setup complete * building Actor Block * adding actor block draw functionality * adding actor block draw functionality * added styles, building window size state * added getDimensions utility function, added dimension state to scale component, connectect state to konva stage * added scale range optionblock footer, styled scale question component and subcomponents, connected dummy data from app.js to task component * added color gradient for scale, fixing some border styling, and sizing issues * fixed styling and fixed drag boundaries * adding more informative variables and comments, fixed boundaries, tooling with flag sizing * added GetFlagDimensions util function, breaking down scale component into scalefield scalerange scale flag selection gallery components * fixed scaleRange component to map through array of ranges replacing previous hardcoded values * changed ScaleRange component name to ScaleFooter * change pixels to percentages in scalerange section width * added documentation to ScaleQuestion component * Fixed left boundary, broke flags and selection gallery into components * fixing flag placement * Added input header, added documentation, fixed leftSoftBoundary, fixed left flagpole shift, added rating value to selection state * building task copy and dummy data * added task copy * wiring task copy into question components * added tagrow and tagquestion * styled attributes tag question * added datatype switch for testing * added conditional rendering to number form in tag question * added state to tokenizer * added ref to tokenizer, added header to copy, added header prop to tag question * Task3 scale component (#249) * building Actor Block * adding actor block draw functionality * adding actor block draw functionality * added styles, building window size state * added getDimensions utility function, added dimension state to scale component, connectect state to konva stage * added scale range optionblock footer, styled scale question component and subcomponents, connected dummy data from app.js to task component * added color gradient for scale, fixing some border styling, and sizing issues * fixed styling and fixed drag boundaries * adding more informative variables and comments, fixed boundaries, tooling with flag sizing * added GetFlagDimensions util function, breaking down scale component into scalefield scalerange scale flag selection gallery components * fixed scaleRange component to map through array of ranges replacing previous hardcoded values * changed ScaleRange component name to ScaleFooter * change pixels to percentages in scalerange section width * added documentation to ScaleQuestion component * Fixed left boundary, broke flags and selection gallery into components * fixing flag placement * Added input header, added documentation, fixed leftSoftBoundary, fixed left flagpole shift, added rating value to selection state * pre payload branch * added scaled attribute basevalues * added updateHandler * fixed attributeupdatehandler * fixed boolean payload change handler * fixed custom scale rating and input * fixed numberic attribute handler * added numeric attributes array * added multiple select question and Usefulness scale * added default questions for each type to task copy * added attribute questions component and added more documentation to Task component * fixing tag question component added tooltip component * updated defaultAttribute questions styles and update functions * fixed multiple choice component * added selection consideration to multiplechoice component * added more informative error banner * tested submit successfully * fixed scale component header alignment * premerge changes, added to tutorial copy * pre merge * removed labels from custom attribute scale, added better variables describing fixed number values in scale field, fixed indentation in multiplechoice component, changed placeholder message in tagrow * Task3 preview (#253) * added attributeChecklist screenshots * added tutorial screenshots * added final screenshot for attributeRadio * added images to TaskCopy.js * added copy and screenshots for scales and type specific tutorials * populated preview with tutorial entry components using taskcopy * added new screenshots to attributeradio2, attributeradio3 assets, styled preview * added check for 4 custom boolean attributes * changed header text color to dark blue Co-authored-by: Justin Pinero <[email protected]> Co-authored-by: JustinPinero <[email protected]> * Moving task3 * Moving safe-light task Co-authored-by: Justin Pinero <[email protected]> Co-authored-by: JustinPinero <[email protected]> * Fixing npc assignment bug (#263) * added redux foundation, added personal info slices, added xp, giftxp, persona, location, reducers * added increaseXp and decrementGiftXp to reducer actions * added foundation for redux websocket integration * added documentation to slices, wired xp and giftxp redux state into experienceinfo component * removed passed props from experience info components * added sessioninfo section to features, added session xp slice, added session spent gift exp slice * removed xp props from sidebar * fixed emoji picker redux action, added view slice * Added documentation to GamePage for new state and useEffects, removed local state in game page, sidebar, mobile header * added chatInput Slice * restructured messages and types, restyling messages * fixed overlapping system messages * restructured message types and styles, fixed help message overlap bug, restyling help message copy, removed legacy styles for all message types aside from setting, player message, and agent message * restyled help message for both mobile and desktop * Multi-agent chat first pass (#264) * Multi-agent chat first pass * First round changes, clarity * Review script * Forced timeout loop * removed console logs, unused code, added substantial documentation, restyled award stars for both mobile and PC, connected sessionspentgiftxp to AgentMessage component * added styling for safari browser, added styling for mobile, fixed mainpage scrolling on refresh bug, fixed text sizing, added scrolling to each message time, added mobile specific styling to setting message * building tutorial popover * added info button * added tutorial popover component, added gamecopy file with tutorial copy, connected popover to sidebar header and body, connected redux state to tutorial * added tooltips to both chat display and sidebar * added help mode, added on click tool tips to playerinfo, Character info, mission info, location info, soulspawn message, setting message, agent message, quest message * added tooltips and animations to quest message, status message, agent message, player messsage * added tooltips and animations for inventory, send button, chat input, and chat mode, fixed agent message help mode bug * added infobutton component, added render condition to infobutton in sidebar component, added infobutton to mobile header * fixed toggle to clear tooltips during switch when in help mode * added and styled final tool tips, fixed cycle tooltips on chat bar, fixed and restyled scrolling and sizing on chat display and sidebar * Added lightqa readme that shows how to run seq2seq2seq interactively in light. (#268) Co-authored-by: Leonard Adolphs <[email protected]> * Creating a light world object from an instance of the old graph (#269) * updated the World to initiate it from the old dataset graph * docstring * Updated lightqa readme with new checkpoints. (#270) Co-authored-by: Leonard Adolphs <[email protected]> * Clarifying the equipped objects (#271) * clarifying the equipped objects * fixed the equipping tests * Documentation time (#273) * Some initial READMEs * More readmes * Even more docs * Events docs * World docs * Creating `light` master script for ParlAI tooling (#274) * Boilerplate for LIGHT-parlai content * Re-ordering * adding common sense + world builder code * Merging in teachers and code for RL-Quests paper. (#275) * Baseline code for standardizing data loading * atomic teachers working * Cleanup atomic * quest goals teacher * Predictive machines to projects * Wild chat task and code and sweeps * Updating sweep paths to new locations * Cleaning up quests build * Finished all _operational_ quests code * Remaiing related sweeps * Dropping sweeps * Uploading relevant models, adding download paths * Rl quests merge (#276) * Baseline code for standardizing data loading * atomic teachers working * Cleanup atomic * quest goals teacher * Predictive machines to projects * Wild chat task and code and sweeps * Updating sweep paths to new locations * Cleaning up quests build * Finished all _operational_ quests code * Remaiing related sweeps * Core quests rl project code * Sweeps related to RL code * Adding missing models * Dropping sweeps * Removing _almost_ all checkpoint links * Uploading relevant models, adding download paths * Core quests rl project code * Sweeps related to RL code * Adding missing models * Removing _almost_ all checkpoint links * Removing sweeps * removing sweeps... again * Build scripts now point to real file * Intro code for new project (#279) * Creating example builder script for story agents project * Writing play map example script * initial setup for both object interaction tasks * small cleanup task reviewing * default attr. from light db, make editable * small bug fix & format changes * slightly cleaner in-place update * Task lightgame (#281) * added gameplay task view * added gameplay task view * fixed message transmission in both gameapp reducer and task redux-slice * removed boilerplate * placed topmessage function at top of reducer * messy separation into tasks, needs cleanup * Pre-authorized worker login (#282) * First worker login test * Updating preauth to send context to target node, using salted hash * polishing new tasks, making to-fill more distinct * remove location box from attribute task * updating constraint task with backstory q * rename narration field, remove deleted obj * removed deleted options, action phrase * Gameapp instruction modal removal (#285) * disconnected instruction modal from GamePage * removed instructional modal * Tutorial world, full implementation (#266) * Adding flags to determine new players * Adding tutorial components, first pass * Transition from tutorial to main world seamlessly * Creating tutorial script * add models that maintain identity * override model * New secure cookies * New secure cookies, correctly * Bugfix for tests * More tutorial content Co-authored-by: Kurt Shuster <[email protected]> * Single model, reusing ActionParser (#286) * World hotfix * Small deploy-related fixes (#287) * LIGHT Tutorial fixes (#289) * Worldbuilder update (#272) * added redux * added player world slice * building modals, added modal slice to redux state * Connected modal redux state to world row icons * added create world button, styled homepage buttons and layout * building editworldpage, added stat block, added nav buttons for editworldpage, added selected world to redux state * styling modals, connected modal content to selected world redux state * added world edit routes * connected EditWorldFrame buttons to navigation * added breadcrumbs component * added buttongroups component * fixed side navigation * added sidebar component * added sidebar feature slice, built sidebar * fixed edit world sections, added general table, added dummydata * added filter to search bar * building rooms page, added bread crumb, added 2 generate fields * added slider component * added slider and button toggle to room form * added map to map page, added properly structured dummy-data to act as backend * added rooms, objectsm, and characters redux slices * Added new map components, tile, grid, utils, building tile, connected page to redux store * worldbuilder map rework, fetching and sorting room data in map page lifecycle * added border calculator * added and tested grid data generator and room checker utility functions * rebuilt grid and map components without using grid-layout library * fixing dimensions on tiles * styling paths * added sidebar, connected sidebar to selectedroom slice, connected tile click handler to sidebar and select room slice * connected advanced edit to basiceditmodal * added numberbuttoninput to tool bar * added and connected floor selector * added neighbor props to tile component, set conditional rendering for tile paths * refactoring typeahead tokenizer * fixed tokenizer * various map fixes, added character route, added cog click route, connected redux state to edit details character and object sections * fixed centering of map * added extra columns and rows at beginning and end of both axis of map * fixed starting position with new grid data * Fixing tile color update function * fixing color change state * Fixed local storage update, refactored add, delete, update reducer actions, tested map update and save, removed console logs * fixed color selection, added direct updates to draft on tile click when in color mode * added id generation to character, room, and object creation * fixed simple additions for basic edit for both characters and items * built advanced edit pages, fixed slider and generate forms, fixing path update bug on map component * fixed map loading error * began styling tiles, fixing path update bug: * fixed breadcrumbs, fixed local storage, added add room feature, added delete room feature, added create and delete buttons to quick edit, fixed tokenizer clearing selected tokens on room change * fixed edit room switch on creation, fixed edit room rerender on deletion, added map-slice, fixed position change on updates * fixed add character clearing list bug * fixed delete functions and associated state changes for both room and objects or characters, fixed sorting for tokenizer options, fixed tokenizer node creation * updated grid data generator helper function to include above and below floors * added footer and stair components to tile * fixed wiring for advanced room editor * connected advanced edit forms to state * added inlinetext insert component to character and object pages * fixed breadcrumbs * set object prefix defaults and plural defaults * added character prefix state and defaults * added and tested nested delete util function to edit objects page * added content remover helper function Co-authored-by: Jack Urbanek <[email protected]> * New database stubs for updated data model * Enums, Dataclasses * addressing some comments * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * updating narration and first 2 grounding tasks * updates for whole pipline * cleanup, deleted a file * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * Rebuild on main, committed (#299) * requirements * removing prints * Fix tests on `main` (#301) * Bump parlai * soften pytest * Test soul messing up testing * Another mis-test * Accidentally dropped file * Stop confusing the tests * another one snuck by * Fixing some tests, skipping starspace * Runs on server too * Creating LIGHT's ModelServer * Undo server change * tornado simplicity * Handling for inline candidate models * But regular models should also work without this * Async... all of the things... * Async the server too * clearing up async server tests * Correct async mock * internalize init_world * clean up tornado usage * small GameInstance bug * small GameInstance bug * Some deploy fixes * now using aws as a storage backend * Moving safety model to async part * Some safety fixes * test fixes * silly elif fix * Taking bug-fixes from stable server * Model server changes too * Skip another web test, works in prod, refactor incoming * Ensure we're not using FB user data * Methods for scrubbing the datasets * Deleting player data and related graph info * Fixing bugs, adding tests * Environment exporting * Export episode DB too * Enums for model types * Checking for non-list to convert first * Slightly more clarity * 60 != 90 * Creating initial hydra classes and structures * base model loading classes * progress towards play_map * Model loading works from hydra * Play-map works again * Main tests passing again * Restoring broken point for tutorial * Making ModelServer work again * Server works for local deploy with hydra config * Server tests now passing * hydra 1.2 * temporary hydra force upgrade for tests * pre-publish review * Implementing New Users Tables (#292) * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * New Episode logging (#293) * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Addressing comments, clarifying code * New environment db (#295) * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * Using `EpisodeDB` in main game path (#297) * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Using `UserDB` as main game identity storage (#298) * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Creating and using the `ModelPool` (#300) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Enums for model types * Fixing bad merge * Creating LIGHT's ModelServer (#302) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Creating LIGHT's ModelServer * Undo server change * tornado simplicity * Handling for inline candidate models * But regular models should also work without this * Enums for model types * `asyncio` all over LIGHT (#304) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Creating LIGHT's ModelServer * Undo server change * tornado simplicity * Handling for inline candidate models * But regular models should also work without this * Async... all of the things... * Async the server too * clearing up async server tests * Correct async mock * internalize init_world * clean up tornado usage * small GameInstance bug * small GameInstance bug * Some deploy fixes * Moving safety model to async part * Some safety fixes * test fixes * Enums for model types * Checking for non-list to convert first * AWS Option for LIGHT data model storage (#305) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Creating LIGHT's ModelServer * Undo server change * tornado simplicity * Handling for inline candidate models * But regular models should also work without this * Async... all of the things... * Async the server too * clearing up async server tests * Correct async mock * internalize init_world * clean up tornado usage * small GameInstance bug * small GameInstance bug * Some deploy fixes * now using aws as a storage backend * Moving safety model to async part * Some safety fixes * test fixes * silly elif fix * dropped change on merge * Stable Server commit before coming refactors (#306) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Creating LIGHT's ModelServer * Undo server change * tornado simplicity * Handling for inline candidate models * But regular models should also work without this * Async... all of the things... * Async the server too * clearing up async server tests * Correct async mock * internalize init_world * clean up tornado usage * small GameInstance bug * small GameInstance bug * Some deploy fixes * now using aws as a storage backend * Moving safety model to async part * Some safety fixes * test fixes * silly elif fix * Taking bug-fixes from stable server * Model server changes too * Skip another web test, works in prod, refactor incoming * Enums for model types * Checking for non-list to convert first * Slightly more clarity * Privacy commitment improvements (#307) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Creating LIGHT's ModelServer * Undo server change * tornado simplicity * Handling for inline candidate models * But regular models should also work without this * Async... all of the things... * Async the server too * clearing up async server tests * Correct async mock * internalize init_world * clean up tornado usage * small GameInstance bug * small GameInstance bug * Some deploy fixes * now using aws as a storage backend * Moving safety model to async part * Some safety fixes * test fixes * silly elif fix * Taking bug-fixes from stable server * Model server changes too * Skip another web test, works in prod, refactor incoming * Ensure we're not using FB user data * Methods for scrubbing the datasets * Deleting player data and related graph info * Fixing bugs, adding tests * Environment exporting * Export episode DB too * 60 != 90 * Addressing comments * Base architecture README * Addressing comments * Missed a FLAGS * Small fixes for episode db keys * world dissociation * Small episode test cleanup * Adding headers * Some rollbacks, some copyright fixes * More header fixes * Clean up irrelevant paths * Adding missing hydra configs * Login page differs between dev and prod * Dropping older tests * correct config import loc * Forgot to commit the files somehow * Small fixes * 0.2.0 * Update world.py * fixing old mistake * next-1-hydrize Co-authored-by: JustinPinero <[email protected]> Co-authored-by: Justin Pinero <[email protected]> Co-authored-by: Leonard <[email protected]> Co-authored-by: Leonard Adolphs <[email protected]> Co-authored-by: Mojtaba <[email protected]> Co-authored-by: Alex Gurung <[email protected]> Co-authored-by: Alex Gurung <[email protected]> Co-authored-by: Kurt Shuster <[email protected]>
JackUrb
added a commit
that referenced
this pull request
Dec 9, 2022
* fixed sizing of messages, sizing of text, send button styling * parse actions with wierd quotes (#244) * Updating parser for multithreading (#251) * added say and do buttons added documentation * removed unused code and added more documentation to chatdisplay component * adding mobile style fixes to progress bar and level display * wired tell feature * fixed repsonsive styling of player info icons on mobile * adding redux * added redux and redux toolkit * added typescript to game app * Server data browsing scripts and fixes (#255) * Requirements fix (#258) * Human to player (#259) * Merging _human and is_player * Removing old function * No longer true case about cap on characters * Crowdsourcing UI (#261) * fixed spacing issue from help message * fixed sizing issue on tutorial screen * fixing borders and sizing issues * added styles for mobile landscape view * fixed fixed positioning in mobile view * cleared unused styles * fixed progress bar text * fixed text and nameplate styling and landing app tutorial page * added space at footer for landing app pages * added views * updating structure * added example card component * added copy arrays, styling example cards, and building good example list * styled example list components * styling preview view * adjusted content and overflow to be right of it's label, fixed intro copy, fixed coloring in details section * fixed details interaction copy * fixed alignment of example card content * building button * fixed placement of definitions and added spacing * pre-merge * added error and success toats * added screenshot to tutorial, added toast to submit * duplicated previous task * formatting constraint events task * fixed conf * restructuring app * building multiple choice * added answer form * built reusable question components, added copy, building and styling forms * added fieldQuestion component * added fieldrow component * added attributesetter component * added constraints component and questions * styled question components, headers, and layout * added multiple select question component * built attribute setter, attribute row, and added dummy data * styled attribute setter * connected dummy Data, restyled events and constraint containers, colored object names * added copy updates from initial thoughts, added location description question * added taskdatacards and datacard component * styling cards and field row border * added formatquestion component * minor style fixes on field row, added formatquestion component to task card * added format question component to boolean question component * fixed formatquestion component * added drop down component and submit checklist components * fixed positioning and fixing numbering for questions * added delete functionality to attribute setter * added and styled submission component * Adding new example copy, passing name and descriptions (#245) * pre pull * pre pull * Fixing clobbered run_task.py (#246) * Adding new example copy, passing name and descriptions * Fixing run_task.py * Fixing script config * successfully updated run_task * added and styled description to object selector, form tips, and preview image * fixed payload update * updated example card component with primary and secondary desc and styled text * updated example card component with primary and secondary desc and styled text * Task2 submit (#248) * adding state for payload * added error state * centralizing copy * added isReversible, removeItems, isRemovingItems isCreatingEntity, createdEntity, isSecondaryHeld state * building updatedRemoveObjects * added create entity event to submission handler * added events and constraints handling and packaging for payload submission * wired constraint and event state to constraint and event components * connected new copy object to events * wiring task 2 * wiring event forms * fixed field row styles * added tooltip component, building preview and tutorial copy object * added task 2 tutorial copy, added and styled tutorial entry component, added and styled preview view * updated copy for preview and updated layout * added screenshots for Preview * finishing final submission and preview changes * fixed create entity connection to submission * connected constraints and fixed submission state * building error handling and checklist component logic * building error handling and checklist component logic * added error key to task copy file * added error toasts, error key, and completion checkboxes component * fixed checkbox, restyled headers, added plus icon to add attribute button * fixed error handling for broadcast messsage and item description changes * fixed attribute setter connection to submission payload * added documentation to components, removed console logs, fixed tooltip styling, and added mephisto handleSubmit to submit function * Fixed spacing, removed improperly placed checkboxes, updated copy, updated screenshots * merge * Finalizing Narrations pilot (#257) * Moving files * Importing new examine script * Updated review scripts * Final changes for pilot * dropped configs * style changes based on user feedback * Missing css class * Fixing run, fixing copy * Updating Attributes task final pilot * Is safe is light task (#256) * Troubleshooting image loading issue * added task4, added multiple choice, added run tas and yaml files, build task state * added task4, added multiple choice, added run tas and yaml files, build task state * added Sucess and Error Banners * added copy to task copy, restructuring QuestionBlock component * added format question, updated taskcopy, added header to QuestionBlock * added tooltip component * added checkbox component * restyled question block orietation, removed unused styles * added error handling and submissionhandler * properly styled error banner * fixed submission issues * added bootstrap styles, updated comments on Question Block and multiplechoice components, added more copy for preview * several minor styling fixes, checkbox positioning, alert color, etc * Task2 locationupdate (#254) * Troubleshooting image loading issue * added, connected, and styled onSelectQuestion component for handling location change event * added, connected, and styled onSelectQuestion component for handling location change event * added error handling for new location * removed console.logs from question on select and converted inline styles to classes * Updating folder location Co-authored-by: Jack Urbanek <[email protected]> * Merging task 3 into crowdsourcing ui (#260) * Troubleshooting image loading issue * initial setup complete * building Actor Block * adding actor block draw functionality * adding actor block draw functionality * added styles, building window size state * added getDimensions utility function, added dimension state to scale component, connectect state to konva stage * added scale range optionblock footer, styled scale question component and subcomponents, connected dummy data from app.js to task component * added color gradient for scale, fixing some border styling, and sizing issues * fixed styling and fixed drag boundaries * adding more informative variables and comments, fixed boundaries, tooling with flag sizing * added GetFlagDimensions util function, breaking down scale component into scalefield scalerange scale flag selection gallery components * fixed scaleRange component to map through array of ranges replacing previous hardcoded values * changed ScaleRange component name to ScaleFooter * change pixels to percentages in scalerange section width * added documentation to ScaleQuestion component * Fixed left boundary, broke flags and selection gallery into components * fixing flag placement * Added input header, added documentation, fixed leftSoftBoundary, fixed left flagpole shift, added rating value to selection state * building task copy and dummy data * added task copy * wiring task copy into question components * added tagrow and tagquestion * styled attributes tag question * added datatype switch for testing * added conditional rendering to number form in tag question * added state to tokenizer * added ref to tokenizer, added header to copy, added header prop to tag question * Task3 scale component (#249) * building Actor Block * adding actor block draw functionality * adding actor block draw functionality * added styles, building window size state * added getDimensions utility function, added dimension state to scale component, connectect state to konva stage * added scale range optionblock footer, styled scale question component and subcomponents, connected dummy data from app.js to task component * added color gradient for scale, fixing some border styling, and sizing issues * fixed styling and fixed drag boundaries * adding more informative variables and comments, fixed boundaries, tooling with flag sizing * added GetFlagDimensions util function, breaking down scale component into scalefield scalerange scale flag selection gallery components * fixed scaleRange component to map through array of ranges replacing previous hardcoded values * changed ScaleRange component name to ScaleFooter * change pixels to percentages in scalerange section width * added documentation to ScaleQuestion component * Fixed left boundary, broke flags and selection gallery into components * fixing flag placement * Added input header, added documentation, fixed leftSoftBoundary, fixed left flagpole shift, added rating value to selection state * pre payload branch * added scaled attribute basevalues * added updateHandler * fixed attributeupdatehandler * fixed boolean payload change handler * fixed custom scale rating and input * fixed numberic attribute handler * added numeric attributes array * added multiple select question and Usefulness scale * added default questions for each type to task copy * added attribute questions component and added more documentation to Task component * fixing tag question component added tooltip component * updated defaultAttribute questions styles and update functions * fixed multiple choice component * added selection consideration to multiplechoice component * added more informative error banner * tested submit successfully * fixed scale component header alignment * premerge changes, added to tutorial copy * pre merge * removed labels from custom attribute scale, added better variables describing fixed number values in scale field, fixed indentation in multiplechoice component, changed placeholder message in tagrow * Task3 preview (#253) * added attributeChecklist screenshots * added tutorial screenshots * added final screenshot for attributeRadio * added images to TaskCopy.js * added copy and screenshots for scales and type specific tutorials * populated preview with tutorial entry components using taskcopy * added new screenshots to attributeradio2, attributeradio3 assets, styled preview * added check for 4 custom boolean attributes * changed header text color to dark blue Co-authored-by: Justin Pinero <[email protected]> Co-authored-by: JustinPinero <[email protected]> * Moving task3 * Moving safe-light task Co-authored-by: Justin Pinero <[email protected]> Co-authored-by: JustinPinero <[email protected]> * Fixing npc assignment bug (#263) * added redux foundation, added personal info slices, added xp, giftxp, persona, location, reducers * added increaseXp and decrementGiftXp to reducer actions * added foundation for redux websocket integration * added documentation to slices, wired xp and giftxp redux state into experienceinfo component * removed passed props from experience info components * added sessioninfo section to features, added session xp slice, added session spent gift exp slice * removed xp props from sidebar * fixed emoji picker redux action, added view slice * Added documentation to GamePage for new state and useEffects, removed local state in game page, sidebar, mobile header * added chatInput Slice * restructured messages and types, restyling messages * fixed overlapping system messages * restructured message types and styles, fixed help message overlap bug, restyling help message copy, removed legacy styles for all message types aside from setting, player message, and agent message * restyled help message for both mobile and desktop * Multi-agent chat first pass (#264) * Multi-agent chat first pass * First round changes, clarity * Review script * Forced timeout loop * removed console logs, unused code, added substantial documentation, restyled award stars for both mobile and PC, connected sessionspentgiftxp to AgentMessage component * added styling for safari browser, added styling for mobile, fixed mainpage scrolling on refresh bug, fixed text sizing, added scrolling to each message time, added mobile specific styling to setting message * building tutorial popover * added info button * added tutorial popover component, added gamecopy file with tutorial copy, connected popover to sidebar header and body, connected redux state to tutorial * added tooltips to both chat display and sidebar * added help mode, added on click tool tips to playerinfo, Character info, mission info, location info, soulspawn message, setting message, agent message, quest message * added tooltips and animations to quest message, status message, agent message, player messsage * added tooltips and animations for inventory, send button, chat input, and chat mode, fixed agent message help mode bug * added infobutton component, added render condition to infobutton in sidebar component, added infobutton to mobile header * fixed toggle to clear tooltips during switch when in help mode * added and styled final tool tips, fixed cycle tooltips on chat bar, fixed and restyled scrolling and sizing on chat display and sidebar * Added lightqa readme that shows how to run seq2seq2seq interactively in light. (#268) Co-authored-by: Leonard Adolphs <[email protected]> * Creating a light world object from an instance of the old graph (#269) * updated the World to initiate it from the old dataset graph * docstring * Updated lightqa readme with new checkpoints. (#270) Co-authored-by: Leonard Adolphs <[email protected]> * Clarifying the equipped objects (#271) * clarifying the equipped objects * fixed the equipping tests * Documentation time (#273) * Some initial READMEs * More readmes * Even more docs * Events docs * World docs * Creating `light` master script for ParlAI tooling (#274) * Boilerplate for LIGHT-parlai content * Re-ordering * adding common sense + world builder code * Merging in teachers and code for RL-Quests paper. (#275) * Baseline code for standardizing data loading * atomic teachers working * Cleanup atomic * quest goals teacher * Predictive machines to projects * Wild chat task and code and sweeps * Updating sweep paths to new locations * Cleaning up quests build * Finished all _operational_ quests code * Remaiing related sweeps * Dropping sweeps * Uploading relevant models, adding download paths * Rl quests merge (#276) * Baseline code for standardizing data loading * atomic teachers working * Cleanup atomic * quest goals teacher * Predictive machines to projects * Wild chat task and code and sweeps * Updating sweep paths to new locations * Cleaning up quests build * Finished all _operational_ quests code * Remaiing related sweeps * Core quests rl project code * Sweeps related to RL code * Adding missing models * Dropping sweeps * Removing _almost_ all checkpoint links * Uploading relevant models, adding download paths * Core quests rl project code * Sweeps related to RL code * Adding missing models * Removing _almost_ all checkpoint links * Removing sweeps * removing sweeps... again * Build scripts now point to real file * Intro code for new project (#279) * Creating example builder script for story agents project * Writing play map example script * initial setup for both object interaction tasks * small cleanup task reviewing * default attr. from light db, make editable * small bug fix & format changes * slightly cleaner in-place update * Task lightgame (#281) * added gameplay task view * added gameplay task view * fixed message transmission in both gameapp reducer and task redux-slice * removed boilerplate * placed topmessage function at top of reducer * messy separation into tasks, needs cleanup * Pre-authorized worker login (#282) * First worker login test * Updating preauth to send context to target node, using salted hash * polishing new tasks, making to-fill more distinct * remove location box from attribute task * updating constraint task with backstory q * rename narration field, remove deleted obj * removed deleted options, action phrase * Gameapp instruction modal removal (#285) * disconnected instruction modal from GamePage * removed instructional modal * Tutorial world, full implementation (#266) * Adding flags to determine new players * Adding tutorial components, first pass * Transition from tutorial to main world seamlessly * Creating tutorial script * add models that maintain identity * override model * New secure cookies * New secure cookies, correctly * Bugfix for tests * More tutorial content Co-authored-by: Kurt Shuster <[email protected]> * Single model, reusing ActionParser (#286) * World hotfix * Small deploy-related fixes (#287) * LIGHT Tutorial fixes (#289) * Worldbuilder update (#272) * added redux * added player world slice * building modals, added modal slice to redux state * Connected modal redux state to world row icons * added create world button, styled homepage buttons and layout * building editworldpage, added stat block, added nav buttons for editworldpage, added selected world to redux state * styling modals, connected modal content to selected world redux state * added world edit routes * connected EditWorldFrame buttons to navigation * added breadcrumbs component * added buttongroups component * fixed side navigation * added sidebar component * added sidebar feature slice, built sidebar * fixed edit world sections, added general table, added dummydata * added filter to search bar * building rooms page, added bread crumb, added 2 generate fields * added slider component * added slider and button toggle to room form * added map to map page, added properly structured dummy-data to act as backend * added rooms, objectsm, and characters redux slices * Added new map components, tile, grid, utils, building tile, connected page to redux store * worldbuilder map rework, fetching and sorting room data in map page lifecycle * added border calculator * added and tested grid data generator and room checker utility functions * rebuilt grid and map components without using grid-layout library * fixing dimensions on tiles * styling paths * added sidebar, connected sidebar to selectedroom slice, connected tile click handler to sidebar and select room slice * connected advanced edit to basiceditmodal * added numberbuttoninput to tool bar * added and connected floor selector * added neighbor props to tile component, set conditional rendering for tile paths * refactoring typeahead tokenizer * fixed tokenizer * various map fixes, added character route, added cog click route, connected redux state to edit details character and object sections * fixed centering of map * added extra columns and rows at beginning and end of both axis of map * fixed starting position with new grid data * Fixing tile color update function * fixing color change state * Fixed local storage update, refactored add, delete, update reducer actions, tested map update and save, removed console logs * fixed color selection, added direct updates to draft on tile click when in color mode * added id generation to character, room, and object creation * fixed simple additions for basic edit for both characters and items * built advanced edit pages, fixed slider and generate forms, fixing path update bug on map component * fixed map loading error * began styling tiles, fixing path update bug: * fixed breadcrumbs, fixed local storage, added add room feature, added delete room feature, added create and delete buttons to quick edit, fixed tokenizer clearing selected tokens on room change * fixed edit room switch on creation, fixed edit room rerender on deletion, added map-slice, fixed position change on updates * fixed add character clearing list bug * fixed delete functions and associated state changes for both room and objects or characters, fixed sorting for tokenizer options, fixed tokenizer node creation * updated grid data generator helper function to include above and below floors * added footer and stair components to tile * fixed wiring for advanced room editor * connected advanced edit forms to state * added inlinetext insert component to character and object pages * fixed breadcrumbs * set object prefix defaults and plural defaults * added character prefix state and defaults * added and tested nested delete util function to edit objects page * added content remover helper function Co-authored-by: Jack Urbanek <[email protected]> * New database stubs for updated data model * Enums, Dataclasses * addressing some comments * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * updating narration and first 2 grounding tasks * updates for whole pipline * cleanup, deleted a file * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * Rebuild on main, committed (#299) * requirements * removing prints * Fix tests on `main` (#301) * Bump parlai * soften pytest * Test soul messing up testing * Another mis-test * Accidentally dropped file * Stop confusing the tests * another one snuck by * Fixing some tests, skipping starspace * Runs on server too * Creating LIGHT's ModelServer * Undo server change * tornado simplicity * Handling for inline candidate models * But regular models should also work without this * Async... all of the things... * Async the server too * clearing up async server tests * Correct async mock * internalize init_world * clean up tornado usage * small GameInstance bug * small GameInstance bug * Some deploy fixes * now using aws as a storage backend * Moving safety model to async part * Some safety fixes * test fixes * silly elif fix * Taking bug-fixes from stable server * Model server changes too * Skip another web test, works in prod, refactor incoming * Ensure we're not using FB user data * Methods for scrubbing the datasets * Deleting player data and related graph info * Fixing bugs, adding tests * Environment exporting * Export episode DB too * Enums for model types * Checking for non-list to convert first * Slightly more clarity * 60 != 90 * Creating initial hydra classes and structures * base model loading classes * progress towards play_map * Model loading works from hydra * Play-map works again * Main tests passing again * Restoring broken point for tutorial * Making ModelServer work again * Server works for local deploy with hydra config * Server tests now passing * hydra 1.2 * temporary hydra force upgrade for tests * pre-publish review * Implementing New Users Tables (#292) * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * New Episode logging (#293) * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Addressing comments, clarifying code * New environment db (#295) * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * Using `EpisodeDB` in main game path (#297) * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Using `UserDB` as main game identity storage (#298) * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Creating and using the `ModelPool` (#300) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Enums for model types * Fixing bad merge * Creating LIGHT's ModelServer (#302) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Creating LIGHT's ModelServer * Undo server change * tornado simplicity * Handling for inline candidate models * But regular models should also work without this * Enums for model types * `asyncio` all over LIGHT (#304) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Creating LIGHT's ModelServer * Undo server change * tornado simplicity * Handling for inline candidate models * But regular models should also work without this * Async... all of the things... * Async the server too * clearing up async server tests * Correct async mock * internalize init_world * clean up tornado usage * small GameInstance bug * small GameInstance bug * Some deploy fixes * Moving safety model to async part * Some safety fixes * test fixes * Enums for model types * Checking for non-list to convert first * AWS Option for LIGHT data model storage (#305) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Creating LIGHT's ModelServer * Undo server change * tornado simplicity * Handling for inline candidate models * But regular models should also work without this * Async... all of the things... * Async the server too * clearing up async server tests * Correct async mock * internalize init_world * clean up tornado usage * small GameInstance bug * small GameInstance bug * Some deploy fixes * now using aws as a storage backend * Moving safety model to async part * Some safety fixes * test fixes * silly elif fix * dropped change on merge * Stable Server commit before coming refactors (#306) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Creating LIGHT's ModelServer * Undo server change * tornado simplicity * Handling for inline candidate models * But regular models should also work without this * Async... all of the things... * Async the server too * clearing up async server tests * Correct async mock * internalize init_world * clean up tornado usage * small GameInstance bug * small GameInstance bug * Some deploy fixes * now using aws as a storage backend * Moving safety model to async part * Some safety fixes * test fixes * silly elif fix * Taking bug-fixes from stable server * Model server changes too * Skip another web test, works in prod, refactor incoming * Enums for model types * Checking for non-list to convert first * Slightly more clarity * Privacy commitment improvements (#307) * Some initial transitions over to model pool * Moving initialization code out from where it occurred * Wiring more of the system together * Adding opt for reranked generative * Filling out UserDB * Abstract enforce get first * Clearer argument - num_turns * Using enums in DB * Initial episode data model * Update content loggers to use episode formatting * Updating tables to work with testing * Fixing some test changes * Fixing small warnings that were noise during tests * Moving default log path * Test fix * Correcting math thanks to Kurt * Updating env DB classes to SQLAlchemy * Name keys and Elems coded * Adding arbitrary node attributes * First complete pass of EnvDB * Mypy fixings * Fixing agents * Writing some tests * Finishing tests for object and room creates and queries * Edge testing * Arbitrary attributes testing * Quests and testing * And finally, DBGraph tests * fixing episode change * TODO function * final mypy fixes * DBID testing * a -> either a or an depending on aeiou * adding WorldConfig to hold complex configuration vars * Moving episode_db into relevant GraphBuilders * Game launches, but not logging * Local BaseDB, now saving episodes * Missing files * deleting miscommit * test fix * Migrating to UserDB * No more LIGHTDatabase in TornadoServer * Fixing tests * Works after testing locally * Updated messaging for unimplemented * Upgrading OneRoomGraphBuilder to ModelPool * Completing (almost) the rest of Modelpool references * Works without loading models in play_map * Model pool actually works * Safety working as well * removing prints * Fixing some tests, skipping starspace * Runs on server too * Creating LIGHT's ModelServer * Undo server change * tornado simplicity * Handling for inline candidate models * But regular models should also work without this * Async... all of the things... * Async the server too * clearing up async server tests * Correct async mock * internalize init_world * clean up tornado usage * small GameInstance bug * small GameInstance bug * Some deploy fixes * now using aws as a storage backend * Moving safety model to async part * Some safety fixes * test fixes * silly elif fix * Taking bug-fixes from stable server * Model server changes too * Skip another web test, works in prod, refactor incoming * Ensure we're not using FB user data * Methods for scrubbing the datasets * Deleting player data and related graph info * Fixing bugs, adding tests * Environment exporting * Export episode DB too * 60 != 90 * Addressing comments * Base architecture README * Addressing comments * Missed a FLAGS * Small fixes for episode db keys * Adding wild episode metadata to EpisodeDB * Tests pass after contain size fix * Need to size up * Ordering mistake * world dissociation * Small episode test cleanup * Adding headers * Some rollbacks, some copyright fixes * More header fixes * Clean up irrelevant paths * Adding missing hydra configs * Login page differs between dev and prod * Dropping older tests * correct config import loc * Forgot to commit the files somehow * Small fixes * 0.2.0 Co-authored-by: Justin Pinero <[email protected]> Co-authored-by: JustinPinero <[email protected]> Co-authored-by: Leonard <[email protected]> Co-authored-by: Leonard Adolphs <[email protected]> Co-authored-by: Mojtaba <[email protected]> Co-authored-by: Alex Gurung <[email protected]> Co-authored-by: Alex Gurung <[email protected]> Co-authored-by: Kurt Shuster <[email protected]>
JackUrb
added a commit
that referenced
this pull request
Dec 9, 2022
* Skip dialogue safety check on DEBUG * Usage limit to scrolls * added check for quest completion to reducer * added Mission success entry and total exp to progress bar * fixed border on soul spawn event entry * adding copy to tutorial page * added images to experience points topic * adding images to experience points system topic * removed glowing effect from character description on soul spawn event * added imagee to experience points system * added images to character basics * Proper serialization and deserialization of UseEvent * dozing fix * added image styles for tutorial page * added sizing styles to experience points system topic images * added image styles to character basics * Death message * Death has better messaging * added and styled action images * resized tutorial header subheader and text classes * styled tutorial text * removed tutorial header * added back link to tutorial pagee * added Character header to soulspawn event * styled stars and added shrinking animation and slide animation to message styles * added character map util function for default character emojis * fixed images being transparent with background * removed inline styling and added soulspawn-subheader class * comment out previous code for emoji mapping for later use * fixed type in exprience points system * fixed character subheader placement * update help commands * added modal component and instruction modal state * Fixing doubled context on unsafe message * Parsing events with capitalization * Fixing grammar in leave and arrive events * added header to instruction modal content * added copy to modal and back functionality to tutorial page back button * styled instruction modal and added tutorial screenshots * added closes functionality to modal * added new back button to terms and about pages * set modal to not render unless player xp<=10 * fixed typo in minitutorial * Update index.js * added help entry * updated styles * added send button and styles to chat input component * generative start features * moar * requirements change * aadded play button to bottom of tutorial page * added status entry * humanz (#228) * added and styled inventory message entry * added button revisions * Update Actions.js * fixed mobile styling for entry * restyled inventory message and made it responsive * refactored status message * restyled help entry with requested revisions * Added and styled Quest component and added it to entry component * merged other entries and removed console logs * merged all branches * restyled home page * fixed sizing bug * refactored landing app * restyled aboutpage * restyled tutorialpage * restyled terms page * restyled login page * restyled error page and logout page * styling gameapp * restyling chatlog for mobile * added isMobile state and restyled modal * added drawer feature * added resize state and event listener * added glowing button component removed typos in gameapp/styles.css building MobileFrame component * added mobile frame header * added toggleswitch, header, and buttons to mobile frame * connected mobile frame to gameapp * styled toggle and header * fixed responsive sizing in mobile frame * fixed speech bubble tails responsiveness * fixed chat icon positioning in mobile view * fixing chatlog styles * fixed chat alignment issues in mobile ui * added tooltip and lable to sidebar toggle switch * fixed spacing issue from help message (#238) * fixed spacing issue from help message * fixed sizing issue on tutorial screen * Mobile restyling Fixes (#239) * fixed spacing issue from help message * fixed sizing issue on tutorial screen * fixing borders and sizing issues * added styles for mobile landscape view * fixed fixed positioning in mobile view * cleared unused styles * fixed progress bar text * fixed text and nameplate styling and landing app tutorial page * added space at footer for landing app pages * fixed fonts on level dispaly and progress bar, changed logout button text color * fixed sizing of messages, sizing of text, send button styling * parse actions with wierd quotes (#244) * Updating parser for multithreading (#251) * added say and do buttons added documentation * removed unused code and added more documentation to chatdisplay component * adding mobile style fixes to progress bar and level display * wired tell feature * fixed repsonsive styling of player info icons on mobile * adding redux * added redux and redux toolkit * added typescript to game app * Server data browsing scripts and fixes (#255) * Requirements fix (#258) * Human to player (#259) * Merging _human and is_player * Removing old function * No longer true case about cap on characters * Crowdsourcing UI (#261) * fixed spacing issue from help message * fixed sizing issue on tutorial screen * fixing borders and sizing issues * added styles for mobile landscape view * fixed fixed positioning in mobile view * cleared unused styles * fixed progress bar text * fixed text and nameplate styling and landing app tutorial page * added space at footer for landing app pages * added views * updating structure * added example card component * added copy arrays, styling example cards, and building good example list * styled example list components * styling preview view * adjusted content and overflow to be right of it's label, fixed intro copy, fixed coloring in details section * fixed details interaction copy * fixed alignment of example card content * building button * fixed placement of definitions and added spacing * pre-merge * added error and success toats * added screenshot to tutorial, added toast to submit * duplicated previous task * formatting constraint events task * fixed conf * restructuring app * building multiple choice * added answer form * built reusable question components, added copy, building and styling forms * added fieldQuestion component * added fieldrow component * added attributesetter component * added constraints component and questions * styled question components, headers, and layout * added multiple select question component * built attribute setter, attribute row, and added dummy data * styled attribute setter * connected dummy Data, restyled events and constraint containers, colored object names * added copy updates from initial thoughts, added location description question * added taskdatacards and datacard component * styling cards and field row border * added formatquestion component * minor style fixes on field row, added formatquestion component to task card * added format question component to boolean question component * fixed formatquestion component * added drop down component and submit checklist components * fixed positioning and fixing numbering for questions * added delete functionality to attribute setter * added and styled submission component * Adding new example copy, passing name and descriptions (#245) * pre pull * pre pull * Fixing clobbered run_task.py (#246) * Adding new example copy, passing name and descriptions * Fixing run_task.py * Fixing script config * successfully updated run_task * added and styled description to object selector, form tips, and preview image * fixed payload update * updated example card component with primary and secondary desc and styled text * updated example card component with primary and secondary desc and styled text * Task2 submit (#248) * adding state for payload * added error state * centralizing copy * added isReversible, removeItems, isRemovingItems isCreatingEntity, createdEntity, isSecondaryHeld state * building updatedRemoveObjects * added create entity event to submission handler * added events and constraints handling and packaging for payload submission * wired constraint and event state to constraint and event components * connected new copy object to events * wiring task 2 * wiring event forms * fixed field row styles * added tooltip component, building preview and tutorial copy object * added task 2 tutorial copy, added and styled tutorial entry component, added and styled preview view * updated copy for preview and updated layout * added screenshots for Preview * finishing final submission and preview changes * fixed create entity connection to submission * connected constraints and fixed submission state * building error handling and checklist component logic * building error handling and checklist component logic * added error key to task copy file * added error toasts, error key, and completion checkboxes component * fixed checkbox, restyled headers, added plus icon to add attribute button * fixed error handling for broadcast messsage and item description changes * fixed attribute setter connection to submission payload * added documentation to components, removed console logs, fixed tooltip styling, and added mephisto handleSubmit to submit function * Fixed spacing, removed improperly placed checkboxes, updated copy, updated screenshots * merge * Finalizing Narrations pilot (#257) * Moving files * Importing new examine script * Updated review scripts * Final changes for pilot * dropped configs * style changes based on user feedback * Missing css class * Fixing run, fixing copy * Updating Attributes task final pilot * Is safe is light task (#256) * Troubleshooting image loading issue * added task4, added multiple choice, added run tas and yaml files, build task state * added task4, added multiple choice, added run tas and yaml files, build task state * added Sucess and Error Banners * added copy to task copy, restructuring QuestionBlock component * added format question, updated taskcopy, added header to QuestionBlock * added tooltip component * added checkbox component * restyled question block orietation, removed unused styles * added error handling and submissionhandler * properly styled error banner * fixed submission issues * added bootstrap styles, updated comments on Question Block and multiplechoice components, added more copy for preview * several minor styling fixes, checkbox positioning, alert color, etc * Task2 locationupdate (#254) * Troubleshooting image loading issue * added, connected, and styled onSelectQuestion component for handling location change event * added, connected, and styled onSelectQuestion component for handling location change event * added error handling for new location * removed console.logs from question on select and converted inline styles to classes * Updating folder location Co-authored-by: Jack Urbanek <[email protected]> * Merging task 3 into crowdsourcing ui (#260) * Troubleshooting image loading issue * initial setup complete * building Actor Block * adding actor block draw functionality * adding actor block draw functionality * added styles, building window size state * added getDimensions utility function, added dimension state to scale component, connectect state to konva stage * added scale range optionblock footer, styled scale question component and subcomponents, connected dummy data from app.js to task component * added color gradient for scale, fixing some border styling, and sizing issues * fixed styling and fixed drag boundaries * adding more informative variables and comments, fixed boundaries, tooling with flag sizing * added GetFlagDimensions util function, breaking down scale component into scalefield scalerange scale flag selection gallery components * fixed scaleRange component to map through array of ranges replacing previous hardcoded values * changed ScaleRange component name to ScaleFooter * change pixels to percentages in scalerange section width * added documentation to ScaleQuestion component * Fixed left boundary, broke flags and selection gallery into components * fixing flag placement * Added input header, added documentation, fixed leftSoftBoundary, fixed left flagpole shift, added rating value to selection state * building task copy and dummy data * added task copy * wiring task copy into question components * added tagrow and tagquestion * styled attributes tag question * added datatype switch for testing * added conditional rendering to number form in tag question * added state to tokenizer * added ref to tokenizer, added header to copy, added header prop to tag question * Task3 scale component (#249) * building Actor Block * adding actor block draw functionality * adding actor block draw functionality * added styles, building window size state * added getDimensions utility function, added dimension state to scale component, connectect state to konva stage * added scale range optionblock footer, styled scale question component and subcomponents, connected dummy data from app.js to task component * added color gradient for scale, fixing some border styling, and sizing issues * fixed styling and fixed drag boundaries * adding more informative variables and comments, fixed boundaries, tooling with flag sizing * added GetFlagDimensions util function, breaking down scale component into scalefield scalerange scale flag selection gallery components * fixed scaleRange component to map through array of ranges replacing previous hardcoded values * changed ScaleRange component name to ScaleFooter * change pixels to percentages in scalerange section width * added documentation to ScaleQuestion component * Fixed left boundary, broke flags and selection gallery into components * fixing flag placement * Added input header, added documentation, fixed leftSoftBoundary, fixed left flagpole shift, added rating value to selection state * pre payload branch * added scaled attribute basevalues * added updateHandler * fixed attributeupdatehandler * fixed boolean payload change handler * fixed custom scale rating and input * fixed numberic attribute handler * added numeric attributes array * added multiple select question and Usefulness scale * added default questions for each type to task copy * added attribute questions component and added more documentation to Task component * fixing tag question component added tooltip component * updated defaultAttribute questions styles and update functions * fixed multiple choice component * added selection consideration to multiplechoice component * added more informative error banner * tested submit successfully * fixed scale component header alignment * premerge changes, added to tutorial copy * pre merge * removed labels from custom attribute scale, added better variables describing fixed number values in scale field, fixed indentation in multiplechoice component, changed placeholder message in tagrow * Task3 preview (#253) * added attributeChecklist screenshots * added tutorial screenshots * added final screenshot for attributeRadio * added images to TaskCopy.js * added copy and screenshots for scales and type specific tutorials * populated preview with tutorial entry components using taskcopy * added new screenshots to attributeradio2, attributeradio3 assets, styled preview * added check for 4 custom boolean attributes * changed header text color to dark blue Co-authored-by: Justin Pinero <[email protected]> Co-authored-by: JustinPinero <[email protected]> * Moving task3 * Moving safe-light task Co-authored-by: Justin Pinero <[email protected]> Co-authored-by: JustinPinero <[email protected]> * Fixing npc assignment bug (#263) * added redux foundation, added personal info slices, added xp, giftxp, persona, location, reducers * added increaseXp and decrementGiftXp to reducer actions * added foundation for redux websocket integration * added documentation to slices, wired xp and giftxp redux state into experienceinfo component * removed passed props from experience info components * added sessioninfo section to features, added session xp slice, added session spent gift exp slice * removed xp props from sidebar * fixed emoji picker redux action, added view slice * Added documentation to GamePage for new state and useEffects, removed local state in game page, sidebar, mobile header * added chatInput Slice * restructured messages and types, restyling messages * fixed overlapping system messages * restructured message types and styles, fixed help message overlap bug, restyling help message copy, removed legacy styles for all message types aside from setting, player message, and agent message * restyled help message for both mobile and desktop * Multi-agent chat first pass (#264) * Multi-agent chat first pass * First round changes, clarity * Review script * Forced timeout loop * removed console logs, unused code, added substantial documentation, restyled award stars for both mobile and PC, connected sessionspentgiftxp to AgentMessage component * added styling for safari browser, added styling for mobile, fixed mainpage scrolling on refresh bug, fixed text sizing, added scrolling to each message time, added mobile specific styling to setting message * building tutorial popover * added info button * added tutorial popover component, added gamecopy file with tutorial copy, connected popover to sidebar header and body, connected redux state to tutorial * added tooltips to both chat display and sidebar * added help mode, added on click tool tips to playerinfo, Character info, mission info, location info, soulspawn message, setting message, agent message, quest message * added tooltips and animations to quest message, status message, agent message, player messsage * added tooltips and animations for inventory, send button, chat input, and chat mode, fixed agent message help mode bug * added infobutton component, added render condition to infobutton in sidebar component, added infobutton to mobile header * fixed toggle to clear tooltips during switch when in help mode * added and styled final tool tips, fixed cycle tooltips on chat bar, fixed and restyled scrolling and sizing on chat display and sidebar * Added lightqa readme that shows how to run seq2seq2seq interactively in light. (#268) Co-authored-by: Leonard Adolphs <[email protected]> * Creating a light world object from an instance of the old graph (#269) * updated the World to initiate it from the old dataset graph * docstring * Updated lightqa readme with new checkpoints. (#270) Co-authored-by: Leonard Adolphs <[email protected]> * Clarifying the equipped objects (#271) * clarifying the equipped objects * fixed the equipping tests * Documentation time (#273) * Some initial READMEs * More readmes * Even more docs * Events docs * World docs * Creating `light` master script for ParlAI tooling (#274) * Boilerplate for LIGHT-parlai content * Re-ordering * adding common sense + world builder code * Merging in teachers and code for RL-Quests paper. (#275) * Baseline code for standardizing data loading * atomic teachers working * Cleanup atomic * quest goals teacher * Predictive machines to projects * Wild chat task and code and sweeps * Updating sweep paths to new locations * Cleaning up quests build * Finished all _operational_ quests code * Remaiing related sweeps * Dropping sweeps * Uploading relevant models, adding download paths * Rl quests merge (#276) * Baseline code for standardizing data loading * atomic teachers working * Cleanup atomic * quest goals teacher * Predictive machines to projects * Wild chat task and code and sweeps * Updating sweep paths to new locations * Cleaning up quests build * Finished all _operational_ quests code * Remaiing related sweeps * Core quests rl project code * Sweeps related to RL code * Adding missing models * Dropping sweeps * Removing _almost_ all checkpoint links * Uploading relevant models, adding download paths * Core quests rl project code * Sweeps related to RL code * Adding missing models * Removing _almost_ all checkpoint links * Removing sweeps * removing sweeps... again * Build scripts now point to real file * Intro code for new project (#279) * Creating example builder script for story agents project * Writing play map example script * Task lightgame (#281) * added gameplay task view * added gameplay task view * fixed message transmission in both gameapp reducer and task redux-slice * removed boilerplate * placed topmessage function at top of reducer * Pre-authorized worker login (#282) * First worker login test * Updating preauth to send context to target node, using salted hash * Gameapp instruction modal removal (#285) * disconnected instruction modal from GamePage * removed instructional modal * Tutorial world, full implementation (#266) * Adding flags to determine new players * Adding tutorial components, first pass * Transition from tutorial to main world seamlessly * Creating tutorial script * add models that maintain identity * override model * New secure cookies * New secure cookies, correctly * Bugfix for tests * More tutorial content Co-authored-by: Kurt Shuster <[email protected]> * Single model, reusing ActionParser (#286) * World hotfix * Small deploy-related fixes (#287) * LIGHT Tutorial fixes (#289) * commented out tutorial check for building purposes and added Tailwind and dependencies * added basic layout changes to chat display and main app container * restyled chatbar border and bgcolor * working on rotation animation * restyling chat display removed soul spawn styles broke chatbar into 3 components * removed legacy styles from app styles css move action bar to top of chat display building exp counter restyling action bar * fixing chat bar, restyling messages, added report message form component * fixed chat bar, restored functionality and reconnected state to chat buttons and send button and input, rebuilt chat bubble for player message * readded star feature, added like an dislike functionality, added report prompt and flag * restyled sidebar, added new progress bar and avatar * changed all fantasy fonts to Courier New, Courier, monospace * fixed input enter button and chat toggle, fixed chat area sizing * fixed scroll to end upon form opening * changed thumbs to check and x, added tooltips, added margins to chat rows, made check and x mutually exclusive * fixed frame sizing, fixed message coloring, right justified start and report prompts, action bar will now hide if no other agents present * fixed xp state management, fixed progress bar, moved stars to outside of chat bubble, fixing agent chat bubble, added correct session xp to base of chat * added more reported message state to redux store, added padding to agent messages, removed legacy styles from collapsible containers, and fixing report message modal * fixed modal submission, built modal with more message info, added modal submitted state to redux store * fixed giftxp state, fixed tooltips on chat controls, fixed up and down previous message cycling, fixed padding around agent messages, fixed remaing xp, fixed report modal, added report submission state to redux store, added reporting state to agent message * added drawer toggle * placed logout and info on same line * returned award stars to pre test values * Copyright fixes * Dropping mis-merged files * first pass to layout clean-up * building sideDrawer component * properly sized side drawer * added report message posting * fixed modal opacity * fixed scrollbar * fixed message spacing * fixed agent message chat bubble tail color, alignment, and orientation * fixed logout button styles * added indicators and instructions for awarding gift xp and alternate messages if player has no gift xp to give * fixed report submission bug on first submission not marking message as reported * fixed xp bar double counting session xp * fixed xp bar double counting session xp * building sidebar tab content * Add local fonts and update tailwind config * added level, remainingxp, and progressPercent to xp redux slice, added isIdle state to socket, connected new redux xp slice attributes to header and sidedrawer * fixing gift xp * Refactor to use daisyui theme color classes * Implement ChatBubble component and update the chat message UI * Improve report message modal UI * fixed gift xp, added idle state, testing idleness time out, pre polish commit * fixed spent gift xp updates * re added location info in sidebar, restyled logout button * replaced window icons in collapsible containers with plus icons * polish chat input controls * Polish ActionBar and minor tweaks to chat input * style updates * moved star to correct side of player message Co-authored-by: Justin Pinero <[email protected]> Co-authored-by: JustinPinero <[email protected]> Co-authored-by: Jason Weston <[email protected]> Co-authored-by: Leonard <[email protected]> Co-authored-by: Leonard Adolphs <[email protected]> Co-authored-by: Mojtaba <[email protected]> Co-authored-by: Alex Gurung <[email protected]> Co-authored-by: Alex Gurung <[email protected]> Co-authored-by: Kurt Shuster <[email protected]> Co-authored-by: William Ngan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Centralized all copy for both preview and task into single file: TaskCopy.js in src directory.
Added Error Toast component.
Began adding error handling on submission as swell as completion logic for checklist.
Testing
Currently the submit button will console log the payload being sent to the backend for the purpose of confirming it is formatted correctly for the backend. Dummy data is still present in the submission checklist and the values of the action being displayed by the task.
ToDos
Construction
Testing