Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

added Character header to soulspawn event #212

Merged
merged 2 commits into from
May 4, 2021

Conversation

JustinPinero
Copy link
Contributor

  • Added Character header to soul spawn event.
    image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 3, 2021
Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright to me! One nit on cleanliness.

Comment on lines 36 to 40
textDecoration: "underline",
marginBottom: "0",
fontFamily: "fantasy",
fontWeight: "900",
fontSize: "18px",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicated between YOUR CHARACTER and YOUR MISSION, and should probably be in a CSS file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will put that in a css file now.

@JustinPinero JustinPinero merged commit 7a1d5df into pre-alpha-fixes3 May 4, 2021
@JackUrb JackUrb mentioned this pull request May 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants