Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

More backend and event fixes pre-launch #208

Merged
merged 5 commits into from
Apr 30, 2021
Merged

More backend and event fixes pre-launch #208

merged 5 commits into from
Apr 30, 2021

Conversation

JackUrb
Copy link
Contributor

@JackUrb JackUrb commented Apr 30, 2021

Overview

Tackles a number of issues that have arisen in the final hours. Enough work to have pushed us back a bit, but there's less and less that can be wrong. Ended up being more disparate changes than I'd normally like in a single PR, but nothing too crazy

  1. Fixes the use_events of complex_world.json, such that they should all be functioning.
  2. Updates some use_event semantics to be able to consider backup events, should all remaining_uses of an event be consumed. (This allows us to put additional events that will occur infinitely, but only after the bounded event is used).
  3. Adds toggle to enable the content loggers, such that in prod we now save interactions
  4. Special case to handle the _=_ route, which I'm still not sure where it comes from other than it being an artifact of doing a login through facebook
  5. Migration of routes to /play/ so that the hash router doesn't appear concatenated with play
  6. Updated overall UseEvent flow to store the processed events in, such that on replay we don't parse them out again. This also changes how view_as operates for UseEvent, as these events are now all stored in the root event.
  7. Updates heuristics to return if they've actually executed something, this way the generative agent doesn't move to take an additional timestep on these occurrences
  8. Updates base EXP gain for completing quests from 50 to 20.
  9. Makes it so that we can see the full history in a DEBUG chat turn, regardless of safety.

Implementation

  1. Found an altered json, copied the contents. All changes direct to complex_world.json
  2. In iterating over possible on_use dicts in the on_use function, we now continue to search if we discover an event, but the max uses have already been consumed
  3. Simple argument parser add to run_server, but then a change to the MapJsonBuilder to ensure that the argument is passed over to the content loggers via the graph._opt field.
  4. Additional route in our HashRouter for the game. Need to actually figure this out still though.
  5. Ctrl-f for /play
  6. Events are now stored in the self.events entry, which ends up able to be bundled into a JSON like any other events.
  7. Changes to the GenerativeHeuristicModelSoul.observe_event function, such that we early-exit if underlying functions do take actions.
  8. Self explanatory
  9. Adds skip_safety attribute to SpeechEvent which allows them to skip the dialogue safety check. Uses this in the DEBUG response.

Testing

Played around in the game world and tested some use events. Checked the logs that ended up saved on the backend. Checked routes. Tested completing quests, ensured that the experience is now retained.

Didn't get to check the scrolls, as I didn't stumble upon them in my testing.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 30, 2021
[
"broadcast_message",
{
"remaining_uses": "inf",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably we don't actually want these to have inifinite use, but..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with all the fixes!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair - I imagine it would be a possible vector for someone to infinitely increase the size of something, and then suddenly nobody can enter a room anymore. I'll update this

@JackUrb JackUrb merged commit cbbfd51 into master Apr 30, 2021
@JackUrb JackUrb deleted the more-event-fixes branch April 30, 2021 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants